Differential D29119 Diff 81997 src/settings/services/servicemenuinstaller/CMakeLists.txt

Changeset View

Standalone View

View Options

src/settings/services/servicemenuinstaller/CMakeLists.txt

1remove_definitions(-DTRANSLATION_DOMAIN=\"dolphin\") 1​remove_definitions(-DTRANSLATION_DOMAIN=\"dolphin\")
2add_definitions(-DTRANSLATION_DOMAIN=\"dolphin_servicemenuinstaller\") 2​add_definitions(-DTRANSLATION_DOMAIN=\"dolphin_servicemenuinstaller\")
3 3​
4add_executable(servicemenuinstaller servicemenuinstaller.cpp) 4​add_executable(servicemenuinstaller servicemenuinstaller.cpp)
5target_link_libraries(servicemenuinstaller PRIVATE 5​target_link_libraries(servicemenuinstaller PRIVATE
anthonyfieroniUnsubmitted
Done

Unrelated change, keep private linking.

anthonyfieroni: Unrelated change, keep private linking.
6 Qt5::Core 6​ Qt5::Core
7 Qt5::Gui 7​ Qt5::Gui
8 KF5::I18n 8​ KF5::I18n
9 KF5::CoreAddons 9​ KF5::CoreAddons
anthonyfieroniUnsubmitted
Done

It should be optional.

anthonyfieroni: It should be optional.
alexAuthorUnsubmitted
Done

Does this comment still apply after the latest update to the diff?

alex: Does this comment still apply after the latest update to the diff?
anthonyfieroniUnsubmitted
Done

It's ok now.

anthonyfieroni: It's ok now.
10) 10​)
11​
elvisangelaccioUnsubmitted
Done

Please move it to src/CMakeLists.txt

elvisangelaccio: Please move it to `src/CMakeLists.txt`
12​if(HAVE_PACKAGEKIT)
anthonyfieroniUnsubmitted
Done

Add PRIVATE as well here.

anthonyfieroni: Add `PRIVATE` as well here.
13​ target_link_libraries(servicemenuinstaller PRIVATE PK::packagekitqt5)
14​endif()
11install(TARGETS servicemenuinstaller ${KDE_INSTALL_TARGETS_DEFAULT_ARGS}) 15​install(TARGETS servicemenuinstaller ${KDE_INSTALL_TARGETS_DEFAULT_ARGS})