Differential D2584 Diff 6680 kcmkwin/kwincompositing/compositing.ui

Changeset View

Standalone View

View Options

kcmkwin/kwincompositing/compositing.ui

1<?xml version="1.0" encoding="UTF-8"?> 1​<?xml version="1.0" encoding="UTF-8"?>
2<ui version="4.0"> 2​<ui version="4.0">
3 <class>CompositingForm</class> 3​ <class>CompositingForm</class>
4 <widget class="QWidget" name="CompositingForm"> 4​ <widget class="QWidget" name="CompositingForm">
5 <property name="geometry"> 5​ <property name="geometry">
6 <rect> 6​ <rect>
7 <x>0</x> 7​ <x>0</x>
8 <y>0</y> 8​ <y>0</y>
9 <width>481</width> 9​ <width>815</width>
10 <height>349</height> 10​ <height>510</height>
sebasUnsubmitted
Not Done

resize the window before saving, that means it saves the minimum size, rather than a random one

sebas: resize the window before saving, that means it saves the minimum size, rather than a random one
graesslinAuthorUnsubmitted
Not Done

That is the minimum size ;-)

graesslin: That is the minimum size ;-)
sebasUnsubmitted
Not Done

So your change made the window's minimum width more than 300px wider? That sounds wrong...

What I mean is to resize the form in designer to the smallest possible size before you save it there, perhaps that got lost in translation.

sebas: So your change made the window's minimum width more than 300px wider? That sounds wrong...
luebkingUnsubmitted
Not Done

The stored size should be rather irrelevant, for it is tied to the style used by the developer at creation of the widget anyway.

Ie. if there's desire to use the minimum size at some point, one should ::adjustSize() at runtime.
Otherwise the size is (hopefully still attempted) to be restored from the last user provided size anyway.

luebking: The stored size should be rather irrelevant, for it is tied to the style used by the developer…
graesslinAuthorUnsubmitted
Not Done

So your change made the window's minimum width more than 300px wider? That sounds wrong...

Figured out how that happened: high dpi. I just started designer with low dpi settings and have it now small and tiny again.

graesslin: > So your change made the window's minimum width more than 300px wider? That sounds wrong...
11 </rect> 11​ </rect>
12 </property> 12​ </property>
13 <layout class="QFormLayout" name="formLayout"> 13​ <layout class="QFormLayout" name="formLayout">
14 <property name="fieldGrowthPolicy"> 14​ <property name="fieldGrowthPolicy">
15 <enum>QFormLayout::AllNonFixedFieldsGrow</enum> 15​ <enum>QFormLayout::AllNonFixedFieldsGrow</enum>
16 </property> 16​ </property>
17 <item row="0" column="0" colspan="2"> 17​ <item row="0" column="0" colspan="2">
18 <layout class="QVBoxLayout" name="verticalLayout_4"> 18​ <layout class="QVBoxLayout" name="verticalLayout_4">
19 <item> 19​ <item>
20 <widget class="KMessageWidget" name="glCrashedWarning"> 20​ <widget class="KMessageWidget" name="glCrashedWarning">
21 <property name="visible"> 21​ <property name="visible">
22 <bool>false</bool> 22​ <bool>false</bool>
23 </property> 23​ </property>
24 <property name="text"> 24​ <property name="text" stdset="0">
sebasUnsubmitted
Not Done

dunno where this comes from, and what it means ... also in the following places

sebas: dunno where this comes from, and what it means ... also in the following places
graesslinAuthorUnsubmitted
Not Done

Neither do I, designer added it - not going to modify the file manually, though

graesslin: Neither do I, designer added it - not going to modify the file manually, though
25 <string>OpenGL compositing (the default) has crashed KWin in the past. 25​ <string>OpenGL compositing (the default) has crashed KWin in the past.
26This was most likely due to a driver bug. 26​This was most likely due to a driver bug.
27If you think that you have meanwhile upgraded to a stable driver, 27​If you think that you have meanwhile upgraded to a stable driver,
28you can reset this protection but be aware that this might result in an immediate crash! 28​you can reset this protection but be aware that this might result in an immediate crash!
29Alternatively, you might want to use the XRender backend instead.</string> 29​Alternatively, you might want to use the XRender backend instead.</string>
30 </property> 30​ </property>
31 <property name="wordWrap"> 31​ <property name="wordWrap" stdset="0">
32 <bool>true</bool> 32​ <bool>true</bool>
33 </property> 33​ </property>
34 <property name="messageType"> ​
35 <enum>KMessageWidget::Warning</enum> ​
36 </property> ​
37 </widget> 34​ </widget>
38 </item> 35​ </item>
39 <item> 36​ <item>
40 <widget class="KMessageWidget" name="scaleWarning"> 37​ <widget class="KMessageWidget" name="scaleWarning">
41 <property name="visible"> 38​ <property name="visible">
42 <bool>false</bool> 39​ <bool>false</bool>
43 </property> 40​ </property>
44 <property name="text"> 41​ <property name="text" stdset="0">
45 <string>Scale method &quot;Accurate&quot; is not supported by all hardware and can cause performance regressions and rendering artifacts.</string> 42​ <string>Scale method &quot;Accurate&quot; is not supported by all hardware and can cause performance regressions and rendering artifacts.</string>
46 </property> 43​ </property>
47 <property name="wordWrap"> 44​ <property name="wordWrap" stdset="0">
48 <bool>true</bool> 45​ <bool>true</bool>
49 </property> 46​ </property>
50 <property name="messageType"> ​
51 <enum>KMessageWidget::Warning</enum> ​
52 </property> ​
53 </widget> 47​ </widget>
54 </item> 48​ </item>
55 <item> 49​ <item>
56 <widget class="KMessageWidget" name="tearingWarning"> 50​ <widget class="KMessageWidget" name="tearingWarning">
57 <property name="visible"> 51​ <property name="visible">
58 <bool>false</bool> 52​ <bool>false</bool>
59 </property> 53​ </property>
60 <property name="wordWrap"> 54​ <property name="wordWrap" stdset="0">
61 <bool>true</bool> 55​ <bool>true</bool>
62 </property> 56​ </property>
63 <property name="messageType"> ​
64 <enum>KMessageWidget::Warning</enum> ​
65 </property> ​
66 </widget> 57​ </widget>
67 </item> 58​ </item>
68 <item> 59​ <item>
69 <widget class="KMessageWidget" name="windowThumbnailWarning"> 60​ <widget class="KMessageWidget" name="windowThumbnailWarning">
70 <property name="visible"> 61​ <property name="visible">
71 <bool>false</bool> 62​ <bool>false</bool>
72 </property> 63​ </property>
73 <property name="text"> 64​ <property name="text" stdset="0">
74 <string>Keeping the window thumbnail always interferes with the minimized state of windows. This can result in windows not suspending their work when minimized.</string> 65​ <string>Keeping the window thumbnail always interferes with the minimized state of windows. This can result in windows not suspending their work when minimized.</string>
75 </property> 66​ </property>
76 <property name="wordWrap"> 67​ <property name="wordWrap" stdset="0">
77 <bool>true</bool> 68​ <bool>true</bool>
78 </property> 69​ </property>
79 <property name="messageType"> ​
80 <enum>KMessageWidget::Warning</enum> ​
81 </property> ​
82 </widget> 70​ </widget>
83 </item> 71​ </item>
84 </layout> 72​ </layout>
85 </item> 73​ </item>
86 <item row="1" column="0" colspan="2"> 74​ <item row="1" column="0" colspan="2">
87 <widget class="QCheckBox" name="compositingEnabled"> 75​ <widget class="QCheckBox" name="compositingEnabled">
88 <property name="text"> 76​ <property name="text">
89 <string>Enable compositor on startup</string> 77​ <string>Enable compositor on startup</string>
▲ Show 20 Lines • Show All 200 Lines • ▼ Show 20 Line(s)
290 </item> 278​ </item>
291 <item row="12" column="1"> 279​ <item row="12" column="1">
292 <widget class="QCheckBox" name="colorCorrection"> 280​ <widget class="QCheckBox" name="colorCorrection">
293 <property name="text"> 281​ <property name="text">
294 <string>Enable color correction</string> 282​ <string>Enable color correction</string>
295 </property> 283​ </property>
296 </widget> 284​ </widget>
297 </item> 285​ </item>
286​ <item row="13" column="1">
287​ <widget class="QCheckBox" name="windowsBlockCompositing">
288​ <property name="toolTip">
289​ <string>Applications can set a hint to block compositing when the window is open.
290​ This brings performance improvements for e.g. games.
sebasUnsubmitted
Done

improvements (plural)

sebas: improvements (plural)
291​ The setting can be overruled by window-specific rules.</string>
colomarUnsubmitted
Done

window-specific

colomar: window-specific
292​ </property>
293​ <property name="text">
294​ <string>Allow applications to block compositing</string>
bshahUnsubmitted
Not Done

Even though windows is more correct term here technically, IMO it makes more sense to have it as "Allow applications to block compositing". what do you think?

bshah: Even though windows is more correct term here technically, IMO it makes more sense to have it…
295​ </property>
296​ </widget>
297​ </item>
298 </layout> 298​ </layout>
299 </widget> 299​ </widget>
300 <customwidgets> 300​ <customwidgets>
301 <customwidget> 301​ <customwidget>
302 <class>KMessageWidget</class> 302​ <class>KMessageWidget</class>
303 <extends>QFrame</extends> 303​ <extends>QFrame</extends>
304 <header>kmessagewidget.h</header> 304​ <header>kmessagewidget.h</header>
305 <container>1</container> 305​ <container>1</container>
306 </customwidget> 306​ </customwidget>
307 </customwidgets> 307​ </customwidgets>
308 <resources/> 308​ <resources/>
309 <connections/> 309​ <connections/>
310</ui> 310​</ui>