Differential D28744 Diff 81441 kcms/keys/shortcutsmodel.h

Changeset View

Standalone View

View Options

kcms/keys/shortcutsmodel.h

  • This file was added.
1​/*
2​ * Copyright 2020 David Redondo <kde@david-redondo.de>
3​ *
4​ * This program is free software; you can redistribute it and/or
5​ * modify it under the terms of the GNU General Public License as
6​ * published by the Free Software Foundation; either version 2 of
7​ * the License or (at your option) version 3 or any later version
8​ * accepted by the membership of KDE e.V. (or its successor approved
9​ * by the membership of KDE e.V.), which shall act as a proxy
10​ * defined in Section 14 of version 3 of the license.
11​ *
12​ * This program is distributed in the hope that it will be useful,
13​ * but WITHOUT ANY WARRANTY; without even the implied warranty of
14​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15​ * GNU General Public License for more details.
16​ *
17​ * You should have received a copy of the GNU General Public License
18​ * along with this program. If not, see <http://www.gnu.org/licenses/>.
19​ */
20​
21​#ifndef SHORTCUTSMODEL_H
22​#define SHORTCUTSMODEL_H
23​
24​#include <QAbstractItemModel>
25​#include <QKeySequence>
26​#include <QDBusPendingCallWatcher>
27​#include <QList>
28​#include <QSet>
29​#include <QVector>
30​
31​
32​class QDBusError;
33​class QDBusObjectPath;
34​
35​class KConfigBase;
36​class KGlobalAccelInterface;
37​class KGlobalShortcutInfo;
38​
39​class FilteredShortcutsModel;
40​
41​struct Shortcut {
42​ QString uniqueName;
43​ QString friendlyName;
44​ QSet<QKeySequence> activeShortcuts;
45​ QSet<QKeySequence> defaultShortcuts;
46​ QSet<QKeySequence> initialShortcuts;
47​};
48​
49​struct Component {
50​ QString uniqueName;
51​ QString friendlyName;
52​ QString type;
53​ QString icon;
54​ QVector<Shortcut> shortcuts;
55​ bool checked;
broulikUnsubmitted
Done

Coding style, { on new line

broulik: Coding style, `{` on new line
56​ bool pendingDeletion;
57​};
58​
59​class ShortcutsModel : public QAbstractItemModel
broulikUnsubmitted
Done

It doesnt appear to use any private members?

broulik: It doesnt appear to use any private members?
60​{
davidreAuthorUnsubmitted
Done

It does in filterAcceptRows to not have to go through data each time

davidre: It does in filterAcceptRows to not have to go through data each time
davidreAuthorUnsubmitted
Done

Nevermind it goes through data, apparently I forgot that I changed that :)

davidre: Nevermind it goes through data, apparently I forgot that I changed that :)
61​ Q_OBJECT
62​
63​public:
64​ enum Roles {
65​ SectionRole = Qt::UserRole,
66​ ComponentRole,
67​ ActionRole,
68​ ActiveShortcutsRole,
69​ DefaultShortcutsRole,
70​ CustomShortcutsRole,
71​ CheckedRole,
72​ PendingDeletionRole
73​ };
74​ Q_ENUM(Roles)
75​
76​ ShortcutsModel(KGlobalAccelInterface *interface, QObject *parent = nullptr);
77​
78​ Q_INVOKABLE void toggleDefaultShortcut(const QModelIndex &index, const QKeySequence &shortcut, bool enabled);
79​ Q_INVOKABLE void addShortcut(const QModelIndex &index, const QKeySequence &shortcut);
80​ Q_INVOKABLE void disableShortcut(const QModelIndex &index, const QKeySequence &shortcut);
81​ Q_INVOKABLE void changeShortcut(const QModelIndex &index, const QKeySequence &oldShortcut, const QKeySequence &newShortcut);
82​
83​ void setShortcuts(const KConfigBase &config);
84​ void addApplication(const QString &desktopFileName, const QString &displayName);
crossiUnsubmitted
Done

should be const

crossi: should be const
broulikUnsubmitted
Done

const and below

broulik: `const` and below
85​
crossiUnsubmitted
Done

should be const

crossi: should be const
86​ void load();
87​ void defaults();
88​ void save();
89​ bool needsSave() const;
90​ bool isDefault() const;
91​
92​ QModelIndex index(int row, int column, const QModelIndex &parent = QModelIndex()) const override;
93​ QModelIndex parent(const QModelIndex &child) const override;
94​ int rowCount(const QModelIndex &parent = QModelIndex()) const override;
95​ int columnCount(const QModelIndex &parent = QModelIndex()) const override;
96​ QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override;
broulikUnsubmitted
Done

const QString &, also perhaps errorOccurred?

broulik: `const QString &`, also perhaps `errorOccurred`?
97​ bool setData(const QModelIndex &index, const QVariant &value, int role = Qt::EditRole) override;
98​ QHash<int, QByteArray> roleNames() const override;
99​
100​Q_SIGNALS:
101​ void errorOccured(const QString&);
102​
103​private:
104​ Component loadComponent(const QList<KGlobalShortcutInfo> &info);
105​ void removeComponent(const Component &component);
106​ void genericErrorOccured(const QString &description, const QDBusError &error);
107​
108​ KGlobalAccelInterface *m_globalAccelInterface;
109​ QVector<Component> m_components;
110​};
111​
112​#endif // SHORTCUTSMODEL_H