Changeset View
Changeset View
Standalone View
Standalone View
abstract_client.h
Show First 20 Lines • Show All 858 Lines • ▼ Show 20 Line(s) | 324 | public: | |||
---|---|---|---|---|---|
859 | 859 | | |||
860 | /** | 860 | /** | ||
861 | * Returns whether window rules can be applied to this client. | 861 | * Returns whether window rules can be applied to this client. | ||
862 | * | 862 | * | ||
863 | * Default implementation returns @c true. | 863 | * Default implementation returns @c true. | ||
864 | */ | 864 | */ | ||
865 | virtual bool supportsWindowRules() const; | 865 | virtual bool supportsWindowRules() const; | ||
866 | 866 | | |||
867 | /** | ||||
868 | * Return window management interface | ||||
869 | */ | ||||
870 | KWayland::Server::PlasmaWindowInterface *windowManagementInterface() const { | ||||
871 | return m_windowManagementInterface; | ||||
872 | } | ||||
873 | | ||||
867 | public Q_SLOTS: | 874 | public Q_SLOTS: | ||
868 | virtual void closeWindow() = 0; | 875 | virtual void closeWindow() = 0; | ||
zzag: Toplevel has already a property named `internalId`. I suggest to avoid using `internalId`. What… | |||||
bport: ok with that I wanted to avoid exposing too much, I will change that | |||||
869 | 876 | | |||
870 | Q_SIGNALS: | 877 | Q_SIGNALS: | ||
871 | void fullScreenChanged(); | 878 | void fullScreenChanged(); | ||
872 | void skipTaskbarChanged(); | 879 | void skipTaskbarChanged(); | ||
873 | void skipPagerChanged(); | 880 | void skipPagerChanged(); | ||
874 | void skipSwitcherChanged(); | 881 | void skipSwitcherChanged(); | ||
875 | void iconChanged(); | 882 | void iconChanged(); | ||
876 | void activeChanged(); | 883 | void activeChanged(); | ||
▲ Show 20 Lines • Show All 116 Lines • ▼ Show 20 Line(s) | 920 | protected: | |||
993 | bool isElectricBorderMaximizing() const { | 1000 | bool isElectricBorderMaximizing() const { | ||
994 | return m_electricMaximizing; | 1001 | return m_electricMaximizing; | ||
995 | } | 1002 | } | ||
996 | QRect electricBorderMaximizeGeometry(QPoint pos, int desktop); | 1003 | QRect electricBorderMaximizeGeometry(QPoint pos, int desktop); | ||
997 | void updateQuickTileMode(QuickTileMode newMode) { | 1004 | void updateQuickTileMode(QuickTileMode newMode) { | ||
998 | m_quickTileMode = newMode; | 1005 | m_quickTileMode = newMode; | ||
999 | } | 1006 | } | ||
1000 | 1007 | | |||
1001 | KWayland::Server::PlasmaWindowInterface *windowManagementInterface() const { | | |||
1002 | return m_windowManagementInterface; | | |||
1003 | } | | |||
1004 | | ||||
1005 | // geometry handling | 1008 | // geometry handling | ||
1006 | void checkOffscreenPosition(QRect *geom, const QRect &screenArea); | 1009 | void checkOffscreenPosition(QRect *geom, const QRect &screenArea); | ||
1007 | int borderLeft() const; | 1010 | int borderLeft() const; | ||
1008 | int borderRight() const; | 1011 | int borderRight() const; | ||
1009 | int borderTop() const; | 1012 | int borderTop() const; | ||
1010 | int borderBottom() const; | 1013 | int borderBottom() const; | ||
1011 | virtual void changeMaximize(bool horizontal, bool vertical, bool adjust); | 1014 | virtual void changeMaximize(bool horizontal, bool vertical, bool adjust); | ||
1012 | void setGeometryRestore(const QRect &rect); | 1015 | void setGeometryRestore(const QRect &rect); | ||
▲ Show 20 Lines • Show All 337 Lines • Show Last 20 Lines |
Toplevel has already a property named internalId. I suggest to avoid using internalId. What about adding a m_windowManagementInterface accessor?