Changeset View
Changeset View
Standalone View
Standalone View
abstract_client.h
Show First 20 Lines • Show All 858 Lines • ▼ Show 20 Line(s) | 324 | public: | |||
---|---|---|---|---|---|
859 | 859 | | |||
860 | /** | 860 | /** | ||
861 | * Returns whether window rules can be applied to this client. | 861 | * Returns whether window rules can be applied to this client. | ||
862 | * | 862 | * | ||
863 | * Default implementation returns @c true. | 863 | * Default implementation returns @c true. | ||
864 | */ | 864 | */ | ||
865 | virtual bool supportsWindowRules() const; | 865 | virtual bool supportsWindowRules() const; | ||
866 | 866 | | |||
867 | /** | ||||
868 | * Returns true if client is associated with a window management interface | ||||
869 | */ | ||||
870 | bool hasWindowManagementInterface() const; | ||||
871 | | ||||
872 | /** | ||||
873 | * Returns windowInternalId from window management interface. If window management interface don't exist yet return 0 | ||||
874 | */ | ||||
875 | quint32 windowInternalId() const; | ||||
zzag: Toplevel has already a property named `internalId`. I suggest to avoid using `internalId`. What… | |||||
bport: ok with that I wanted to avoid exposing too much, I will change that | |||||
876 | | ||||
867 | public Q_SLOTS: | 877 | public Q_SLOTS: | ||
868 | virtual void closeWindow() = 0; | 878 | virtual void closeWindow() = 0; | ||
869 | 879 | | |||
870 | Q_SIGNALS: | 880 | Q_SIGNALS: | ||
871 | void fullScreenChanged(); | 881 | void fullScreenChanged(); | ||
872 | void skipTaskbarChanged(); | 882 | void skipTaskbarChanged(); | ||
873 | void skipPagerChanged(); | 883 | void skipPagerChanged(); | ||
874 | void skipSwitcherChanged(); | 884 | void skipSwitcherChanged(); | ||
▲ Show 20 Lines • Show All 475 Lines • Show Last 20 Lines |
Toplevel has already a property named internalId. I suggest to avoid using internalId. What about adding a m_windowManagementInterface accessor?