Differential D28882 Diff 80605 src/client/protocols/screencast.xml

Changeset View

Standalone View

View Options

src/client/protocols/screencast.xml

  • This file was added.
1​<?xml version="1.0" encoding="UTF-8"?>
2​<protocol name="org_kde_kwin_screencast_unstable_v1">
3​ <copyright><![CDATA[
4​ SPDX-FileCopyrightText: 2020 Aleix Pol Gonzalez <aleixpol@kde.org>
5​
6​ SPDX-License-Identifier: LGPL-2.1-or-later
7​ ]]></copyright>
8​ <interface name="org_kde_kwin_screencast_unstable_v1" version="1">
9​ <description summary="Protocol for managing Pipewire feeds of the different displays and windows."/>
romanggUnsubmitted
Done

Interface names should be scoped too. Example.

Don't ask me why exactly why. I think it has something to do with the C structs becoming ambiguous otherwise. Someone else knows?

But in any case I would follow the examples set by upstream.

romangg: Interface names should be scoped too. [[ https://gitlab.freedesktop.org/wayland/wayland…
zzagUnsubmitted
Not Done

Interfaces usually come without unstable in the name.

s/zkde_screencast_unstable_v1/zkde_screencast_v1/

zzag: Interfaces usually come without `unstable` in the name.
10​
11​ <enum name="SourceType">
12​ <description summary="describes enabled state, follows org.freedesktop.impl.portal.ScreenCast.xml"/>
13​ <entry name="monitor" value="1"/>
14​ <entry name="window" value="2"/>
jgrulichUnsubmitted
Done

Can we switch the values to follow xdg-desktop-portal specification?

See https://github.com/flatpak/xdg-desktop-portal/blob/master/data/org.freedesktop.impl.portal.ScreenCast.xml#L168.

Even not following the specs, output will be the most used one.

jgrulich: Can we switch the values to follow xdg-desktop-portal specification? See https://github.
15​ </enum>
16​ <event name="addSource">
17​ <description summary="Notifies about a feed being created"/>
davidedmundsonUnsubmitted
Done

Typically events are like signals, so would be called "source_added"

Convention is also lower_snake_case

davidedmundson: Typically events are like signals, so would be called "source_added" Convention is also…
18​ <arg name="sourceId" type="uint" summary="the source identifier"/>
19​ <arg name="description" type="string" summary="human readable text defining what the source is"/>
20​ <arg name="iconName" type="string" summary="icon name that defines the source (e.g. computer-laptop, window, tv)"/>
21​ <arg name="type" type="uint" summary="if it's a composited output (e.g a display) or a window instead"/>
22​ <arg name="geometryX" type="int" summary="geometry.x"/>
23​ <arg name="geometryY" type="int" summary="geometry.y"/>
24​ <arg name="geometryWidth" type="int" summary="geometry.width"/>
25​ <arg name="geometryHeight" type="int" summary="geometry.height"/>
26​ </event>
27​ <event name="removeSource">
28​ <description summary="Notifies about a source becoming unavailable"/>
29​ <arg name="sourceId" type="uint" summary="the source identifier"/>
30​ </event>
31​
32​ <event name="done">
davidedmundsonUnsubmitted
Not Done

this is racey with create.

davidedmundson: this is racey with create.
apolAuthorUnsubmitted
Not Done

Any suggestion on how to do it better?

apol: Any suggestion on how to do it better?
33​ <description summary="Notifies that the initial propagation of sources is over"/>
34​ </event>
35​ <event name="created">
36​ <description summary="Notifies about a pipewire feed being created"/>
37​ <arg name="nodeid" type="uint" summary="nodeid of the pipewire buffer"/>
38​ <arg name="sourceId" type="uint" summary="source the buffer is for"/>
39​ </event>
40​ <event name="failed">
41​ <description summary="Offers an error message so the client knows created will not arrive"/>
42​ <arg name="sourceId" type="uint" summary="source the buffer is for"/>
43​ <arg name="error" type="string" summary="error message"/>
44​ </event>
45​
46​ <request name="create">
47​ <description summary="requests a feed from a given source"/>
davidedmundsonUnsubmitted
Not Done

add type = "destructor"

so that clients calling this release the resource

davidedmundson: add type = "destructor" so that clients calling this release the resource
48​ <arg name="sourceId" type="uint"/>
49​ </request>
50​ <request name="close">
51​ <description summary="notifies about being done with the source"/>
52​ <arg name="nodeid" type="uint"/>
53​ </request>
54​
55​ </interface>
zzagUnsubmitted
Not Done

zkde_screencast_stream_unstable_v1 must have a destructor request.

zzag: zkde_screencast_stream_unstable_v1 must have a destructor request.
56​</protocol>