Differential D19913 Diff 80170 src/plasma/private/theme_p.cpp

Changeset View

Standalone View

View Options

src/plasma/private/theme_p.cpp

Show First 20 Lines • Show All 829 Lines • ▼ Show 20 Line(s)825 while (!fallback.isEmpty() && !fallbackThemes.contains(fallback)) {
830 KConfigGroup cg(&metadata, "Settings"); 830​ KConfigGroup cg(&metadata, "Settings");
831 fallback = cg.readEntry("FallbackTheme", QString()); 831​ fallback = cg.readEntry("FallbackTheme", QString());
832 } 832​ }
833 833​
834 if (!fallbackThemes.contains(QLatin1String(ThemePrivate::defaultTheme))) { 834​ if (!fallbackThemes.contains(QLatin1String(ThemePrivate::defaultTheme))) {
835 fallbackThemes.append(QLatin1String(ThemePrivate::defaultTheme)); 835​ fallbackThemes.append(QLatin1String(ThemePrivate::defaultTheme));
836 } 836​ }
837 837​
838 foreach (const QString &theme, fallbackThemes) { 838​ for (const QString &theme : qAsConst(fallbackThemes)) {
839 QString metadataPath(QStandardPaths::locate(QStandardPaths::GenericDataLocation, QLatin1String(PLASMA_RELATIVE_DATA_INSTALL_DIR "/desktoptheme/") % theme % QLatin1String("/metadata.desktop"))); 839​ QString metadataPath(QStandardPaths::locate(QStandardPaths::GenericDataLocation, QLatin1Literal(PLASMA_RELATIVE_DATA_INSTALL_DIR "/desktoptheme/") % theme % QLatin1Literal("/metadata.desktop")));
ahmadsamirUnsubmitted
Not Done

s/QLatin1Literal/QStringLiteral/

ahmadsamir: s/QLatin1Literal/QStringLiteral/
840 KConfig metadata(metadataPath, KConfig::SimpleConfig); 840​ KConfig metadata(metadataPath, KConfig::SimpleConfig);
841 processWallpaperSettings(&metadata); 841​ processWallpaperSettings(&metadata);
842 } 842​ }
843 843​
844 //Check for what Plasma version the theme has been done 844​ //Check for what Plasma version the theme has been done
845 //There are some behavioral differences between KDE4 Plasma and Plasma 5 845​ //There are some behavioral differences between KDE4 Plasma and Plasma 5
846 cg = KConfigGroup(&metadata, "Desktop Entry"); 846​ cg = KConfigGroup(&metadata, "Desktop Entry");
847 const QString apiVersion = cg.readEntry("X-Plasma-API", QString()); 847​ const QString apiVersion = cg.readEntry("X-Plasma-API", QString());
▲ Show 20 Lines • Show All 46 Lines • Show Last 20 Lines