Differential D28744 Diff 80136 kcms/keys/package/contents/ui/main.qml

Changeset View

Standalone View

View Options

kcms/keys/package/contents/ui/main.qml

  • This file was added.
1​/*
2​ * Copyright (C) 2020 David Redondo <david@david-redondo.de>
3​ *
4​ * This program is free software; you can redistribute it and/or modify
5​ * it under the terms of the GNU General Public License as published by
6​ * the Free Software Foundation; either version 2 of the License, or
7​ * (at your option) any later version.
8​ *
9​ * This program is distributed in the hope that it will be useful,
10​ * but WITHOUT ANY WARRANTY; without even the implied warranty of
11​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12​ * GNU General Public License for more details.
13​ *
14​ * You should have received a copy of the GNU General Public License along
15​ * with this program; if not, write to the Free Software Foundation, Inc.,
16​ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
17​ */
18​
19​import QtQuick 2.14
20​import QtQuick.Dialogs 1.3
21​import QtQuick.Layouts 1.1
22​import QtQuick.Controls 2.3 as QQC2
23​import QtQml 2.14
24​import QtQml.Models 2.3
25​
26​import org.kde.kirigami 2.10 as Kirigami
27​import org.kde.kcm 1.2 as KCM
28​
29​KCM.SimpleKCM {
30​ id: root
31​ implicitWidth: 800
broulikUnsubmitted
Not Done

Kirigami.Units.gridUnit

broulik: `Kirigami.Units.gridUnit`
32​ implicitHeight: 600
ngrahamUnsubmitted
Done

The ratio between these is kind of unpleasant; I would recommend 800x600

ngraham: The ratio between these is kind of unpleasant; I would recommend 800x600
33​ enabled: kcm.lastError == ""
34​ property alias exportActive: exportInfo.visible
broulikUnsubmitted
Done

This appears to loop? exportInfo's visible is bound to this

broulik: This appears to loop? `exportInfo`'s `visible` is bound to this
35​ ColumnLayout {
broulikUnsubmitted
Done

Coding style: ColumnLayout {

broulik: Coding style: `ColumnLayout {`
36​ anchors.fill: parent
37​ Kirigami.InlineMessage {
broulikUnsubmitted
Done

Huh?

broulik: Huh?
38​ Layout.fillWidth: true
39​ visible: kcm.lastError !== ""
40​ text: kcm.lastError
41​ type: Kirigami.MessageType.Error
broulikUnsubmitted
Done

Coding style, also !==

broulik: Coding style, also `!==`
42​ }
43​ Kirigami.InlineMessage {
44​ id: exportWarning
45​ Layout.fillWidth: true
46​ text: i18n("Cannot export scheme while there are unsaved changes")
47​ type: Kirigami.MessageType.Warning
48​ showCloseButton: true
49​ Binding on visible {
50​ when: exportWarning.visible
51​ value: kcm.needsSave
52​ restoreMode: Binding.RestoreNone
53​ }
54​ }
broulikUnsubmitted
Done

What Qt version was that changed, 5.14?
Also why not just bind?

broulik: What Qt version was that changed, 5.14? Also why not just bind?
davidreAuthorUnsubmitted
Done

The way I used it caused a binding loop

Binding on visible {
                when: exportWarning.visible
                value: kcm.needsSave
                restoreMode: Binding.RestoreValue
            }
davidre: The way I used it caused a binding loop ``` Binding on visible { when…
55​ Kirigami.InlineMessage {
56​ id: exportInfo
57​ Layout.fillWidth: true
58​ text: i18n("Select the components below that should be included in the exported scheme")
59​ type: Kirigami.MessageType.Information
60​ showCloseButton: true
61​ actions: [
62​ Kirigami.Action {
63​ iconName: "document-save"
ngrahamUnsubmitted
Done

Maybe Select the components below... for extra clarity?

ngraham: Maybe `Select the components below...` for extra clarity?
64​ text: i18n("Save scheme")
65​ onTriggered: {
66​ fileDialogLoader.save = true
ngrahamUnsubmitted
Done

Probably needs a "select all" action to make exporting everything not be incredibly frustrating

ngraham: Probably needs a "select all" action to make exporting everything not be incredibly frustrating
67​ fileDialogLoader.active = true
68​ exportActive = false
69​ }
70​ }
71​ ]
72​ }
73​ Kirigami.SearchField {
74​ id: search
75​ enabled: !exportActive
76​ Layout.fillWidth: true
77​ Binding {
78​ target: kcm.filteredModel
79​ property: "filter"
80​ value: search.text
81​ }
82​ }
ngrahamUnsubmitted
Done

Would be nice to filter immediately as the user types rather than having to hit the return key

ngraham: Would be nice to filter immediately as the user types rather than having to hit the return key
83​ GridLayout {
84​ columns: 2
85​ QQC2.ScrollView {
86​ Component.onCompleted: background.visible = true
87​ Layout.preferredWidth: 300
88​ Layout.fillHeight:true
broulikUnsubmitted
Not Done

Kirigami.Units.gridUnit and/or maybe proportional to the window width?

broulik: `Kirigami.Units.gridUnit` and/or maybe proportional to the window width?
89​ ListView {
90​ id: components
91​ clip: true
92​ model: kcm.filteredModel
93​ delegate: Kirigami.AbstractListItem {
94​ readonly property color foregroundColor: ListView.isCurrentItem ? activeTextColor : textColor
95​ RowLayout {
broulikUnsubmitted
Done

Is contentItem the default property?

broulik: Is `contentItem` the default property?
davidreAuthorUnsubmitted
Done

Yes

davidre: Yes
96​ Kirigami.Icon {
97​ source: model.decoration
98​ Layout.preferredWidth: Kirigami.Units.iconSizes.small
99​ Layout.preferredHeight: Layout.preferredWidth
100​ color: foregroundColor
101​ }
102​ QQC2.Label {
103​ Layout.fillWidth: true
broulikUnsubmitted
Done

Make sure to replicate the color behavior on hover and when selected, right now text stays black with the blue selection background behind it

broulik: Make sure to replicate the color behavior on hover and when selected, right now text stays…
104​ text: model.display
105​ color: foregroundColor
106​ }
107​ QQC2.CheckBox {
108​ id: checkbox
109​ checked: model.checked
110​ visible: exportActive
111​ onToggled: model.checked = checked
112​ }
113​ }
114​ }
115​ section.property: "section"
broulikUnsubmitted
Done

Perhaps you could put a checkbox here so one check all items in a section

broulik: Perhaps you could put a checkbox here so one check all items in a section
116​ section.delegate: Kirigami.ListSectionHeader {
117​ label: section
118​ }
119​ }
ngrahamUnsubmitted
Done

When I click on it, the KCM enters this state:

ngraham: When I click on it, the KCM enters this state: {F8249469}
120​ }
121​ QQC2.ScrollView {
ngrahamUnsubmitted
Done

How about "Remove all shortcuts for [model.name]"

ngraham: How about "Remove all shortcuts for [model.name]"
122​ property var rootIndex : kcm.filteredModel.index(components.currentIndex, 0)
123​ enabled: !exportActive
124​ id: shortcutsScroll
125​ Layout.fillHeight: true
126​ Layout.fillWidth: true
127​ Component.onCompleted: background.visible = true
ngrahamUnsubmitted
Done

Need to do one of the following:

  • Make this view never empty because something in the left view is always selected
  • Add a standard-looking placeholder message that appears in the center of this view when nothing is selected that says something like "Select an item from the list to view its shortcuts here"
ngraham: Need to do one of the following: - Make this view never empty because something in the left…
128​ onRootIndexChanged: shortcutsList.currentIndex = -1
129​ ListView {
130​ clip:true
131​ id: shortcutsList
132​ model: DelegateModel {
133​ id: dm
134​ rootIndex: shortcutsScroll.rootIndex
135​ model: rootIndex.valid ? kcm.filteredModel : undefined
136​ delegate: ShortcutActionDelegate {}
137​ }
138​ }
139​ }
140​ RowLayout {
141​ Layout.alignment: Qt.AlignRight
142​ enabled: !exportActive
broulikUnsubmitted
Done

Capitalize: "Add Application..."

How do I remove applications again, though?

broulik: Capitalize: "Add Application..." How do I remove applications again, though?
davidreAuthorUnsubmitted
Done

I know...
I will look into what's the most reliable way of deleting things...

davidre: I know... I will look into what's the most reliable way of deleting things...
143​ QQC2.Button {
144​ icon.name: "list-add"
145​ text: i18n("Add Application...")
146​ onClicked: {
147​ kcm.addApplication(this)
148​ }
149​ }
150​ }
151​ RowLayout {
152​ Layout.alignment: Qt.AlignRight
153​ QQC2.Button {
154​ enabled: !exportActive
155​ icon.name: "document-import"
156​ text: i18n("Import Scheme...")
157​ onClicked: importSheet.open()
158​ }
broulikUnsubmitted
Done

I kinda think this button should turn into a "Cancel Export" button when exporting? Not sure that closing the message widget is obvious enough to the user?

broulik: I kinda think this button should turn into a "Cancel Export" button when exporting? Not sure…
159​ QQC2.Button {
160​ icon.name: exportActive ? "dialog-cancel" : "document-export"
161​ text: exportActive ? i18n("Cancel Export") : i18n("Export Scheme...")
broulikUnsubmitted
Done

You're doing a Connections above already.

broulik: You're doing a `Connections` above already.
162​ onClicked: {
163​ if (exportActive) {
164​ exportActive = false
broulikUnsubmitted
Done

This should just be bound to the search.text and work automatically

broulik: This should just be bound to the `search.text` and work automatically
165​ } else if (kcm.needsSave) {
broulikUnsubmitted
Done

You seem to love being overly explicit with this? :P You have a binding above already...

Perhaps run the application with QT_LOGGING_RULES="qt.qml.binding.removal.info=true" to clean those up

broulik: You seem to love being overly explicit with this? :P You have a binding above already...
166​ exportWarning.visible = true
167​ } else {
168​ search.text = ""
ngrahamUnsubmitted
Done

Make it a level 3 Heading

ngraham: Make it a level 3 `Heading`
169​ exportActive = true
170​ }
171​ }
172​ }
173​ }
174​ }
ngrahamUnsubmitted
Done

For some reason this list view doesn't get any sctollbars when it's scrollable. Also it implements kinetic scrolling while the other list view doesn't

ngraham: For some reason this list view doesn't get any sctollbars when it's scrollable. Also it…
175​ }
176​ Loader {
177​ id: fileDialogLoader
178​ active: false
179​ property bool save
180​ sourceComponent: FileDialog {
181​ id: fileDialog
182​ title: save ? i18n("Export Shortcut Scheme") : i18n("Import Shortcut Scheme")
183​ folder: shortcuts.home
184​ nameFilters: [ i18nc("Template for file dialog","Schortcut Scheme (*.kksrc)") ]
185​ defaultSuffix: ".kksrc"
186​ selectExisting: !fileDialogLoader.save
187​ Component.onCompleted: open()
188​ onAccepted: {
189​ save ? kcm.writeScheme(fileUrls[0]) : kcm.loadScheme(fileUrls[0])
190​ fileDialogLoader.active = false
191​ }
192​ onRejected: fileDialogLoader.active = false
193​ }
194​ }
195​ Kirigami.OverlaySheet {
196​ id: importSheet
197​ header: Kirigami.Heading {
198​ text: i18n("Import Shortcut Scheme")
199​ }
200​
201​ ColumnLayout {
202​ anchors.centerIn: parent
203​ QQC2.Label {
204​ text: i18n("Select the scheme to import:")
205​ }
206​ RowLayout {
207​ QQC2.ComboBox {
208​ id: schemeBox
209​ readonly property bool customSchemeSelected: currentIndex == count - 1
210​ property string url: ""
211​ currentIndex: count - 1
212​ textRole: "name"
213​ onActivated: url = model[index]["url"]
214​ Component.onCompleted: {
215​ var defaultSchemes = kcm.defaultSchemes()
216​ defaultSchemes.push({name: i18n("Custom Scheme"), url: "unused"})
217​ model = defaultSchemes
218​ }
219​ }
220​ QQC2.Button {
221​ text: schemeBox.customSchemeSelected ? i18n("Select File...") : i18n("Import")
222​ onClicked: {
223​ if (schemeBox.customSchemeSelected) {
224​ fileDialogLoader.save = false;
225​ fileDialogLoader.active = true;
broulikUnsubmitted
Done

Found it a bit odd that the overlaysheet suddenly closed as a result.
I would have expected clicking "Select File", choosing one, and then it being added to and selected in the combox list and then confirming this by clicking "Import"

broulik: Found it a bit odd that the overlaysheet suddenly closed as a result. I would have expected…
226​ } else {
227​ kcm.loadScheme(schemeBox.defaultSchemes[schemeBox.url])
228​ }
229​ importSheet.close()
230​ }
231​ }
232​ }
233​ }
234​ }
235​}
236​