Differential D28560 Diff 79760 resources/google-groupware/googleresource.h

Changeset View

Standalone View

View Options

resources/google-groupware/googleresource.h

  • This file was added.
1​/*
2​ Copyright (C) 2011-2013 Daniel Vrátil <dvratil@redhat.com>
3​
4​ This program is free software: you can redistribute it and/or modify
5​ it under the terms of the GNU General Public License as published by
6​ the Free Software Foundation, either version 3 of the License, or
7​ (at your option) any later version.
8​
9​ This program is distributed in the hope that it will be useful,
10​ but WITHOUT ANY WARRANTY; without even the implied warranty of
11​ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12​ GNU General Public License for more details.
13​
14​ You should have received a copy of the GNU General Public License
15​ along with this program. If not, see <https://www.gnu.org/licenses/>.
16​*/
17​
18​#ifndef GOOGLERESOURCE_H
19​#define GOOGLERESOURCE_H
20​
21​#include <AkonadiAgentBase/ResourceBase>
22​#include <AkonadiAgentBase/AgentBase>
23​#include <Akonadi/Calendar/FreeBusyProviderBase>
24​
25​#include <qwindowdefs.h>
26​
27​#include "calendarhandler.h"
28​#include "generichandler.h"
29​
30​#include <KLocalizedString>
31​
32​#define JOB_PROPERTY "_KGAPI2Job"
33​
34​namespace KGAPI2 {
35​class Job;
36​}
37​
38​class GoogleSettings;
39​class GoogleResourceState;
40​
41​class GoogleResource : public Akonadi::ResourceBase, public Akonadi::AgentBase::ObserverV3, public Akonadi::FreeBusyProviderBase
42​{
43​ Q_OBJECT
44​
45​public:
46​ explicit GoogleResource(const QString &id);
47​ ~GoogleResource() override;
48​
49​ QList<QUrl> scopes() const;
50​
51​ void cleanup() override;
52​public Q_SLOTS:
53​ void configure(WId windowId) override;
54​ void reloadConfig();
55​protected:
56​ int runConfigurationDialog(WId windowId);
57​ void updateResourceName();
58​ // Freebusy
59​ QDateTime lastCacheUpdate() const override;
60​ void canHandleFreeBusy(const QString &email) const override;
61​ void retrieveFreeBusy(const QString &email, const QDateTime &start, const QDateTime &end) override;
62​
63​ bool canPerformTask();
64​ /**
65​ * KAccounts support abstraction.
66​ *
67​ * Returns 0 when compiled without KAccounts or not configured for KAccounts
68​ */
69​ int accountId() const;
70​
71​ void emitReadyStatus();
72​ void collectionsRetrievedFromHandler(const Akonadi::Collection::List &collections);
73​protected Q_SLOTS:
74​ void retrieveCollections() override;
75​ void retrieveItems(const Akonadi::Collection &collection) override;
76​
77​ void itemAdded(const Akonadi::Item &item, const Akonadi::Collection &collection) override;
78​ void itemChanged(const Akonadi::Item &item, const QSet< QByteArray > &partIdentifiers) override;
79​ void itemsRemoved(const Akonadi::Item::List &items) override;
80​ void itemsMoved(const Akonadi::Item::List &items, const Akonadi::Collection &collectionSource, const Akonadi::Collection &collectionDestination) override;
81​ void itemsLinked(const Akonadi::Item::List &items, const Akonadi::Collection &collection) override;
82​ void itemsUnlinked(const Akonadi::Item::List &items, const Akonadi::Collection &collection) override;
83​
84​ void collectionAdded(const Akonadi::Collection &collection, const Akonadi::Collection &parent) override;
85​ void collectionChanged(const Akonadi::Collection &collection) override;
86​ void collectionRemoved(const Akonadi::Collection &collection) override;
87​
88​ bool handleError(KGAPI2::Job *job, bool cancelTask = true);
89​
90​ void slotAuthJobFinished(KGAPI2::Job *job);
91​private:
92​ bool m_isConfiguring = false;
93​ GoogleSettings *m_settings = nullptr;
94​ Akonadi::Collection m_rootCollection;
95​
96​ GoogleResourceState *m_iface;
97​
98​ std::vector<GenericHandler::Ptr> m_handlers;
99​ FreeBusyHandler::Ptr m_freeBusyHandler;
100​ int m_jobs;
101​
102​ friend class GoogleSettingsDialog;
103​ friend class GoogleResourceState;
104​
105​ GenericHandler *fetchHandlerByMimetype(const QString &mimeType);
106​ GenericHandler *fetchHandlerForCollection(const Akonadi::Collection &collection);
107​};
108​
109​#endif // GOOGLERESOURCE_H
dvratilUnsubmitted
Done

IMO this should be a std::vector<std::unique_ptr<GenericHandler>> - in other words, it should be an "owning" list. When the list is destroyed, all handlers are destroyed.

dvratil: IMO this should be a `std::vector<std::unique_ptr<GenericHandler>>` - in other words, it should…
dvratilUnsubmitted
Done

I'd propose to make a dedicated FreeBusyHandler that is /not/ subclasses from GenericHandler and implement the corresponding functionality there., rather than having two CalendarHandlers. Or just drop the m_freeBusyHandler completely and use the CalendarHandler from m_handlers directly (look it up by the mimetype).

dvratil: I'd propose to make a dedicated `FreeBusyHandler` that is /not/ subclasses from…