Differential D28560 Diff 79580 resources/google-groupware/googleresource.h

Changeset View

Standalone View

View Options

resources/google-groupware/googleresource.h

  • This file was added.
1​/*
2​ Copyright (C) 2011-2013 Daniel Vrátil <dvratil@redhat.com>
3​
4​ This program is free software: you can redistribute it and/or modify
5​ it under the terms of the GNU General Public License as published by
6​ the Free Software Foundation, either version 3 of the License, or
7​ (at your option) any later version.
8​
9​ This program is distributed in the hope that it will be useful,
10​ but WITHOUT ANY WARRANTY; without even the implied warranty of
11​ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12​ GNU General Public License for more details.
13​
14​ You should have received a copy of the GNU General Public License
15​ along with this program. If not, see <https://www.gnu.org/licenses/>.
16​*/
17​
18​#ifndef GOOGLERESOURCE_H
19​#define GOOGLERESOURCE_H
20​
21​#include <AkonadiAgentBase/ResourceBase>
22​#include <AkonadiAgentBase/AgentBase>
23​#include <Akonadi/Calendar/FreeBusyProviderBase>
24​
25​#include <qwindowdefs.h>
26​
27​#include "googlesettings.h"
28​#include "generichandler.h"
29​#include "calendarhandler.h"
30​
31​#include <KGAPI/Types>
32​
33​#include <KLocalizedString>
34​
35​#define ITEM_PROPERTY "_AkonadiItem"
36​#define ITEMS_PROPERTY "_AkonadiItems"
37​#define COLLECTION_PROPERTY "_AkonadiCollection"
38​#define JOB_PROPERTY "_KGAPI2Job"
39​
40​namespace KGAPI2 {
41​class Job;
42​}
43​
44​class GoogleSettings;
45​
46​class GoogleResource : public Akonadi::ResourceBase, public Akonadi::AgentBase::ObserverV3, public Akonadi::FreeBusyProviderBase
47​{
48​ Q_OBJECT
49​
50​public:
51​ explicit GoogleResource(const QString &id);
52​ ~GoogleResource() override;
53​
54​ QList<QUrl> scopes() const;
55​
56​ void cleanup() override;
57​public Q_SLOTS:
58​ void configure(WId windowId) override;
59​ void reloadConfig();
60​protected:
61​ int runConfigurationDialog(WId windowId);
62​ void updateResourceName();
63​ // Freebusy
64​ QDateTime lastCacheUpdate() const override;
65​ void canHandleFreeBusy(const QString &email) const override;
66​ void retrieveFreeBusy(const QString &email, const QDateTime &start, const QDateTime &end) override;
67​
68​ template<typename T>
69​ bool canPerformTask(const Akonadi::Item &item, const QString &mimeType = QString())
70​ {
71​ if (item.isValid() && !item.hasPayload<T>()) {
72​ cancelTask(i18n("Invalid item payload."));
73​ return false;
74​ } else if (item.isValid() && mimeType != item.mimeType()) {
75​ cancelTask(i18n("Invalid payload MIME type. Expected %1, found %2", mimeType, item.mimeType()));
76​ return false;
77​ }
78​
79​ return canPerformTask();
80​ }
81​
82​ bool canPerformTask();
83​ /**
84​ * KAccounts support abstraction.
85​ *
86​ * Returns 0 when compiled without KAccounts or not configured for KAccounts
87​ */
88​ int accountId() const;
89​
90​ Akonadi::Collection rootCollection() const;
91​ void emitReadyStatus();
92​ void collectionsRetrievedFromHandler(const Akonadi::Collection::List &collections);
93​protected Q_SLOTS:
94​ void retrieveCollections() override;
95​ void retrieveItems(const Akonadi::Collection &collection) override;
96​
97​ void itemAdded(const Akonadi::Item &item, const Akonadi::Collection &collection) override;
98​ void itemChanged(const Akonadi::Item &item, const QSet< QByteArray > &partIdentifiers) override;
99​ void itemsRemoved(const Akonadi::Item::List &items) override;
100​ void itemsMoved(const Akonadi::Item::List &items, const Akonadi::Collection &collectionSource, const Akonadi::Collection &collectionDestination) override;
101​ void itemsLinked(const Akonadi::Item::List &items, const Akonadi::Collection &collection) override;
102​ void itemsUnlinked(const Akonadi::Item::List &items, const Akonadi::Collection &collection) override;
103​
104​ void collectionAdded(const Akonadi::Collection &collection, const Akonadi::Collection &parent) override;
105​ void collectionChanged(const Akonadi::Collection &collection) override;
106​ void collectionRemoved(const Akonadi::Collection &collection) override;
107​
108​ bool handleError(KGAPI2::Job *job, bool cancelTask = true);
109​
110​ virtual void slotAuthJobFinished(KGAPI2::Job *job);
111​ virtual void slotGenericJobFinished(KGAPI2::Job *job);
112​private:
113​ bool m_isConfiguring = false;
114​ GoogleSettings *m_settings = nullptr;
115​ Akonadi::Collection m_rootCollection;
116​
117​ QList<GenericHandler::Ptr> m_handlers;
dvratilUnsubmitted
Done

IMO this should be a std::vector<std::unique_ptr<GenericHandler>> - in other words, it should be an "owning" list. When the list is destroyed, all handlers are destroyed.

dvratil: IMO this should be a `std::vector<std::unique_ptr<GenericHandler>>` - in other words, it should…
118​ CalendarHandler::Ptr m_freeBusyHandler;
dvratilUnsubmitted
Done

I'd propose to make a dedicated FreeBusyHandler that is /not/ subclasses from GenericHandler and implement the corresponding functionality there., rather than having two CalendarHandlers. Or just drop the m_freeBusyHandler completely and use the CalendarHandler from m_handlers directly (look it up by the mimetype).

dvratil: I'd propose to make a dedicated `FreeBusyHandler` that is /not/ subclasses from…
119​ int m_jobs;
120​
121​ friend class GoogleSettingsDialog;
122​ friend class GenericHandler;
123​ friend class CalendarHandler;
124​ friend class ContactHandler;
125​ friend class TaskHandler;
126​};
127​
128​#endif // GOOGLERESOURCE_H