Differential D28210 Diff 78261 src/core/model/accountschannelsmodel.cpp

Changeset View

Standalone View

View Options

src/core/model/accountschannelsmodel.cpp

  • This file was added.
1​/*
2​ Copyright (c) 2020 Olivier de Gaalon <olivier.jg@gmail.com>
3​
4​ This library is free software; you can redistribute it and/or modify
5​ it under the terms of the GNU Library General Public License as published
6​ by the Free Software Foundation; either version 2 of the License or
7​ ( at your option ) version 3 or, at the discretion of KDE e.V.
8​ ( which shall act as a proxy as in section 14 of the GPLv3 ), any later version.
9​
10​ This library is distributed in the hope that it will be useful,
11​ but WITHOUT ANY WARRANTY; without even the implied warranty of
12​ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
13​ Library General Public License for more details.
14​
15​ You should have received a copy of the GNU Library General Public License
16​ along with this library; see the file COPYING.LIB. If not, write to
17​ the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
18​ Boston, MA 02110-1301, USA.
19​*/
20​
21​#include "accountschannelsmodel.h"
22​
23​#include "accountmanager.h"
24​#include "ruqola.h"
25​#include "rocketchataccount.h"
26​#include "roomfilterproxymodel.h"
27​#include "rocketchataccountmodel.h"
28​#include "rocketchataccountfilterproxymodel.h"
29​
30​AccountsChannelsModel::AccountsChannelsModel(QObject *parent)
31​ : QAbstractItemModel(parent)
32​{
33​ const auto src = Ruqola::self()->accountManager()->rocketChatAccountModel();
34​ const auto acctsProxy = Ruqola::self()->accountManager()->rocketChatAccountProxyModel();
35​
36​ auto roomsModel = [src, acctsProxy](int i) {
37​ const auto acctIndex = acctsProxy->mapToSource(acctsProxy->index(i, 0)).row();
38​ return src->account(acctIndex)->roomFilterProxyModel();
39​ };
40​
41​ auto proxyRooms = [roomsModel, acctsProxy, this](int i) {
dfaureUnsubmitted
Done

i is a row number in the accounts proxy model, right?

It gets a bit confusing with the i on line 44... Maybe this one could be rowNumber or proxyRow...
(of course they could both be, but the point is to use a different name, otherwise it looks like we're comparing roomsModel(i) with roomsModel(i)...)

dfaure: `i` is a row number in the accounts proxy model, right? It gets a bit confusing with the `i`…
42​ auto rooms = roomsModel(i);
43​ proxyModel(rooms, [roomsModel, acctsProxy, rooms, this]{
dfaureUnsubmitted
Done

I was confused when reading this because proxyModel() looks like a getter for a proxyModel.
Now I realize this is "proxy" as a verb, as in "please proxy this model".
But in fact the proxy *is* the first argument, it's not like the method is going to create it...

So I suggest setupRoomsModel or setupProxyModel or something like that.

dfaure: I was confused when reading this because proxyModel() looks like a getter for a proxyModel. Now…
44​ for (int i = 0, count = acctsProxy->rowCount(); i < count; ++i)
45​ if (roomsModel(i) == rooms)
46​ return index(i, 0);
47​ return QModelIndex();
48​ });
49​ };
50​
51​ connect(acctsProxy, &QAbstractItemModel::rowsInserted, this,
52​ [proxyRooms](const QModelIndex &, int first, int last) {
53​ for (int i = first; i <= last; ++i)
54​ proxyRooms(i);
55​ });
56​
57​ connect(acctsProxy, &QAbstractItemModel::rowsAboutToBeRemoved, this,
58​ [roomsModel, this](const QModelIndex &, int first, int last) {
59​ for (int i = first; i <= last; ++i)
60​ unproxyModel(roomsModel(i));
61​ });
62​
63​ connect(acctsProxy, &QAbstractItemModel::modelReset, this,
64​ [proxyRooms, acctsProxy, this]() {
65​ while (!mProxied.isEmpty())
66​ unproxyModel(mProxied.begin()->model);
67​ for (int i = 0, count = acctsProxy->rowCount(); i < count; ++i)
68​ proxyRooms(i);
69​ });
70​
71​
72​ proxyModel(acctsProxy, []{ return QModelIndex(); });
73​ for (int i = 0, count = acctsProxy->rowCount(); i < count; ++i)
74​ proxyRooms(i);
75​}
76​
77​QModelIndex AccountsChannelsModel::index(int row, int column, const QModelIndex &parent) const
78​{
79​ if (auto model = rootModel(parent))
80​ return createIndex(row, column, model);
81​ return {};
82​}
83​
84​QModelIndex AccountsChannelsModel::parent(const QModelIndex &child) const
85​{
86​ if (!child.isValid())
87​ return {};
88​
89​ if (auto model = static_cast<QAbstractItemModel*>(child.internalPointer()))
90​ return modelRoot(model);
91​
92​ return {};
93​}
94​
95​int AccountsChannelsModel::rowCount(const QModelIndex &parent) const
96​{
97​ if (auto model = rootModel(parent))
98​ return model->rowCount();
99​ return 0;
100​}
101​
102​int AccountsChannelsModel::columnCount(const QModelIndex &) const
103​{
104​ return 1;
105​}
106​
107​QVariant AccountsChannelsModel::data(const QModelIndex &index, int role) const
108​{
109​ if (!index.isValid())
110​ return {};
111​
112​ const auto model = static_cast<QAbstractItemModel*>(index.internalPointer());
113​ if (!model)
114​ return {};
115​
116​ return model->index(index.row(), index.column()).data(role);
117​}
118​
119​QModelIndex AccountsChannelsModel::modelRoot(QAbstractItemModel *model) const
120​{
121​ const auto find = [model](const ProxyIndex &i){ return i.model == model; };
122​ const auto it = std::find_if(mProxied.begin(), mProxied.end(), find);
123​ return (it == mProxied.end()) ? QModelIndex() : it->root();
124​}
125​
126​QAbstractItemModel *AccountsChannelsModel::rootModel(const QModelIndex &root) const
127​{
128​ const auto find = [&root](const ProxyIndex &i){ return i.root() == root; };
129​ const auto it = std::find_if(mProxied.begin(), mProxied.end(), find);
130​ return (it == mProxied.end()) ? nullptr : it->model;
131​}
132​
133​void AccountsChannelsModel::proxyModel(QAbstractItemModel *model, const std::function<QModelIndex()> &root)
134​{
135​ connect(model, &QAbstractItemModel::rowsAboutToBeInserted, this,
136​ [this, model](const QModelIndex &parent, int first, int last) {
137​ Q_ASSERT(!parent.isValid());
138​ beginInsertRows(modelRoot(model), first, last);
139​ });
140​ connect(model, &QAbstractItemModel::rowsInserted, this, &AccountsChannelsModel::endInsertRows);
141​
142​ connect(model, &QAbstractItemModel::rowsAboutToBeRemoved, this,
143​ [this, model](const QModelIndex &parent, int first, int last) {
144​ Q_ASSERT(!parent.isValid());
145​ beginRemoveRows(modelRoot(model), first, last);
146​ });
147​ connect(model, &QAbstractItemModel::rowsRemoved, this, &AccountsChannelsModel::endRemoveRows);
148​
149​ connect(model, &QAbstractItemModel::rowsAboutToBeMoved, this,
150​ [this, model](const QModelIndex &src, int sf, int sl, const QModelIndex &dst, int df) {
151​ Q_ASSERT(!src.isValid() && !dst.isValid());
152​ const auto idx = modelRoot(model);
153​ beginMoveRows(idx, sf, sl, idx, df);
154​ });
155​ connect(model, &QAbstractItemModel::rowsMoved, this, &AccountsChannelsModel::endMoveRows);
156​
157​ connect(model, &QAbstractItemModel::modelAboutToBeReset, this, &AccountsChannelsModel::beginResetModel);
158​ connect(model, &QAbstractItemModel::modelReset, this, &AccountsChannelsModel::endResetModel);
159​
160​ connect(model, &QAbstractItemModel::layoutAboutToBeChanged, this, &AccountsChannelsModel::layoutAboutToBeChanged);
161​ connect(model, &QAbstractItemModel::layoutChanged, this, &AccountsChannelsModel::layoutChanged);
162​
163​ connect(model, &QAbstractItemModel::dataChanged, this,
164​ [this, model](const QModelIndex &tl, const QModelIndex &br) {
165​ const auto parent = modelRoot(model);
166​ emit dataChanged(index(tl.row(), tl.column(), parent), index(br.row(), br.column(), parent));
167​ });
168​
169​ mProxied.append({model, root});
170​}
171​
172​void AccountsChannelsModel::unproxyModel(QAbstractItemModel *model)
173​{
174​ const auto find = [model](const ProxyIndex &i){ return i.model == model; };
175​ const auto it = std::find_if(mProxied.begin(), mProxied.end(), find);
176​ if (it != mProxied.end())
177​ {
178​ model->disconnect(this);
179​ mProxied.erase(it);
180​ }
181​}