Differential D27166 Diff 78098 runners/converter/autotests/converterrunnertest.cpp

Changeset View

Standalone View

View Options

runners/converter/autotests/converterrunnertest.cpp

  • This file was added.
1​/*
2​ * Copyright (C) 2020 Alexander Lohnau <alexander.lohnau@gmx.de>
3​ *
4​ * This library is free software; you can redistribute it and/or
5​ * modify it under the terms of the GNU Lesser General Public
6​ * License as published by the Free Software Foundation; either
7​ * version 2.1 of the License, or (at your option) version 3, or any
8​ * later version accepted by the membership of KDE e.V. (or its
9​ * successor approved by the membership of KDE e.V.), which shall
10​ * act as a proxy defined in Section 6 of version 3 of the license.
11​ *
12​ * This library is distributed in the hope that it will be useful,
13​ * but WITHOUT ANY WARRANTY; without even the implied warranty of
14​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
15​ * Lesser General Public License for more details.
16​ *
17​ * You should have received a copy of the GNU Lesser General Public
18​ * License along with this library. If not, see <http://www.gnu.org/licenses/>.
19​ */
20​
21​#include <QTest>
22​
23​#include "../converterrunner.h"
24​
25​using namespace KUnitConversion;
26​
27​class ConverterRunnerTest : public QObject
28​{
29​Q_OBJECT
30​private Q_SLOTS:
31​ void initTestCase();
32​
33​ void testMostCommonUnits();
34​ void testSpecificTargetUnit();
35​ void testUnitsCaseInsensitive();
36​ void testCaseSensitiveUnits();
37​ void testCurrency();
38​ void testLettersAndCurrency();
39​ void testInvalidCurrency();
40​ void testFractions();
41​ void testInvalidFractions();
42​ void testSymbolsInUnits();
43​
sitterUnsubmitted
Done

= nullptr

In fact, you could make this a std::unique_ptr because currently it is also not getting deleted, not that it matters for a test ^^

sitter: `= nullptr` In fact, you could make this a std::unique_ptr because currently it is also not…
44​private:
45​ ConverterRunner *runner = nullptr;
46​};
47​
48​void ConverterRunnerTest::initTestCase()
49​{
50​ setlocale(LC_ALL, "C.utf8");
broulikUnsubmitted
Done

This doesn't affect translations. I guess you also want to add a

qputenv("LANG", "en_US")
broulik: This doesn't affect translations. I guess you also want to add a ``` qputenv("LANG", "en_US")…
51​ runner = new ConverterRunner(this, QVariantList());
52​ runner->init();
53​}
54​
55​/**
56​ * Test if the most common units are displayed
57​ */
58​void ConverterRunnerTest::testMostCommonUnits()
59​{
60​ Plasma::RunnerContext context;
61​ context.setQuery(QStringLiteral("1m"));
62​ runner->match(context);
63​
64​ Converter converter;
65​ const auto lengthCategory = converter.category(KUnitConversion::LengthCategory);
66​ QCOMPARE(context.matches().count(), lengthCategory.mostCommonUnits().count() -1);
67​}
68​
69​/*
70​ * Test if specifying a target unit works
71​ */
72​void ConverterRunnerTest::testSpecificTargetUnit()
73​{
74​ Plasma::RunnerContext context;
75​ context.setQuery(QStringLiteral("1m > cm"));
76​ runner->match(context);
broulikUnsubmitted
Done

I think you should change the locale for the unittest to C or en_US (dunno how, needs someone with more test knowledge :D) since those are translated and fail when I run the test locally

broulik: I think you should change the locale for the unittest to `C` or `en_US` (dunno how, needs…
sitterUnsubmitted
Done

the servicerunnertest in plasma-workspace is actually doing that by simply calling setlocale I think. that should be good enough so long as it gets called early enough

sitter: the servicerunnertest in plasma-workspace is actually doing that by simply calling setlocale I…
77​
78​ QCOMPARE(context.matches().count(), 1);
79​ QCOMPARE(context.matches().first().text(), QStringLiteral("100 centimeters (cm)"));
80​}
81​
82​/**
83​ * Test if the units are case insensitive
84​ */
85​void ConverterRunnerTest::testUnitsCaseInsensitive()
86​{
87​ Plasma::RunnerContext context;
88​ context.setQuery(QStringLiteral("1Liter in ML"));
89​ runner->match(context);
90​
91​ QCOMPARE(context.matches().count(), 1);
92​}
93​
94​/**
95​ * Test if the units that are case sensitive are correctly parsed
96​ */
97​void ConverterRunnerTest::testCaseSensitiveUnits()
98​{
99​ Plasma::RunnerContext context;
100​ context.setQuery(QStringLiteral("1Ms as ms"));
101​ runner->match(context);
102​
103​ QCOMPARE(context.matches().count(), 1);
104​ QCOMPARE(context.matches().first().text(), QStringLiteral("1.000.000.000 milliseconds (ms)"));
105​
106​ Plasma::RunnerContext context2;
107​ context2.setQuery(QStringLiteral("1.000.000.000milliseconds>Ms"));
108​ runner->match(context2);
109​ QCOMPARE(context2.matches().count(), 1);
110​ QCOMPARE(context2.matches().first().text(), "1 megasecond (Ms)");
111​}
112​
113​/**
114​ * Test of a currency gets converted to the most common currencies
115​ */
116​void ConverterRunnerTest::testCurrency()
117​{
118​ Plasma::RunnerContext context;
119​ context.setQuery(QStringLiteral("1$"));
120​ runner->match(context);
121​
122​ Converter converter;
123​ const auto currencyCategory = converter.category(KUnitConversion::CurrencyCategory);
124​ QList<Unit> currencyUnits = currencyCategory.mostCommonUnits();
125​
126​ const QString currencyIsoCode = QLocale().currencySymbol(QLocale::CurrencyIsoCode);
127​ const KUnitConversion::Unit localCurrency = currencyCategory.unit(currencyIsoCode);
128​ if (localCurrency.isValid() && !currencyUnits.contains(localCurrency)) {
129​ currencyUnits << localCurrency;
130​ }
131​ QCOMPARE(context.matches().count(), currencyUnits.count() - 1);
132​
133​}
134​
135​/**
136​ * Test a combination of currency symbols and letters that is not directly supported by the conversion backend
137​ */
138​void ConverterRunnerTest::testLettersAndCurrency()
139​{
140​ Plasma::RunnerContext context;
141​ context.setQuery(QStringLiteral("4us$>ca$"));
142​ runner->match(context);
143​
144​ QCOMPARE(context.matches().count(), 1);
145​ QVERIFY(context.matches().first().text().contains(QLatin1String("Canadian dollars (CAD)")));
146​}
147​
148​/**
149​ * Test a query that matches the regex but is not valid
150​ */
151​void ConverterRunnerTest::testInvalidCurrency()
152​{
153​ Plasma::RunnerContext context;
154​ context.setQuery(QStringLiteral("4us$>abc$"));
155​ runner->match(context);
156​
157​ QCOMPARE(context.matches().count(), 0);
158​}
159​
160​/**
161​ * Test if the factions are correctly parsed
162​ */
163​void ConverterRunnerTest::testFractions()
164​{
165​ Plasma::RunnerContext context;
166​ context.setQuery(QStringLiteral("6/3m>cm"));
167​ runner->match(context);
168​
169​ QCOMPARE(context.matches().count(), 1);
170​ QCOMPARE(context.matches().first().text(), QStringLiteral("200 centimeters (cm)"));
171​}
172​
173​/**
174​ * Test if an invalid query with a fraction gets rejected
175​ */
176​void ConverterRunnerTest::testInvalidFractions()
177​{
178​ Plasma::RunnerContext context;
179​ context.setQuery(QStringLiteral("4/4>cm"));
180​ runner->match(context);
181​
182​ QCOMPARE(context.matches().count(), 0);
183​}
184​void ConverterRunnerTest::testSymbolsInUnits()
185​{
186​ Plasma::RunnerContext context;
187​ context.setQuery(QStringLiteral("1000 µs as year"));
188​ runner->match(context);
189​
190​ QCOMPARE(context.matches().count(), 1);
191​}
192​
193​QTEST_MAIN(ConverterRunnerTest)
194​
195​#include "converterrunnertest.moc"
sitterUnsubmitted
Done

No newline at end of file

sitter: No newline at end of file