Differential D27669 Diff 78063 kstyle/breezetoolsareamanager.h

Changeset View

Standalone View

View Options

kstyle/breezetoolsareamanager.h

  • This file was added.
1​#ifndef breezetoolsareamanager_h
2​#define breezetoolsareamanager_h
hpereiradacostaUnsubmitted
Done

Please use garding defines rather than "pragma once" for consistency with the rest of the code.

hpereiradacosta: Please use garding defines rather than "pragma once" for consistency with the rest of the code.
3​
4​#include <QObject>
5​#include <QVariantAnimation>
6​#include "breezestyle.h"
7​#include "breezehelper.h"
8​
9​namespace Breeze {
10​ struct ToolsAreaAnimation {
hpereiradacostaUnsubmitted
Done

Please remove the typedef. Not needed

hpereiradacosta: Please remove the typedef. Not needed
11​ QPointer<QVariantAnimation> foregroundColorAnimation;
12​ QPointer<QVariantAnimation> backgroundColorAnimation;
13​ bool prevActive;
14​ };
15​ class ToolsAreaManager: public QObject
16​ {
17​ Q_OBJECT
18​
19​ public:
20​ explicit ToolsAreaManager(Helper* helper, QObject *parent = nullptr);
hpereiradacostaUnsubmitted
Done

you don't need the default arguments.
and in fact passing nullptr for helper will crash the code everywhere.

hpereiradacosta: you don't need the default arguments. and in fact passing nullptr for helper will crash the…
21​ ~ToolsAreaManager();
22​ void registerWidget(QWidget *widget);
23​ void unregisterWidget(QWidget *widget);
24​ void updateAnimations();
25​
26​ QColor foreground(const QWidget *widget);
27​ QColor background(const QWidget *widget);
28​
29​ QSet<const QWidget*>* widgetsWithPaletteForToolsAreaSet();
hpereiradacostaUnsubmitted
Done

don't put members public. Members should be private, and proper accessors/modifiers should be added.

hpereiradacosta: don't put members public. Members should be private, and proper accessors/modifiers should be…
30​
31​ Q_SIGNALS:
32​ void toolbarUpdated();
33​
34​ private:
35​ void registerAnimation( QWidget *widget );
36​ QSet<QWidget*> _registeredWidgets;
37​ Helper* _helper;
38​
39​ QMap<QWindow*,ToolsAreaAnimation> animationMap;
40​ QSet<const QWidget*> m_widgetsWithPaletteForToolsAreaSet;
41​ };
hpereiradacostaUnsubmitted
Done

Should use a QSet rather than QList. It is faster on removal and contain check.
Should also use const QWidget* as a contained object to avoid unnecessary need for const_caast

hpereiradacosta: Should use a QSet rather than QList. It is faster on removal and contain check. Should also…
42​}
43​
44​#endif
45​No newline at end of file