Differential D27166 Diff 78016 runners/converter/autotests/converterrunnertest.cpp

Changeset View

Standalone View

runners/converter/autotests/converterrunnertest.cpp

This file was added.

1		/*
2		* Copyright (C) 2020 Alexander Lohnau <alexander.lohnau@gmx.de>
3		*
4		* This library is free software; you can redistribute it and/or
5		* modify it under the terms of the GNU Lesser General Public
6		* License as published by the Free Software Foundation; either
7		* version 2.1 of the License, or (at your option) version 3, or any
8		* later version accepted by the membership of KDE e.V. (or its
9		* successor approved by the membership of KDE e.V.), which shall
10		* act as a proxy defined in Section 6 of version 3 of the license.
11		*
12		* This library is distributed in the hope that it will be useful,
13		* but WITHOUT ANY WARRANTY; without even the implied warranty of
14		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
15		* Lesser General Public License for more details.
16		*
17		* You should have received a copy of the GNU Lesser General Public
18		* License along with this library. If not, see <http://www.gnu.org/licenses/>.
19		*/
20
21		#include <QTest>
22
23		#include "../converterrunner.h"
24
25		using namespace KUnitConversion;
26
27		class ConverterRunnerTest : public QObject
28		{
29		Q_OBJECT
30		private Q_SLOTS:
31		void initTestCase();
32
33		void testMostCommonUnits();
34		void testSpecificTargetUnit();
35		void testCurrency();
36		void testLettersAndCurrency();
37		void testInvalidCurrency();
38		void testFractions();
39		void testInvalidFractions();
40
41		private:
42		ConverterRunner *runner = nullptr;
43		};
	sitterUnsubmitted Done `= nullptr` In fact, you could make this a std::unique_ptr because currently it is also not getting deleted, not that it matters for a test ^^ sitter: `= nullptr` In fact, you could make this a std::unique_ptr because currently it is also not…
44
45		void ConverterRunnerTest::initTestCase()
46		{
47		runner = new ConverterRunner(this, QVariantList());
48		runner->init();
49		}
50
51		/**
	broulikUnsubmitted Done This doesn't affect translations. I guess you also want to add a qputenv("LANG", "en_US") broulik: This doesn't affect translations. I guess you also want to add a ``` qputenv("LANG", "en_US")…
52		* Test if the most common units are displayed
53		*/
54		void ConverterRunnerTest::testMostCommonUnits()
55		{
56		Plasma::RunnerContext context;
57		context.setQuery(QStringLiteral("1m"));
58		runner->match(context);
59
60		Converter converter;
61		const auto lengthCategory = converter.category(KUnitConversion::LengthCategory);
62		QCOMPARE(context.matches().count(), lengthCategory.mostCommonUnits().count() -1);
63		}
64
65		/*
66		* Test if specifying a target unit works
67		*/
68		void ConverterRunnerTest::testSpecificTargetUnit()
69		{
70		Plasma::RunnerContext context;
71		context.setQuery(QStringLiteral("1m > cm"));
72		runner->match(context);
73
74		QCOMPARE(context.matches().count(), 1);
75		QCOMPARE(context.matches().first().text(), QStringLiteral("100 centimeters (cm)"));
76		}
	broulikUnsubmitted Done I think you should change the locale for the unittest to `C` or `en_US` (dunno how, needs someone with more test knowledge :D) since those are translated and fail when I run the test locally broulik: I think you should change the locale for the unittest to `C` or `en_US` (dunno how, needs…
	sitterUnsubmitted Done the servicerunnertest in plasma-workspace is actually doing that by simply calling setlocale I think. that should be good enough so long as it gets called early enough sitter: the servicerunnertest in plasma-workspace is actually doing that by simply calling setlocale I…
77
78		/**
79		* Test of a currency gets converted to the most common currencies
80		*/
81		void ConverterRunnerTest::testCurrency()
82		{
83		Plasma::RunnerContext context;
84		context.setQuery(QStringLiteral("1$"));
85		runner->match(context);
86
87		Converter converter;
88		const auto currencyCategory = converter.category(KUnitConversion::CurrencyCategory);
89		QList<Unit> currencyUnits = currencyCategory.mostCommonUnits();
90
91		const QString currencyIsoCode = QLocale().currencySymbol(QLocale::CurrencyIsoCode);
92		const KUnitConversion::Unit localCurrency = currencyCategory.unit(currencyIsoCode);
93		if (localCurrency.isValid() && !currencyUnits.contains(localCurrency)) {
94		currencyUnits << localCurrency;
95		}
96		QCOMPARE(context.matches().count(), currencyUnits.count() - 1);
97
98		}
99
100		/**
101		* Test a combination of currency symbols and letters that is not directly supported by the conversion backend
102		*/
103		void ConverterRunnerTest::testLettersAndCurrency()
104		{
105		Plasma::RunnerContext context;
106		context.setQuery(QStringLiteral("4us$>ca$"));
107		runner->match(context);
108
109		QCOMPARE(context.matches().count(), 1);
110		QVERIFY(context.matches().first().text().contains(QLatin1String("Canadian dollars (CAD)")));
111		}
112
113		/**
114		* Test a query that matches the regex but is not valid
115		*/
116		void ConverterRunnerTest::testInvalidCurrency()
117		{
118		Plasma::RunnerContext context;
119		context.setQuery(QStringLiteral("4us$>abc$"));
120		runner->match(context);
121
122		QCOMPARE(context.matches().count(), 0);
123		}
124
125		/**
126		* Test if the factions are correctly parsed
127		*/
128		void ConverterRunnerTest::testFractions()
129		{
130		Plasma::RunnerContext context;
131		context.setQuery(QStringLiteral("6/3m>cm"));
132		runner->match(context);
133
134		QCOMPARE(context.matches().count(), 1);
135		QCOMPARE(context.matches().first().text(), QStringLiteral("200 centimeters (cm)"));
136		}
137
138		/**
139		* Test if an invalid query with a fraction gets rejected
140		*/
141		void ConverterRunnerTest::testInvalidFractions()
142		{
143		Plasma::RunnerContext context;
144		context.setQuery(QStringLiteral("4/4>cm"));
145		runner->match(context);
146
147		QCOMPARE(context.matches().count(), 0);
148		}
149
150		QTEST_MAIN(ConverterRunnerTest)
151
152		#include "converterrunnertest.moc"
	sitterUnsubmitted Done No newline at end of file sitter: No newline at end of file