Differential D27784 Diff 77996 kcmkwin/kwintabbox/kwintabboxconfigform.h

Changeset View

Standalone View

View Options

kcmkwin/kwintabbox/kwintabboxconfigform.h

  • This file was added.
1​/********************************************************************
2​ KWin - the KDE window manager
3​ This file is part of the KDE project.
4​
5​Copyright (C) 2009 Martin Gräßlin <mgraesslin@kde.org>
6​Copyright (C) 2020 Cyril Rossi <cyril.rossi@enioka.com>
7​
8​This program is free software; you can redistribute it and/or modify
9​it under the terms of the GNU General Public License as published by
10​the Free Software Foundation; either version 2 of the License, or
11​(at your option) any later version.
12​
13​This program is distributed in the hope that it will be useful,
14​but WITHOUT ANY WARRANTY; without even the implied warranty of
15​MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16​GNU General Public License for more details.
17​
18​You should have received a copy of the GNU General Public License
19​along with this program. If not, see <http://www.gnu.org/licenses/>.
20​*********************************************************************/
21​
22​#ifndef __KWINTABBOXCONFIGFORM_H__
23​#define __KWINTABBOXCONFIGFORM_H__
24​
25​#include <QWidget>
26​#include <QStandardItemModel>
27​
28​#include "tabboxconfig.h"
29​
30​class KShortcutsEditor;
31​class KActionCollection;
32​
33​namespace Ui
34​{
ervinUnsubmitted
Done

Since it's quite some changed lines already, maybe it'd be a good opportunity to move from inheritance to delegation for the Ui::KWinTabBoxConfigForm (ui pointer and all that, it's a better pattern and leads to better incremental compilation).

ervin: Since it's quite some changed lines already, maybe it'd be a good opportunity to move from…
35​class KWinTabBoxConfigForm;
36​}
37​
38​namespace KWin
39​{
40​
41​class KWinTabBoxConfigForm : public QWidget
42​{
43​ Q_OBJECT
44​
45​public:
ervinUnsubmitted
Done

= nullptr missing for the parent parameter

ervin: `= nullptr` missing for the parent parameter
46​ enum class TabboxType
47​ {
48​ Main,
49​ Alternative,
50​ };
51​
52​
53​ enum EffectComboRole
54​ {
55​ LayoutPath = Qt::UserRole + 1,
56​ AddonEffect, // i.e not builtin effects
zzagUnsubmitted
Done

Q_SIGNALS:

zzag: Q_SIGNALS:
57​ };
58​
59​ explicit KWinTabBoxConfigForm(TabboxType type, QWidget *parent = nullptr);
60​ ~KWinTabBoxConfigForm() override;
61​
62​ bool highlightWindows() const;
63​ bool showTabBox() const;
64​ int filterScreen() const;
65​ int filterDesktop() const;
66​ int filterActivities() const;
67​ int filterMinimization() const;
68​ int applicationMode() const;
69​ int showDesktopMode() const;
70​ int switchingMode() const;
71​ QString layoutName() const;
72​
73​ void setFilterScreen(TabBox::TabBoxConfig::ClientMultiScreenMode mode);
74​ void setFilterDesktop(TabBox::TabBoxConfig::ClientDesktopMode mode);
75​ void setFilterActivities(TabBox::TabBoxConfig::ClientActivitiesMode mode);
76​ void setFilterMinimization(TabBox::TabBoxConfig::ClientMinimizedMode mode);
77​ void setApplicationMode(TabBox::TabBoxConfig::ClientApplicationsMode mode);
78​ void setShowDesktopMode(TabBox::TabBoxConfig::ShowDesktopMode mode);
79​ void setSwitchingModeChanged(TabBox::TabBoxConfig::ClientSwitchingMode mode);
80​ void setLayoutName(const QString &layoutName);
81​
82​ // EffectCombo Data Model
83​ void setEffectComboModel(QStandardItemModel *model);
84​ QVariant effectComboCurrentData(int role = Qt::UserRole) const;
85​
86​ void loadShortcuts();
87​ void resetShortcuts();
88​
89​Q_SIGNALS:
90​ void filterScreenChanged(int value);
91​ void filterDesktopChanged(int value);
92​ void filterActivitiesChanged(int value);
93​ void filterMinimizationChanged(int value);
94​ void applicationModeChanged(int value);
95​ void showDesktopModeChanged(int value);
96​ void switchingModeChanged(int value);
97​ void layoutNameChanged(const QString &layoutName);
98​ void effectConfigButtonClicked();
99​
100​private Q_SLOTS:
101​ void tabBoxToggled(bool on);
102​ void onFilterScreen();
103​ void onFilterDesktop();
104​ void onFilterActivites();
105​ void onFilterMinimization();
106​ void onApplicationMode();
107​ void onShowDesktopMode();
108​ void onSwitchingMode();
109​ void onEffectCombo();
110​ void shortcutChanged(const QKeySequence &seq);
111​
112​private:
113​ KActionCollection *m_actionCollection = nullptr;
114​ KShortcutsEditor *m_editor = nullptr;
115​
116​ TabboxType m_type;
117​ Ui::KWinTabBoxConfigForm *ui;
118​};
119​
120​} // namespace
121​
122​#endif