Differential D2370 Diff 6176 plugins/platforms/drm/drm_object_connector.h

Changeset View

Standalone View

plugins/platforms/drm/drm_object_connector.h

This file was added.

1		/********************************************************************
2		KWin - the KDE window manager
3		This file is part of the KDE project.
4
5		Copyright (C) 2016 Roman Gilg <subdiff@gmail.com>
6
7		This program is free software; you can redistribute it and/or modify
8		it under the terms of the GNU General Public License as published by
9		the Free Software Foundation; either version 2 of the License, or
10		(at your option) any later version.
11
12		This program is distributed in the hope that it will be useful,
13		but WITHOUT ANY WARRANTY; without even the implied warranty of
14		MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15		GNU General Public License for more details.
16
17		You should have received a copy of the GNU General Public License
18		along with this program. If not, see <http://www.gnu.org/licenses/>.
19		*********************************************************************/
20		#ifndef KWIN_DRM_OBJECT_CONNECTOR_H
21		#define KWIN_DRM_OBJECT_CONNECTOR_H
22
23		#include "drm_object.h"
24
25		namespace KWin
26		{
27
28		class DrmConnector : public DrmObject
29		{
30		public:
31		DrmConnector(uint32_t connector_id, int fd);
32
33		virtual ~DrmConnector();
34
35		bool init();
36
	graesslinUnsubmitted Done general coding style comment. Types normally start with a capital letter. So Property (no need for the Enum suffix, It's properly namespaced). Also for enums we prefer to use the new enum class nowadays which gives you proper namespacing. And the enum values follow the normal CamelCase rules. So for this enum it should be something like: enum class Property { Crtc, Count }; graesslin: general coding style comment. Types normally start with a capital letter. So Property (no need…
	romanggAuthorUnsubmitted Done I tried using enum classes but the problem is, that you can't subclass them and implicit conversion between int and enum class are not allowed. Look at DrmObject::propValue(int index) and the other property functions there. You want to call them with the enum implemented in the respective subclass, but if you do it with enum classes, you would need always a static cast (look at DrmOutput::atomicReqModesetPopulate, why this would be ugly. romangg: I tried using enum classes but the problem is, that you can't subclass them and implicit…
	graesslinUnsubmitted Done you don't need to static_cast. You can also int(EnumValue). graesslin: you don't need to static_cast. You can also int(EnumValue).
37		enum class PropertyIndex {
38		CrtcId = 0,
39		Count
40		};
41
	graesslinUnsubmitted Done bool instead of int graesslin: bool instead of int
42		bool initProps();
43		};
44
45		}
46
47		#endif
48