Differential D27988 Diff 77440 kcmkwin/kwincompositing/kwincompositing_setting.kcfg

Changeset View

Standalone View

View Options

kcmkwin/kwincompositing/kwincompositing_setting.kcfg

1<?xml version="1.0" encoding="UTF-8"?> 1​<?xml version="1.0" encoding="UTF-8"?>
2<kcfg xmlns="http://www.kde.org/standards/kcfg/1.0" 2​<kcfg xmlns="http://www.kde.org/standards/kcfg/1.0"
3 xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" 3​ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
4 xsi:schemaLocation="http://www.kde.org/standards/kcfg/1.0 4​ xsi:schemaLocation="http://www.kde.org/standards/kcfg/1.0
5 http://www.kde.org/standards/kcfg/1.0/kcfg.xsd" > 5​ http://www.kde.org/standards/kcfg/1.0/kcfg.xsd" >
6 <kcfgfile name="kwinrc"/> 6​ <kcfgfile name="kwinrc"/>
7 7​
8 <group name="KDE"> 8​ <group name="KDE">
9 <entry name="AnimationDurationFactor" type="Double"> 9​ <entry name="AnimationDurationFactor" type="Double">
10 <default>1.0</default> 10​ <default>1.0</default>
11 </entry> 11​ </entry>
12 </group> 12​ </group>
13 13​
14 <group name="Compositing"> 14​ <group name="Compositing">
15 15​
16 <entry name="HiddenPreviews" type="Int"> 16​ <entry name="HiddenPreviews" type="Enum">
17 <default>5</default> 17​ <default>Shown</default>
18​ <choices>
19​ <choice name="Off" value="4"/>
20​ <choice name="Shown" value="5"/>
21​ <choice name="Always" value="6"/>
22​ </choices>
18 </entry> 23​ </entry>
19 24​
20 <entry name="GLTextureFilter" type="Int"> 25​ <entry name="GLTextureFilter" type="Int">
ervinUnsubmitted
Done

This is asking for name + value (to avoid the dreaded "gL" on the C++ side)

ervin: This is asking for name + value (to avoid the dreaded "gL" on the C++ side)
21 <default>2</default> 26​ <default>2</default>
22 </entry> 27​ </entry>
23 28​
24 <entry name="XRenderSmoothScale" type="Bool"> 29​ <entry name="XRenderSmoothScale" type="Enum">
25 <default>false</default> 30​ <default>Crisp</default>
31​ <choices>
32​ <choice name="Crisp" value="false" />
33​ <choice name="Smooth" value="true" />
34​ </choices>
26 </entry> 35​ </entry>
27 36​
28 <entry name="Enabled" type="Bool"> 37​ <entry name="Enabled" type="Bool">
29 <default>true</default> 38​ <default>true</default>
30 </entry> 39​ </entry>
31 40​
32 <entry name="OpenGLIsUnsafe" type="Bool"> 41​ <entry name="OpenGLIsUnsafe" type="Bool">
33 <default>true</default> 42​ <default>true</default>
34 </entry> 43​ </entry>
35 44​
36 <entry name="GLPreferBufferSwap" type="Enum"> 45​ <entry name="GLPreferBufferSwap" type="Enum">
ervinUnsubmitted
Done

ditto

ervin: ditto
37 <default>a</default> 46​ <default>a</default>
38 <choices> 47​ <choices>
39 <choice name="n" /> 48​ <choice name="n" />
bportUnsubmitted
Done

Perhaps we can add comment, kcfg can be used as documentation

bport: Perhaps we can add comment, kcfg can be used as documentation
mevenAuthorUnsubmitted
Done

I have added the proper enum's name

meven: I have added the proper enum's name
40 <choice name="a" /> 49​ <choice name="a" />
41 <choice name="e" /> 50​ <choice name="e" />
42 <choice name="p" /> 51​ <choice name="p" />
43 <choice name="c" /> 52​ <choice name="c" />
44 </choices> 53​ </choices>
45 </entry> 54​ </entry>
46 55​
47 <entry name="Backend" type="Enum"> 56​ <entry name="Backend" type="Enum">
48 <default>OpenGL</default> 57​ <default>OpenGL</default>
49 <choices> 58​ <choices>
50 <choice name="OpenGL" /> 59​ <choice name="OpenGL" />
51 <choice name="XRender" /> 60​ <choice name="XRender" />
52 </choices> 61​ </choices>
53 </entry> 62​ </entry>
54 63​
55 <entry name="GLCore" type="Bool"> 64​ <entry name="GLCore" type="Bool">
ervinUnsubmitted
Done

ditto

ervin: ditto
56 <default>false</default> 65​ <default>false</default>
57 </entry> 66​ </entry>
58 67​
59 <entry name="WindowsBlockCompositing" type="Bool"> 68​ <entry name="WindowsBlockCompositing" type="Bool">
60 <default>true</default> 69​ <default>true</default>
61 </entry> 70​ </entry>
62 71​
63 <entry name="GLPlatformInterface" type="String"> 72​ <entry name="GLPlatformInterface" type="String">
ervinUnsubmitted
Not Done

ditto

ervin: ditto
64 <default>glx</default> 73​ <default>glx</default>
65 <choices> 74​ <choices>
66 <choice name="glx" /> 75​ <choice name="glx" />
67 <choice name="egl" /> 76​ <choice name="egl" />
68 </choices> 77​ </choices>
69 </entry> 78​ </entry>
zzagUnsubmitted
Done

Please remove this entry because it's unused. In general, it would probably be nice to re-introduce the "OpenGL Platform Interface" option. It was originally present in the QML based version of this KCM, but then we switched back to qwidgets. :/

zzag: Please remove this entry because it's unused. In general, it would probably be nice to re…
70 79​
71 </group> 80​ </group>
72 81​
73</kcfg> 82​</kcfg>