Differential D25010 Diff 77386 src/ioslaves/file/file.h

Changeset View

Standalone View

View Options

src/ioslaves/file/file.h

Show First 20 Lines • Show All 89 Lines • ▼ Show 20 Line(s)89#if HAVE_POSIX_ACL
90 static bool isExtendedACL(acl_t acl); 90​ static bool isExtendedACL(acl_t acl);
91#endif 91​#endif
92 92​
93protected: 93​protected:
94 void virtual_hook(int id, void *data) override; 94​ void virtual_hook(int id, void *data) override;
95 95​
96private: 96​private:
97 bool createUDSEntry(const QString &filename, const QByteArray &path, KIO::UDSEntry &entry, 97​ bool createUDSEntry(const QString &filename, const QByteArray &path, KIO::UDSEntry &entry,
98 short int details); 98​ KIO::StatDetails details);
99 int setACL(const char *path, mode_t perm, bool _directoryDefault); 99​ int setACL(const char *path, mode_t perm, bool _directoryDefault);
100 QString getUserName(KUserId uid) const; 100​ QString getUserName(KUserId uid) const;
101 QString getGroupName(KGroupId gid) const; 101​ QString getGroupName(KGroupId gid) const;
102 bool deleteRecursive(const QString &path); 102​ bool deleteRecursive(const QString &path);
103 103​
104 void fileSystemFreeSpace(const QUrl &url); // KF6 TODO: Turn into virtual method in SlaveBase 104​ void fileSystemFreeSpace(const QUrl &url); // KF6 TODO: Turn into virtual method in SlaveBase
105 105​
106 bool privilegeOperationUnitTestMode(); 106​ bool privilegeOperationUnitTestMode();
Show All 9 Lines
116 116​
117 // Close without calling finish(). Use this to close after error. 117​ // Close without calling finish(). Use this to close after error.
118 void closeWithoutFinish(); 118​ void closeWithoutFinish();
119 119​
120private: 120​private:
121 mutable QHash<KUserId, QString> mUsercache; 121​ mutable QHash<KUserId, QString> mUsercache;
122 mutable QHash<KGroupId, QString> mGroupcache; 122​ mutable QHash<KGroupId, QString> mGroupcache;
123 QFile *mFile; 123​ QFile *mFile;
124 124​
dfaureUnsubmitted
Done

Please move it up with the other private methods. This last section is member variables only.

Also, it could be marked as const.

dfaure: Please move it up with the other private methods. This last section is member variables only.
125 bool testMode = false; 125​ bool testMode = false;
126​ KIO::StatDetails getStatDetails();
126}; 127​};
127 128​
128#endif 129​#endif