Differential D27669 Diff 77333 kstyle/breezetoolsareamanager.h

Changeset View

Standalone View

View Options

kstyle/breezetoolsareamanager.h

  • This file was added.
1​#ifndef breezetoolsareamanager_h
2​#define breezetoolsareamanager_h
hpereiradacostaUnsubmitted
Done

Please use garding defines rather than "pragma once" for consistency with the rest of the code.

hpereiradacosta: Please use garding defines rather than "pragma once" for consistency with the rest of the code.
3​
4​#include <QObject>
5​#include <QVariantAnimation>
6​#include "breezehelper.h"
7​
8​namespace Breeze {
9​ typedef struct ToolsAreaAnimation {
hpereiradacostaUnsubmitted
Done

Please remove the typedef. Not needed

hpereiradacosta: Please remove the typedef. Not needed
10​ QPointer<QVariantAnimation> foregroundColorAnimation;
11​ QPointer<QVariantAnimation> backgroundColorAnimation;
12​ bool prevActive;
13​ };
14​ class ToolsAreaManager: public QObject
15​ {
16​ Q_OBJECT
17​
18​ public:
19​ explicit ToolsAreaManager(QObject *parent = nullptr, Helper* helper = nullptr);
20​ ~ToolsAreaManager();
hpereiradacostaUnsubmitted
Done

you don't need the default arguments.
and in fact passing nullptr for helper will crash the code everywhere.

hpereiradacosta: you don't need the default arguments. and in fact passing nullptr for helper will crash the…
21​ void registerWidget(QWidget *widget);
22​ void unregisterWidget(QWidget *widget);
23​ void updateAnimations();
24​
25​ QColor foreground(const QWidget *widget);
26​ QColor background(const QWidget *widget);
27​
28​ QMap<QWindow*,ToolsAreaAnimation> animationMap;
29​
hpereiradacostaUnsubmitted
Done

don't put members public. Members should be private, and proper accessors/modifiers should be added.

hpereiradacosta: don't put members public. Members should be private, and proper accessors/modifiers should be…
30​ Q_SIGNALS:
31​ void toolbarUpdated();
32​
33​ private:
34​ void registerAnimation( QWidget *widget );
35​ QList<QWidget*> _registeredWidgets;
36​ Helper* _helper;
37​ };
38​}
39​
40​#endif
41​No newline at end of file
hpereiradacostaUnsubmitted
Done

Should use a QSet rather than QList. It is faster on removal and contain check.
Should also use const QWidget* as a contained object to avoid unnecessary need for const_caast

hpereiradacosta: Should use a QSet rather than QList. It is faster on removal and contain check. Should also…