Differential D27955 Diff 77307 kcmkwin/kwincompositing/compositing.h

Changeset View

Standalone View

kcmkwin/kwincompositing/compositing.h

Show All 22 Lines
23	#define COMPOSITING_H	23		#define COMPOSITING_H
24		24
25	#include <QAbstractItemModel>	25		#include <QAbstractItemModel>
26	#include <QObject>	26		#include <QObject>
27	#include <KSharedConfig>	27		#include <KSharedConfig>
28		28
29	class OrgKdeKwinCompositingInterface;	29		class OrgKdeKwinCompositingInterface;
30		30
		31		class KWinCompositingSetting;
		32
31	namespace KWin {	33		namespace KWin {
32	namespace Compositing {	34		namespace Compositing {
33		35
34	class OpenGLPlatformInterfaceModel;	36		class OpenGLPlatformInterfaceModel;
35		37
36	class Compositing : public QObject	38		class Compositing : public QObject
37	{	39		{
38		40
Show All 38 Lines		53	public:
77	void setOpenGLPlatformInterface(int interface);	79		void setOpenGLPlatformInterface(int interface);
78	void setWindowsBlockCompositing(bool set);	80		void setWindowsBlockCompositing(bool set);
79		81
80	void save();	82		void save();
81		83
82	static bool isRunningPlasma();	84		static bool isRunningPlasma();
83		85
84	public Q_SLOTS:	86		public Q_SLOTS:
85	void reset();	87		void load();
86	void defaults();	88		void defaults();
87		89
88	Q_SIGNALS:	90		Q_SIGNALS:
89	void changed();	91		void changed(bool changed);
		92		void defaulted(bool defaulted);
		93		void onChanged();
			zzagUnsubmitted Done We probably don't need this signal anymore. zzag: We probably don't need this signal anymore.
90	void animationSpeedChanged(qreal);	94		void animationSpeedChanged(qreal);
91	void windowThumbnailChanged(int);	95		void windowThumbnailChanged(int);
92	void glScaleFilterChanged(int);	96		void glScaleFilterChanged(int);
93	void xrScaleFilterChanged(int);	97		void xrScaleFilterChanged(int);
94	void glSwapStrategyChanged(int);	98		void glSwapStrategyChanged(int);
95	void compositingTypeChanged(int);	99		void compositingTypeChanged(int);
96	void compositingEnabledChanged(bool);	100		void compositingEnabledChanged(bool);
97	void openGLPlatformInterfaceChanged(int);	101		void openGLPlatformInterfaceChanged(int);
98	void windowsBlockCompositingChanged(bool);	102		void windowsBlockCompositingChanged(bool);
99		103
100	private:	104		private:
		105		void applyValues();
		106		void updateSettings();
		107
101	qreal m_animationSpeed;	108		qreal m_animationSpeed;
			zzagUnsubmitted Done naming nit: could you please rename these methods to something else? It's unclear what values `applyValues` applies. What about these? void updateSettingsFromUi(); void updateUiFromSettings(); Feel free to ignore this comment because it looks like these methods will go away in D27988 zzag: naming nit: could you please rename these methods to something else? It's unclear what values…
102	int m_windowThumbnail;	109		int m_windowThumbnail;
103	int m_glScaleFilter;	110		int m_glScaleFilter;
104	bool m_xrScaleFilter;	111		bool m_xrScaleFilter;
105	int m_glSwapStrategy;	112		int m_glSwapStrategy;
106	int m_compositingType;	113		int m_compositingType;
107	bool m_compositingEnabled;	114		bool m_compositingEnabled;
108	bool m_changed;	115		bool m_changed;
109	OpenGLPlatformInterfaceModel *m_openGLPlatformInterfaceModel;	116		OpenGLPlatformInterfaceModel *m_openGLPlatformInterfaceModel;
110	int m_openGLPlatformInterface;	117		int m_openGLPlatformInterface;
111	bool m_windowsBlockCompositing;	118		bool m_windowsBlockCompositing;
112	bool m_windowsBlockingCompositing;	119		bool m_windowsBlockingCompositing;
113	OrgKdeKwinCompositingInterface *m_compositingInterface;	120		OrgKdeKwinCompositingInterface *m_compositingInterface;
114	KSharedConfigPtr m_config;	121		KSharedConfigPtr m_config;
		122		KWinCompositingSetting *m_settings;
115	};	123		};
116		124
117		125
118	struct CompositingData;	126		struct CompositingData;
119		127
120	class CompositingType : public QAbstractItemModel	128		class CompositingType : public QAbstractItemModel
121	{	129		{
122		130
▲ Show 20 Lines • Show All 63 Lines • Show Last 20 Lines