Changeset View
Changeset View
Standalone View
Standalone View
src/kcm/package/contents/ui/Accounts.qml
| Show All 12 Lines | |||||
| 13 | * GNU Library General Public License for more details | 13 | * GNU Library General Public License for more details | ||
| 14 | * | 14 | * | ||
| 15 | * You should have received a copy of the GNU Library General Public | 15 | * You should have received a copy of the GNU Library General Public | ||
| 16 | * License along with this program; if not, write to the | 16 | * License along with this program; if not, write to the | ||
| 17 | * Free Software Foundation, Inc., | 17 | * Free Software Foundation, Inc., | ||
| 18 | * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | 18 | * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | ||
| 19 | */ | 19 | */ | ||
| 20 | 20 | | |||
| 21 | 21 | import QtQuick 2.12 | |||
| 22 | 22 | import QtQuick.Controls 2.12 as Controls | |||
| 23 | import QtQuick 2.7 | 23 | import QtQuick.Layouts 1.12 | ||
| 24 | import QtQuick.Layouts 1.11 | | |||
| 25 | import QtQuick.Controls 2.0 as Controls | | |||
| 26 | 24 | | |||
| 27 | import org.kde.kirigami 2.7 as Kirigami | 25 | import org.kde.kirigami 2.7 as Kirigami | ||
| 28 | | ||||
| 29 | import org.kde.kaccounts 1.0 | | |||
| 30 | import org.kde.kcm 1.2 | 26 | import org.kde.kcm 1.2 | ||
| 31 | 27 | | |||
| 32 | import Ubuntu.OnlineAccounts 0.1 as OA | 28 | import org.kde.kaccounts 1.2 as KAccounts | ||
| 33 | 29 | | |||
| 34 | ScrollViewKCM { | 30 | ScrollViewKCM { | ||
| 35 | id: kaccountsRoot | 31 | id: kaccountsRoot | ||
| 36 | 32 | | |||
| 37 | // Existing accounts | 33 | // Existing accounts | ||
| 38 | view: ListView { | 34 | view: ListView { | ||
| 39 | model: OA.AccountServiceModel { | 35 | model: KAccounts.AccountsModel { } | ||
| 40 | id: accountsModel | | |||
| 41 | service: "global" | | |||
| 42 | includeDisabled: true | | |||
| 43 | } | | |||
| 44 | 36 | | |||
| 45 | delegate: Kirigami.SwipeListItem { | 37 | delegate: Kirigami.SwipeListItem { | ||
| 46 | id: accountDelegate | 38 | id: accountDelegate | ||
| 47 | width: ListView.view.width | 39 | width: ListView.view.width | ||
| 48 | 40 | | |||
| 49 | contentItem: Controls.Label { | 41 | contentItem: RowLayout { | ||
| 42 | implicitWidth: accountDelegate.ListView.view.width | ||||
| 43 | implicitHeight: Kirigami.Units.iconSizes.large + Kirigami.Units.smallSpacing * 2 | ||||
| 44 | spacing: Kirigami.Units.smallSpacing | ||||
| 45 | Kirigami.Icon { | ||||
| 46 | source: model.iconName | ||||
| 47 | Layout.preferredWidth: Kirigami.Units.iconSizes.large | ||||
nicolasfella: IMO large is too large, but it should use whatever comes out of T12789 | |||||
Yeah, this wants a central decision before just sort of... picking another one :) For now i'm thinking internal consistency is better, since there's no general consensus (yet!) - once there is, it's an easy fix :) leinir: Yeah, this wants a central decision before just sort of... picking another one :) For now i'm… | |||||
| 48 | Layout.preferredHeight: Kirigami.Units.iconSizes.large | ||||
Here you are essentially recreating Kirigami.BasicListItem. I guess you have to because of the SwipeListItem, but maybe that's something that should be addressed in Kirigami nicolasfella: Here you are essentially recreating Kirigami.BasicListItem. I guess you have to because of the… | |||||
Pretty much that, yes - and definitely wants doing in Kirigami (not sure if BasicSwipeListItem wants to happen, or if it just needs to be in SwipeListItem... thinking the former, as the latter might just well end up being a bit heavy, carrying about those objects that would end up replaced by a lot of apps anyway, in what is already a heavy component...) leinir: Pretty much that, yes - and definitely wants doing in Kirigami (not sure if BasicSwipeListItem… | |||||
| 49 | } | ||||
| 50 | Controls.Label { | ||||
| 51 | Layout.fillWidth: true | ||||
| 50 | text: { | 52 | text: { | ||
| 51 | if (model.displayName.length > 0 && model.providerName.length > 0) { | 53 | if (model.displayName.length > 0 && model.providerName.length > 0) { | ||
| 52 | return i18n("%1 (%2)", model.displayName, model.providerName) | 54 | return i18n("%1 (%2)", model.displayName, model.providerName) | ||
| 53 | } else if (model.displayName.length > 0) { | 55 | } else if (model.displayName.length > 0) { | ||
| 54 | return model.displayName | 56 | return model.displayName | ||
| 55 | } else { | 57 | } else { | ||
| 56 | return i18n("%1 account", model.providerName) | 58 | return i18n("%1 account", model.providerName) | ||
| 57 | } | 59 | } | ||
| 58 | } | 60 | } | ||
| 59 | | ||||
| 60 | OA.Account { | | |||
| 61 | id: account | | |||
| 62 | objectHandle: model.accountHandle | | |||
| 63 | } | 61 | } | ||
| 64 | } | 62 | } | ||
| 65 | actions: [ | 63 | actions: [ | ||
| 66 | Kirigami.Action { | 64 | Kirigami.Action { | ||
| 67 | text: i18nc("Tooltip for an action which will offer the user to remove the mentioned account", "Remove %1", accountDelegate.contentItem.text) | 65 | text: i18nc("Tooltip for an action which will offer the user to remove the mentioned account", "Remove %1", accountDelegate.contentItem.text) | ||
| 68 | iconName: "edit-delete-remove" | 66 | iconName: "edit-delete-remove" | ||
| 69 | onTriggered: { | 67 | onTriggered: { | ||
| 70 | accountRemovalDlg.account = account; | 68 | accountRemover.accountId = model.id; | ||
| 71 | accountRemovalDlg.displayName = model.displayName; | 69 | accountRemover.displayName = model.displayName; | ||
| 72 | accountRemovalDlg.providerName = model.providerName; | 70 | accountRemover.providerName = model.providerName; | ||
| 73 | accountRemovalDlg.open(); | 71 | accountRemover.open(); | ||
| 74 | } | 72 | } | ||
| 75 | } | 73 | } | ||
| 76 | ] | 74 | ] | ||
| 77 | onClicked: kcm.push("AvailableServices.qml", {accountId: model.accountId}) | 75 | onClicked: kcm.push("AccountDetails.qml", {model: model.services}) | ||
| 78 | } | 76 | } | ||
| 79 | Controls.Label { | 77 | Controls.Label { | ||
| 80 | anchors { | 78 | visible: view.count === 0 | ||
| 81 | fill: parent | 79 | anchors.fill: parent | ||
| 82 | margins: Kirigami.Units.largeSpacing | 80 | clip: true | ||
| 83 | } | 81 | enabled: false | ||
| 84 | verticalAlignment: Text.AlignVCenter | | |||
| 85 | horizontalAlignment: Text.AlignHCenter | 82 | horizontalAlignment: Text.AlignHCenter | ||
| 83 | verticalAlignment: Text.AlignVCenter | ||||
| 86 | wrapMode: Text.Wrap | 84 | wrapMode: Text.Wrap | ||
| 87 | visible: parent.count === 0 | 85 | text: i18nc("A text shown when a user has not yet added any accounts", "You have not added any accounts yet.\n\nClick on \"Add New Account...\" below to do so.") | ||
| 88 | opacity: 0.5 | | |||
| 89 | text: i18nc("A text shown when a user has not yet added any accounts", "You have not added any accounts yet.\nClick the \"Add new Account\" button below to do so.") | | |||
| 90 | } | 86 | } | ||
| 91 | } | 87 | } | ||
| 92 | MessageBoxSheet { | 88 | | ||
This code is effectively duplicated between two files. It would probably be better to move it into a separate "RemoveAccountDialog" or so. ahiemstra: This code is effectively duplicated between two files. It would probably be better to move it… | |||||
Thanks for the reminder, yeah, i wanted to do that before and kind of... just forgot, i guess :) leinir: Thanks for the reminder, yeah, i wanted to do that before and kind of... just forgot, i guess :) | |||||
| 93 | id: accountRemovalDlg | 89 | RemoveAccountDialog { | ||
| 90 | id: accountRemover | ||||
| 94 | parent: kaccountsRoot | 91 | parent: kaccountsRoot | ||
| 95 | property QtObject account | | |||
| 96 | property string displayName | | |||
| 97 | property string providerName | | |||
| 98 | title: i18nc("The title for a dialog which lets you remove an account", "Remove Account?") | | |||
| 99 | text: { | | |||
| 100 | if (accountRemovalDlg.displayName.length > 0 && accountRemovalDlg.providerName.length > 0) { | | |||
| 101 | return i18nc("The text for a dialog which lets you remove an account when both provider name and account name are available", "Are you sure you wish to remove the \"%1\" account \"%2\"?", accountRemovalDlg.providerName, accountRemovalDlg.displayName) | | |||
| 102 | } else if (accountRemovalDlg.displayName.length > 0) { | | |||
| 103 | return i18nc("The text for a dialog which lets you remove an account when only the account name is available", "Are you sure you wish to remove the account \"%1\"?", accountRemovalDlg.displayName) | | |||
| 104 | } else { | | |||
| 105 | return i18nc("The text for a dialog which lets you remove an account when only the provider name is available", "Are you sure you wish to remove this \"%1\" account?", accountRemovalDlg.providerName) | | |||
| 106 | } | | |||
| 107 | } | | |||
| 108 | actions: [ | | |||
| 109 | Kirigami.Action { | | |||
| 110 | text: i18nc("The label for a button which will cause the removal of a specified account", "Remove Account") | | |||
| 111 | onTriggered: { accountRemovalDlg.account.remove(); } | | |||
| 112 | } | | |||
| 113 | ] | | |||
| 114 | } | 92 | } | ||
| 115 | 93 | | |||
| 116 | footer: RowLayout { | 94 | footer: RowLayout { | ||
| 117 | Controls.Button { | 95 | Controls.Button { | ||
| 118 | Layout.alignment: Qt.AlignRight | 96 | Layout.alignment: Qt.AlignRight | ||
| 119 | text: i18n("Add new Account") | 97 | text: i18n("Add New Account...") | ||
| 120 | icon.name: "contact-new" | 98 | icon.name: "contact-new" | ||
| 121 | onClicked: kcm.push("AvailableAccounts.qml") | 99 | onClicked: kcm.push("AvailableAccounts.qml") | ||
| 122 | } | 100 | } | ||
| 123 | } | 101 | } | ||
| 124 | } | 102 | } | ||
IMO large is too large, but it should use whatever comes out of T12789