Differential D27463 Diff 77226 src/kconfig_compiler/KConfigCommonStructs.h

Changeset View

Standalone View

src/kconfig_compiler/KConfigCommonStructs.h

Show First 20 Lines • Show All 49 Lines • ▼ Show 20 Line(s)
50	{	50		{
51	public:	51		public:
52	struct Choice {	52		struct Choice {
53	QString name;	53		QString name;
54	QString context;	54		QString context;
55	QString label;	55		QString label;
56	QString toolTip;	56		QString toolTip;
57	QString whatsThis;	57		QString whatsThis;
		58		QString val;
		59
		60		QString value() const
			ervinUnsubmitted Not Done New line before opening curly brace please ervin: New line before opening curly brace please
		61		{
			ervinUnsubmitted Done New line before opening curly brace please. ervin: New line before opening curly brace please.
		62		return !val.isEmpty() ? val : name;
		63		}
58	};	64		};
59	class Choices	65		class Choices
60	{	66		{
61	public:	67		public:
62	Choices() {}	68		Choices() {}
63	Choices(const QList<Choice> &d, const QString &n, const QString &p)	69		Choices(const QList<Choice> &d, const QString &n, const QString &p)
64	: prefix(p), choices(d), mName(n)	70		: prefix(p), choices(d), mName(n)
65	{	71		{
Show All 33 Lines		96	public:
99	QString whatsThisContext;	105		QString whatsThisContext;
100	QString whatsThis;	106		QString whatsThis;
101	QString code;	107		QString code;
102	QString defaultValue;	108		QString defaultValue;
103	QString param;	109		QString param;
104	QString paramName;	110		QString paramName;
105	QString paramType;	111		QString paramType;
106	Choices choices;	112		Choices choices;
107	QList<Signal> signalList;	113		QList<Signal> signalList;
			ervinUnsubmitted Done Well, on that side you should have kept the more natural value() method IMO. ervin: Well, on that side you should have kept the more natural value() method IMO.
108	QStringList paramValues;	114		QStringList paramValues;
109	QStringList paramDefaultValues;	115		QStringList paramDefaultValues;
110	int paramMax;	116		int paramMax;
111	bool hidden;	117		bool hidden;
112	QString min;	118		QString min;
113	QString max;	119		QString max;
114	};	120		};
115		121
▲ Show 20 Lines • Show All 93 Lines • Show Last 20 Lines