Changeset View
Changeset View
Standalone View
Standalone View
src/document/katedocument.h
Show First 20 Lines • Show All 77 Lines • ▼ Show 20 Line(s) | |||||
78 | 78 | | |||
79 | /** | 79 | /** | ||
80 | * @brief Backend of KTextEditor::Document related public KTextEditor interfaces. | 80 | * @brief Backend of KTextEditor::Document related public KTextEditor interfaces. | ||
81 | * | 81 | * | ||
82 | * @warning This file is @e private API and not part of the public | 82 | * @warning This file is @e private API and not part of the public | ||
83 | * KTextEditor interfaces. | 83 | * KTextEditor interfaces. | ||
84 | */ | 84 | */ | ||
85 | class KTEXTEDITOR_EXPORT KTextEditor::DocumentPrivate : public KTextEditor::Document, | 85 | class KTEXTEDITOR_EXPORT KTextEditor::DocumentPrivate : public KTextEditor::Document, | ||
86 | public KTextEditor::MarkInterface, | 86 | public KTextEditor::MarkInterfaceV2, | ||
anthonyfieroni: Why private class is exported, changing parent of an exported class is BIC. | |||||
See the warning in the API docs, nobody should rely on this private API, so the BIC here is okay. kossebau: See the warning in the API docs, nobody should rely on this private API, so the BIC here is… | |||||
dhaumann: Friedrich is correct. We have no issue here. | |||||
87 | public KTextEditor::ModificationInterface, | 87 | public KTextEditor::ModificationInterface, | ||
88 | public KTextEditor::ConfigInterface, | 88 | public KTextEditor::ConfigInterface, | ||
89 | public KTextEditor::AnnotationInterface, | 89 | public KTextEditor::AnnotationInterface, | ||
90 | public KTextEditor::MovingInterface, | 90 | public KTextEditor::MovingInterface, | ||
91 | private KTextEditor::MovingRangeFeedback | 91 | private KTextEditor::MovingRangeFeedback | ||
92 | { | 92 | { | ||
93 | Q_OBJECT | 93 | Q_OBJECT | ||
94 | Q_INTERFACES(KTextEditor::MarkInterface) | 94 | Q_INTERFACES(KTextEditor::MarkInterface) | ||
95 | Q_INTERFACES(KTextEditor::MarkInterfaceV2) | ||||
95 | Q_INTERFACES(KTextEditor::ModificationInterface) | 96 | Q_INTERFACES(KTextEditor::ModificationInterface) | ||
96 | Q_INTERFACES(KTextEditor::AnnotationInterface) | 97 | Q_INTERFACES(KTextEditor::AnnotationInterface) | ||
97 | Q_INTERFACES(KTextEditor::ConfigInterface) | 98 | Q_INTERFACES(KTextEditor::ConfigInterface) | ||
98 | Q_INTERFACES(KTextEditor::MovingInterface) | 99 | Q_INTERFACES(KTextEditor::MovingInterface) | ||
99 | 100 | | |||
100 | friend class KTextEditor::Document; | 101 | friend class KTextEditor::Document; | ||
101 | friend class ::KateDocumentTest; | 102 | friend class ::KateDocumentTest; | ||
102 | friend class ::KateBuffer; | 103 | friend class ::KateBuffer; | ||
▲ Show 20 Lines • Show All 474 Lines • ▼ Show 20 Line(s) | 574 | Q_SIGNALS: | |||
577 | 578 | | |||
578 | void markClicked(KTextEditor::Document *document, KTextEditor::Mark mark, bool &handled); | 579 | void markClicked(KTextEditor::Document *document, KTextEditor::Mark mark, bool &handled); | ||
579 | 580 | | |||
580 | void marksChanged(KTextEditor::Document *) override; | 581 | void marksChanged(KTextEditor::Document *) override; | ||
581 | void markChanged(KTextEditor::Document *, KTextEditor::Mark, KTextEditor::MarkInterface::MarkChangeAction) override; | 582 | void markChanged(KTextEditor::Document *, KTextEditor::Mark, KTextEditor::MarkInterface::MarkChangeAction) override; | ||
582 | 583 | | |||
583 | private: | 584 | private: | ||
584 | QHash<int, KTextEditor::Mark *> m_marks; | 585 | QHash<int, KTextEditor::Mark *> m_marks; | ||
585 | QHash<int, QPixmap> m_markPixmaps; | 586 | QHash<int, QVariant> m_markIcons; // QPixmap or QIcon, KF6: remove QPixmap support | ||
dhaumann: Better turn " Remove pixmap support" into use QIcon only. | |||||
586 | QHash<int, QString> m_markDescriptions; | 587 | QHash<int, QString> m_markDescriptions; | ||
587 | uint m_editableMarks = markType01; | 588 | uint m_editableMarks = markType01; | ||
588 | 589 | | |||
590 | // | ||||
591 | // KTextEditor::MarkInterfaceV2 | ||||
592 | // | ||||
593 | public Q_SLOTS: | ||||
594 | void setMarkIcon(MarkInterface::MarkTypes markType, const QIcon &icon) override; | ||||
595 | | ||||
596 | public: | ||||
597 | QIcon markIcon(MarkInterface::MarkTypes markType) const override; | ||||
598 | | ||||
589 | // KTextEditor::PrintInterface | 599 | // KTextEditor::PrintInterface | ||
590 | // | 600 | // | ||
591 | public Q_SLOTS: | 601 | public Q_SLOTS: | ||
592 | bool print() override; | 602 | bool print() override; | ||
593 | void printPreview() override; | 603 | void printPreview() override; | ||
594 | 604 | | |||
595 | // | 605 | // | ||
596 | // KTextEditor::DocumentInfoInterface ( ### unfinished ) | 606 | // KTextEditor::DocumentInfoInterface ( ### unfinished ) | ||
▲ Show 20 Lines • Show All 855 Lines • Show Last 20 Lines |
Why private class is exported, changing parent of an exported class is BIC.