Differential D27669 Diff 77056 kstyle/breezetoolsareamanager.cpp

Changeset View

Standalone View

View Options

kstyle/breezetoolsareamanager.cpp

  • This file was added.
1​#include "breezetoolsareamanager.h"
2​#include <QObject>
3​#include <QWidget>
4​#include <QToolBar>
5​#include <QWindow>
6​#include <QMainWindow>
7​#include <QDebug>
8​
9​namespace Breeze {
10​ ToolsAreaManager::ToolsAreaManager(QObject *parent, Helper *helper) : QObject(parent), _helper(helper) {
11​
12​ }
13​
14​ ToolsAreaManager::~ToolsAreaManager() {
15​ for (auto entry : animationMap) {
16​ delete entry.foregroundColorAnimation;
hpereiradacostaUnsubmitted
Done

This is not needed. Since all animations are created as children of the ToolsAreaManager, they should be deleted automatically when this one is destroyed.
This way you can simply remove the class destructor altogether and rely on the default one (from QObject).

hpereiradacosta: This is not needed. Since all animations are created as children of the ToolsAreaManager, they…
17​ delete entry.backgroundColorAnimation;
18​ }
19​ }
20​
21​ void ToolsAreaManager::updateAnimations() {
22​ for (auto entry : animationMap) {
23​ entry.foregroundColorAnimation->setStartValue(_helper->titleBarTextColor(false));
24​ entry.foregroundColorAnimation->setEndValue(_helper->titleBarTextColor(true));
25​
26​ entry.backgroundColorAnimation->setStartValue(_helper->titleBarColor(false));
27​ entry.backgroundColorAnimation->setEndValue(_helper->titleBarColor(true));
28​ }
29​ }
30​
31​ void ToolsAreaManager::registerAnimation(QWidget *widget) {
32​ auto window = widget->window()->windowHandle();
33​ if (window && !animationMap.contains(window)) {
34​
35​ auto foregroundColorAnimation = new QVariantAnimation(this);
36​ connect(foregroundColorAnimation, &QVariantAnimation::valueChanged,
37​ this, &ToolsAreaManager::toolbarUpdated);
38​
39​ auto backgroundColorAnimation = new QVariantAnimation(this);
40​ connect(backgroundColorAnimation, &QVariantAnimation::valueChanged,
41​ this, &ToolsAreaManager::toolbarUpdated);
42​
43​ foregroundColorAnimation->setStartValue(_helper->titleBarTextColor(false));
44​ foregroundColorAnimation->setEndValue(_helper->titleBarTextColor(true));
45​
46​ backgroundColorAnimation->setStartValue(_helper->titleBarColor(false));
47​ backgroundColorAnimation->setEndValue(_helper->titleBarColor(true));
48​
49​ foregroundColorAnimation->setDuration(50);
50​ backgroundColorAnimation->setDuration(50);
51​
52​ animationMap[window] = ToolsAreaAnimation{
53​ foregroundColorAnimation,
54​ backgroundColorAnimation,
55​ window->isActive(),
56​ };
57​
58​ connect(window, &QWindow::activeChanged,
59​ this, [=]() {
60​ if (!foregroundColorAnimation || !backgroundColorAnimation) return;
61​
62​ auto prevActive = animationMap[window].prevActive;
63​ if (prevActive && !window->isActive()) {
64​ foregroundColorAnimation->setDirection(QAbstractAnimation::Backward);
65​ backgroundColorAnimation->setDirection(QAbstractAnimation::Backward);
66​
67​ foregroundColorAnimation->start();
68​ backgroundColorAnimation->start();
69​ } else if (!prevActive && window->isActive()) {
70​ foregroundColorAnimation->setDirection(QAbstractAnimation::Forward);
71​ backgroundColorAnimation->setDirection(QAbstractAnimation::Forward);
72​
73​ foregroundColorAnimation->start();
74​ backgroundColorAnimation->start();
75​ }
76​ animationMap[window].prevActive = window->isActive();
77​ });
78​
79​ }
80​ }
81​
82​ QColor ToolsAreaManager::foreground(const QWidget *widget) {
83​ auto window = widget->window()->windowHandle();
84​ if (window && animationMap.contains(window) && animationMap[window].foregroundColorAnimation) {
85​ return animationMap[window].foregroundColorAnimation->currentValue().value<QColor>();
86​ }
87​ return QColor();
88​ }
89​
90​ QColor ToolsAreaManager::background(const QWidget *widget) {
91​ auto window = widget->window()->windowHandle();
92​ if (window && animationMap.contains(window) && animationMap[window].backgroundColorAnimation) {
93​ return animationMap[window].backgroundColorAnimation->currentValue().value<QColor>();
94​ }
95​ return QColor();
96​ }
97​
98​
hpereiradacostaUnsubmitted
Done

As far as I have followed the code you need an "unregisterWidget" for when widgets are unpolished and to remove windows from the map.
You also need a connection to the destroyed signal to cleanup the map when a widget is deleted, otherwise you will keep accumulating an ever growing map of dangling pointers.

hpereiradacosta: As far as I have followed the code you need an "unregisterWidget" for when widgets are…
99​ void ToolsAreaManager::registerWidget(QWidget *widget)
100​ {
101​ auto window = qobject_cast<QMainWindow*> (widget);
102​ if (window) {
103​ connect(this, &ToolsAreaManager::toolbarUpdated,
davidreUnsubmitted
Done

This needs at least a comment why we have this hack for telegram

davidre: This needs at least a comment why we have this hack for telegram
104​ window, [this, window]() {
105​ if (_helper->toolsAreaHasContents(window)) {
106​ window->setContentsMargins(0,0,0,0);
107​ } else {
108​ window->setContentsMargins(0,1,0,0);
109​ }
ngrahamUnsubmitted
Done

This seems to make the window content move vertically when the window loses focus

ngraham: This seems to make the window content move vertically when the window loses focus
cblackAuthorUnsubmitted
Done

Eh? What application do you see this behaviour in?

cblack: Eh? What application do you see this behaviour in?
ngrahamUnsubmitted
Done

All of them with anything besides a titlebar in their Tools area: Dolphin, Gwenview, Okular, Kate, Konsole...

ngraham: All of them with anything besides a titlebar in their Tools area: Dolphin, Gwenview, Okular…
ngrahamUnsubmitted
Done

ngraham: {F8168127}
cblackAuthorUnsubmitted
Done

That's odd—the margin shouldn't be shifting based off of window status. Will investigate.

cblack: That's odd—the margin shouldn't be shifting based off of window status. Will investigate.
cblackAuthorUnsubmitted
Done

I believe this is due to how it determines "should draw tools area" conflicting with your colourscheme.
When active, the window and the titlebar colours are different, thus causing the tools are to be drawn. When inactive, the window and the titlebar colours are the same, causing the tools area to not be drawn.

cblack: I believe this is due to how it determines "should draw tools area" conflicting with your…
hpereiradacostaUnsubmitted
Done

That's still needs fixing though. You cannot have things floating around depending on which color scheme is used. right ?
There are many color schemes of all types in the wild. The widget style must work for all.

hpereiradacosta: That's still needs fixing though. You cannot have things floating around depending on which…
cblackAuthorUnsubmitted
Done

This is intentional—if a window's titlebar and content colours are the same, the window is drawn as a homogeneous window instead of a window with a tools area.

cblack: This is intentional—if a window's titlebar and content colours are the same, the window is…
hpereiradacostaUnsubmitted
Done

I was not refering to the rendering of the separator, but rather to the fact that the widgets margin change between active and inactive. This should not happen (disregarding the color scheme).
All in all, whether you need to draw the separator or not you need to add the margin always (or follow David's suggestion)
Unless I misunderstood the actual issue reported by Nathan of course.

hpereiradacosta: I was not refering to the rendering of the separator, but rather to the fact that the widgets…
110​ });
davidreUnsubmitted
Done

Maybe the decision whether to do this could only be made based on the colors of the active state so it's consistent with the inactive one.
Also this happens because the separator line? Do we actually need it? Currently there is no separator between titlebar and window and/or between toolbar and other window content?

davidre: Maybe the decision whether to do this could only be made based on the colors of the active…
111​ }
112​ connect(this, &ToolsAreaManager::toolbarUpdated,
113​ widget, [widget]() {
114​ widget->update();
115​ });
116​ auto toolbar = qobject_cast<QToolBar*>(widget);
117​ if (toolbar) {
118​ connect(toolbar, &QToolBar::visibilityChanged,
119​ this, [this]() {
120​ emit this->toolbarUpdated();
121​ });
hpereiradacostaUnsubmitted
Done

the this-> here are all unnecessary.

hpereiradacosta: the this-> here are all unnecessary.
122​ connect(toolbar, &QToolBar::orientationChanged,
123​ this, [this]() {
124​ emit this->toolbarUpdated();
125​ });
126​ connect(toolbar, &QToolBar::topLevelChanged,
127​ this, [this]() {
128​ emit this->toolbarUpdated();
ndavisUnsubmitted
Not Done

When I run GDB on oxygen-demo5, sometimes it tells me that oxygen-demo5 crashes on this line. I'm not sure how to make it happen reliably, but it usually involves changing QStyles with the Style combobox or color schemes with the Color Scheme combobox.

ndavis: When I run GDB on `oxygen-demo5`, sometimes it tells me that `oxygen-demo5` crashes on this…
ndavisUnsubmitted
Not Done

Now I can consistently get oxygen-demo5 to crash on this line by switching to Fusion and then Oxygen.

ndavis: Now I can consistently get oxygen-demo5 to crash on this line by switching to Fusion and then…
ndavisUnsubmitted
Not Done

I misclicked. It's this line with _helper->_invalidateCachedRects = true;

ndavis: I misclicked. It's this line with `_helper->_invalidateCachedRects = true;`
129​ });
130​ }
131​ connect(widget, &QObject::destroyed,
132​ this, [this, widget]() {
133​ this->unregisterWidget(widget);
134​ });
hpereiradacostaUnsubmitted
Done

Did you check that this chunk of code (changing the contents margins of the QMainWindow) has any effect ? I had my doubt so I changed the margin to 100 instead of 1, added a printout to make sure that this line of code is called, then ran dolphin and
1/ the code is indeed called
2/ it changes nothing, on dolphin, okular, ...
if you can confirm, then just drop it.

(in fact, I don't understand the login in the first place: why would you need to add one pixel on top of everything in the QMainWindow ?)

hpereiradacosta: Did you check that this chunk of code (changing the contents margins of the QMainWindow) has…
cblackAuthorUnsubmitted
Done

This only triggers when the window has no items in the tools area—it's used in conjunction with line 878 of breezestyle.cpp in order to render a border at the top of the window.

cblack: This only triggers when the window has no items in the tools area—it's used in conjunction with…
hpereiradacostaUnsubmitted
Done

Clear enough ! Sorry for the noise ! (and not having read the code with enough attention).

hpereiradacosta: Clear enough ! Sorry for the noise ! (and not having read the code with enough attention).
135​ registerAnimation(widget);
136​ _registeredWidgets << widget;
137​ emit this->toolbarUpdated();
138​ }
139​
140​ void ToolsAreaManager::unregisterWidget(QWidget *widget)
hpereiradacostaUnsubmitted
Done

more unnecessary "this->"
Please try to remove them all.

hpereiradacosta: more unnecessary "this->" Please try to remove them all.
141​ {
142​ _registeredWidgets.removeAll(widget);
143​ QList<QWindow*> toRemove;
144​ for (auto window : animationMap.keys()) {
145​ bool hasWidget = false;
146​ if (std::none_of(_registeredWidgets.begin(), _registeredWidgets.end(), [window](QWidget *widget) {
147​ return window == widget->window()->windowHandle();
hpereiradacostaUnsubmitted
Done

you can break here once one widget is found. no need to loop over the remaining widgets.
alternatively you can use std::any_of or (better) std::none_of

hpereiradacosta: you can break here once one widget is found. no need to loop over the remaining widgets.
148​ })) {
149​ delete animationMap[window].foregroundColorAnimation;
150​ delete animationMap[window].backgroundColorAnimation;
151​ toRemove << window;
152​ }
153​ }
154​ for (auto entry : toRemove) {
155​ animationMap.remove(entry);
156​ }
157​ }
158​}
159​No newline at end of file
hpereiradacostaUnsubmitted
Done

you should also remove the widget from widgetsWithPaletteForToolsAreaSet

hpereiradacosta: you should also remove the widget from widgetsWithPaletteForToolsAreaSet
hpereiradacostaUnsubmitted
Done

Unused

hpereiradacosta: Unused