Differential D27681 Diff 77005 src/kcm/package/contents/ui/AccountDetails.qml

Changeset View

Standalone View

View Options

src/kcm/package/contents/ui/AccountDetails.qml

  • This file was added.
1​/*
2​ * Copyright 2019 Nicolas Fella <nicolas.fella@gmx.de>
3​ * Copyright 2020 Dan Leinir Turthra Jensen <admin@leinir.dk>
4​ *
5​ * This program is free software; you can redistribute it and/or modify
6​ * it under the terms of the GNU Library General Public License as
7​ * published by the Free Software Foundation; either version 2 or
8​ * (at your option) any later version.
9​ *
10​ * This program is distributed in the hope that it will be useful,
11​ * but WITHOUT ANY WARRANTY; without even the implied warranty of
12​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13​ * GNU Library General Public License for more details
14​ *
15​ * You should have received a copy of the GNU Library General Public
16​ * License along with this program; if not, write to the
17​ * Free Software Foundation, Inc.,
18​ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
19​ */
20​
21​import QtQuick 2.7
22​import QtQuick.Layouts 1.11
ahiemstraUnsubmitted
Done

Best be consistent and set these all to the same minor Qt version. You probably want to use 2.12.

ahiemstra: Best be consistent and set these all to the same minor Qt version. You probably want to use 2.
23​import QtQuick.Controls 2.0 as Controls
24​import org.kde.kirigami 2.4 as Kirigami
25​import org.kde.kaccounts 1.2 as KAccounts
26​import org.kde.kcm 1.2
27​
28​SimpleKCM {
29​ id: component;
30​
31​ title: i18n("Account Details")
32​
33​ property alias model: servicesList.model
34​
35​ MessageBoxSheet {
36​ id: accountRemovalDlg
37​ parent: component
ahiemstraUnsubmitted
Done

No abbreviations please.

ahiemstra: No abbreviations please.
leinirAuthorUnsubmitted
Not Done

ok

;)

leinir: ok ;)
38​ property string displayName: servicesList.model.accountDisplayName
39​ property string providerName: servicesList.model.accountProviderName
40​ title: i18nc("The title for a dialog which lets you remove an account", "Remove Account?")
41​ text: {
42​ if (accountRemovalDlg.displayName.length > 0 && accountRemovalDlg.providerName.length > 0) {
43​ return i18nc("The text for a dialog which lets you remove an account when both provider name and account name are available", "Are you sure you wish to remove the \"%1\" account \"%2\"?", accountRemovalDlg.providerName, accountRemovalDlg.displayName)
ahiemstraUnsubmitted
Not Done

You shouldn't need to qualify displayName/providerName here, a property binding on an object can access that object's properties directly. (And removes the need for abbreviations in often-used identifiers. ;) )

ahiemstra: You shouldn't need to qualify displayName/providerName here, a property binding on an object…
leinirAuthorUnsubmitted
Not Done

Mostly, i like doing this to avoid the weird issues that invariably pop up when dealing with attached properties and model roles and whatnot, especially when crossing scopes... (but also, some of them are a bit overzealous, so i'll adjust it a bit :) )

leinir: Mostly, i like doing this to avoid the weird issues that invariably pop up when dealing with…
44​ } else if (accountRemovalDlg.displayName.length > 0) {
45​ return i18nc("The text for a dialog which lets you remove an account when only the account name is available", "Are you sure you wish to remove the account \"%1\"?", accountRemovalDlg.displayName)
46​ } else {
47​ return i18nc("The text for a dialog which lets you remove an account when only the provider name is available", "Are you sure you wish to remove this \"%1\" account?", accountRemovalDlg.providerName)
48​ }
49​ }
50​ actions: [
51​ Kirigami.Action {
52​ text: i18nc("The label for a button which will cause the removal of a specified account", "Remove Account")
53​ onTriggered: {
54​ var job = accountRemovalJob.createObject(component, { "accountId": servicesList.model.accountId });
55​ job.start();
ahiemstraUnsubmitted
Not Done

Not really sure I'm happy with this bit, it seems to me the need to create jobs this way should be handled by something different. Now I, as a user of KAccounts, would need to remember that I need to do this construction to deal with account creation/removal, whereas a separate object that I can instantiate and either connect to with signals or that gives me job instances would be a lot more self-documenting. To me, the jobs are an implementation detail that shouldn't be exposed to QML at all.

ahiemstra: Not really sure I'm happy with this bit, it seems to me the need to create jobs this way should…
leinirAuthorUnsubmitted
Not Done

i personally quite like how explicit the jobs are, but also, you're right that the way they work in QML is... suboptimal. Perhaps wrapping them in something more QML-friendly would make sense, though i'm also now thinking this is something that needs more thought and wants to be done in a generic fashion at a KJob level, because those things are powerful and useful, and pretty awkward in QML just in general, and that's a terrible shame :) (cue someone jumping in and telling me that's already done and i didn't know, right? ;) if not, this sounds like a thing that wants some effort piled onto it)

leinir: i personally quite like how explicit the jobs are, but also, you're right that the way they…
56​ }
57​ }
58​ ]
59​ }
60​
61​ MessageBoxSheet {
62​ id: renameAccountDlg
63​ parent: component
64​ title: i18nc("The title for a dialog which lets you set the human-readable name of an account", "Rename Account")
65​ onSheetOpenChanged: {
66​ if (sheetOpen === true) {
67​ newAccountDisplayName.text = servicesList.model.accountDisplayName;
68​ }
69​ }
70​ contentItem: Kirigami.FormLayout {
71​ Layout.preferredWidth: Kirigami.Units.gridUnit * 10
72​ Layout.margins: Kirigami.Units.largeSpacing
73​ Controls.TextField {
74​ id: newAccountDisplayName
75​ Kirigami.FormData.label: i18nc("Label for the text field used to enter a new human-readable name for an account", "Enter the new name of the account")
76​ }
77​ }
78​ actions: [
79​ Kirigami.Action {
80​ enabled: newAccountDisplayName.text.length > 0
81​ text: i18nc("Text of a button which will cause the human-readable name of an account to be set to a text specified by the user", "Set Account Name")
82​ onTriggered: {
83​ var job = accountDisplayNameJob.createObject(component, { "accountId": servicesList.model.accountId, "displayName": newAccountDisplayName.text })
84​ job.start();
85​ }
86​ }
87​ ]
88​ }
89​
90​ Component {
91​ id: accountDisplayNameJob
92​ KAccounts.ChangeAccountDisplayNameJob { }
93​ }
94​
95​ Component {
96​ id: serviceToggleJob
97​ KAccounts.AccountServiceToggleJob { }
98​ }
99​
100​ Component {
101​ id: accountRemovalJob
102​ KAccounts.RemoveAccountJob {
103​ onFinished: {
104​ kcm.pop();
105​ }
106​ }
107​ }
108​
109​ header: RowLayout {
110​ Layout.fillWidth: true
111​ Layout.margins: Kirigami.Units.smallSpacing
112​ spacing: Kirigami.Units.smallSpacing
113​ Kirigami.Icon {
114​ source: model.accountIconName
115​ Layout.preferredWidth: Kirigami.Units.iconSizes.large
116​ Layout.preferredHeight: Kirigami.Units.iconSizes.large
117​ }
118​ Controls.Label {
119​ Layout.fillWidth: true
120​ text: {
121​ if (model.accountDisplayName.length > 0 && model.accountProviderName.length > 0) {
122​ return i18n("%1 (%2)", model.accountDisplayName, model.accountProviderName)
123​ } else if (model.accountDisplayName.length > 0) {
124​ return model.accountDisplayName
125​ } else {
126​ return i18n("%1 account", model.accountProviderName)
127​ }
128​ }
129​ }
130​ Controls.ToolButton {
131​ icon.name: "edit-entry"
132​ display: Controls.AbstractButton.IconOnly
133​ Layout.preferredHeight: Kirigami.Units.iconSizes.large
134​ Layout.preferredWidth: Kirigami.Units.iconSizes.large
135​ onClicked: renameAccountDlg.open();
136​ Controls.ToolTip {
137​ visible: parent.hovered && !parent.pressed
138​ text: i18nc("Button which spawns a dialog allowing the user to change the displayed account's human-readable name", "Change Account Display Name")
139​ delay: Kirigami.Units.toolTipDelay
140​ timeout: 5000
141​ y: parent.height
142​ }
143​ }
144​ }
145​
146​ footer: RowLayout {
147​ Controls.Button {
148​ Layout.alignment: Qt.AlignRight
149​ text: i18n("Remove This Account")
150​ icon.name: "edit-delete-remove"
151​ onClicked: accountRemovalDlg.open();
152​ }
153​ }
154​
155​ Kirigami.FormLayout {
156​ Layout.fillWidth: true
157​ Layout.margins: Kirigami.Units.largeSpacing
158​ Item {
159​ visible: servicesList.count === 0
160​ Layout.fillWidth: true
161​ height: Kirigami.Units.largeSpacing
162​ }
163​ Kirigami.AbstractCard {
164​ Layout.fillWidth: true
165​ visible: servicesList.count === 0
166​ header: Kirigami.Heading {
167​ text: i18nc("Heading for a box informing the user there are no configuration points in this account", "No Services")
168​ }
169​ contentItem: Controls.Label {
170​ verticalAlignment: Text.AlignVCenter
171​ horizontalAlignment: Text.AlignHCenter
172​ wrapMode: Text.Wrap
173​ text: i18nc("A text shown when an account has no configurable services", "This account has no services available for configuration")
174​ }
175​ }
176​ Kirigami.Separator {
177​ visible: servicesList.count > 0
178​ Kirigami.FormData.label: i18nc("Heading for a list of services available with this account", "Use This Account For")
179​ Kirigami.FormData.isSection: true
180​ }
181​ Repeater {
182​ id: servicesList
183​ delegate: Controls.CheckBox {
184​ id: serviceCheck
185​ Kirigami.FormData.label: model.description
186​ checked: model.enabled
187​ text: model.displayName
188​ Binding {
189​ target: serviceCheck
190​ property: "checked"
191​ value: model.enabled
192​ }
193​ onClicked: {
194​ var job = serviceToggleJob.createObject(component, { "accountId": servicesList.model.accountId, "serviceId": model.name, "serviceEnabled": !model.enabled })
195​ job.start()
196​ }
197​ }
198​ }
199​ }
200​}