Differential D2370 Diff 5854 plugins/platforms/drm/drm_backend.h

Changeset View

Standalone View

View Options

plugins/platforms/drm/drm_backend.h

Context not available.
53class UdevMonitor; 53​class UdevMonitor;
54 54​
55class DrmOutput; 55​class DrmOutput;
56​class DrmPlane;
56 57​
57 58​
58class KWIN_EXPORT DrmBackend : public Platform 59​class KWIN_EXPORT DrmBackend : public Platform
graesslinUnsubmitted
Done

nitpick: unrelated added empty line.

graesslin: nitpick: unrelated added empty line.
Context not available.
84 QVector<DrmBuffer*> buffers() const { 85​ QVector<DrmBuffer*> buffers() const {
85 return m_buffers; 86​ return m_buffers;
86 } 87​ }
88​ QVector<DrmPlane*> planes() const {
89​ return m_planes;
90​ }
87 void bufferDestroyed(DrmBuffer *b); 91​ void bufferDestroyed(DrmBuffer *b);
88 92​
89 void outputWentOff(); 93​ void outputWentOff();
90 void checkOutputsAreOn(); 94​ void checkOutputsAreOn();
91 95​
96​ // returns use of AMS, default is not/legacy
97​ bool atomicModeSetting() const {
98​ return m_atomicModeSetting;
99​ }
100​
101​
92public Q_SLOTS: 102​public Q_SLOTS:
93 void turnOutputsOn(); 103​ void turnOutputsOn();
94 104​
95 ​
graesslinUnsubmitted
Done

nitpick: unrelated removed line

graesslin: nitpick: unrelated removed line
96Q_SIGNALS: 105​Q_SIGNALS:
97 void outputRemoved(KWin::DrmOutput *output); 106​ void outputRemoved(KWin::DrmOutput *output);
98 void outputAdded(KWin::DrmOutput *output); 107​ void outputAdded(KWin::DrmOutput *output);
Context not available.
122 int m_drmId = 0; 131​ int m_drmId = 0;
123 QVector<DrmOutput*> m_outputs; 132​ QVector<DrmOutput*> m_outputs;
124 DrmBuffer *m_cursor[2]; 133​ DrmBuffer *m_cursor[2];
134​ bool m_atomicModeSetting = false;
125 bool m_cursorEnabled = false; 135​ bool m_cursorEnabled = false;
126 int m_cursorIndex = 0; 136​ int m_cursorIndex = 0;
127 int m_pageFlipsPending = 0; 137​ int m_pageFlipsPending = 0;
128 bool m_active = false; 138​ bool m_active = false;
129 QVector<DrmBuffer*> m_buffers; 139​ QVector<DrmBuffer*> m_buffers;
140​ // all available planes: primarys, cursors and overlays
141​ QVector<DrmPlane*> m_planes;
graesslinUnsubmitted
Done

for better readability I would add the comment in a dedicated line above the variable

graesslin: for better readability I would add the comment in a dedicated line above the variable
130 QScopedPointer<DpmsInputEventFilter> m_dpmsFilter; 142​ QScopedPointer<DpmsInputEventFilter> m_dpmsFilter;
131 KWayland::Server::OutputManagementInterface *m_outputManagement = nullptr; 143​ KWayland::Server::OutputManagementInterface *m_outputManagement = nullptr;
132}; 144​};
Context not available.
graesslinUnsubmitted
Done

nitpick: unrelated removed line

graesslin: nitpick: unrelated removed line