Differential D27678 Diff 76719 Tests/kstars_ui/test_ekos_simulator.cpp

Changeset View

Standalone View

View Options

Tests/kstars_ui/test_ekos_simulator.cpp

  • This file was added.
1​/* KStars UI tests
2​ Copyright (C) 2020
3​ Eric Dejouhanet <eric.dejouhanet@gmail.com>
yurchorUnsubmitted
Done

2018?

yurchor: 2018?
4​
5​ This application is free software; you can redistribute it and/or
6​ modify it under the terms of the GNU General Public
7​ License as published by the Free Software Foundation; either
8​ version 2 of the License, or (at your option) any later version.
9​ */
10​
11​#include "test_ekos_simulator.h"
12​
13​#if defined(HAVE_INDI)
14​
15​#include "kstars_ui_tests.h"
16​#include "test_ekos.h"
17​#include "ekos/manager.h"
18​#include "kstars.h"
19​#include "ksmessagebox.h"
20​
21​TestEkosSimulator::TestEkosSimulator(QObject *parent) : QObject(parent)
22​{
23​
24​}
25​
26​void TestEkosSimulator::initTestCase()
27​{
28​ KVERIFY_EKOS_IS_HIDDEN();
29​ KTRY_OPEN_EKOS();
30​ KVERIFY_EKOS_IS_OPENED();
31​ KTRY_EKOS_START_SIMULATORS();
32​
33​}
34​
35​void TestEkosSimulator::cleanupTestCase()
36​{
37​ KTRY_EKOS_STOP_SIMULATORS();
38​ KTRY_CLOSE_EKOS();
39​ KVERIFY_EKOS_IS_HIDDEN();
40​}
41​
42​void TestEkosSimulator::init()
43​{
44​
45​}
46​
47​void TestEkosSimulator::cleanup()
48​{
49​
50​}
51​
52​
53​void TestEkosSimulator::testMountSlew_data()
54​{
55​ QTest::addColumn<QString>("NAME");
56​ QTest::addColumn<QString>("RA");
57​ QTest::addColumn<QString>("DEC");
58​
59​ // Altitude computation taken from SchedulerJob::findAltitude
60​ GeoLocation * const geo = KStarsData::Instance()->geo();
61​ KStarsDateTime const now(KStarsData::Instance()->lt());
62​ KSNumbers const numbers(now.djd());
63​ CachingDms const LST = geo->GSTtoLST(geo->LTtoUT(now).gst());
64​
TallFurryManAuthorUnsubmitted
Not Done

I would expect this to use the initial conditions in KStarsUiTest, but actually Ekos resets the Simulation Clock.
What is weird is that this test fixture generation is executed *after* the first Ekos startup, so lt() should provide the updated local time.
Still, many sky objects are placed incorrectly in the sky and end below the horizon, even though altitude is tested.
So, this must be bugged. But the test manages that with an expected failure.

TallFurryMan: I would expect this to use the initial conditions in KStarsUiTest, but actually Ekos resets the…
65​ // Build a list of Messier objects, 5 degree over the horizon
66​ for (int i = 1; i < 103; i++)
67​ {
68​ QString name = QString("M %1").arg(i);
69​ SkyObject const * const so = KStars::Instance()->data()->objectNamed(name);
70​ if (so != nullptr)
71​ {
72​ SkyObject o(*so);
73​ o.updateCoordsNow(&numbers);
74​ o.EquatorialToHorizontal(&LST, geo->lat());
75​ if (5.0 < so->alt().Degrees())
76​ QTest::addRow(name.toStdString().c_str())
77​ << name
78​ << so->ra().toHMSString()
79​ << so->dec().toDMSString();
80​ }
81​ }
82​}
83​
84​void TestEkosSimulator::testMountSlew()
85​{
86​ Ekos::Manager * const ekos = Ekos::Manager::Instance();
87​
88​ QFETCH(QString, NAME);
89​ QFETCH(QString, RA);
90​ QFETCH(QString, DEC);
91​ qDebug(QString("Test slewing to '%1' RA '%2' DEC '%3'").arg(NAME).arg(RA).arg(DEC).toStdString().c_str());
92​
93​#if 0
94​ // In the mount tab, open the mount control
95​ KTRY_EKOS_CLICK("mountToolBoxB");
96​ QTextObject * raInput = Ekos::Manager::Instance()->findChild<QTextObject*>("targetRATextObject");
97​ QVERIFY(raInput != nullptr);
98​ raInput->setProperty("text", QVariant("07h 37m 30s"));
99​ QTest::qWait(1000);
100​ QTextObject * deInput = Ekos::Manager::Instance()->findChild<QTextObject*>("targetDETextObject");
101​ QVERIFY(deInput != nullptr);
102​ deInput->setProperty("text", QVariant("-14° 31' 50"));
103​ QTest::qWait(1000);
104​
105​ // Too bad, not accessible...
106​ QPushButton * gotoButton = Ekos::Manager::Instance()->findChild<QPushButton*>("");
107​
108​ QTest::qWait(5000);
109​ KTRY_EKOS_CLICK("mountToolBoxB");
110​#else
111​ QVERIFY(ekos->mountModule()->abort());
112​ // Catch the unexpected "under horizon" and the "sun is close" dialogs
TallFurryManAuthorUnsubmitted
Not Done

First, I tried to use the UI to slew to specific RA/DEC.
It appears the Mount Control box is the only one to provide a way to enter numeric values.
However, QML just doesn't provide you a gadget if that gadget miss the "objectName" property.

Also that reveals that apart from the Mount Control box, only the Scheduler is able to slew with numerical values.
The other way is to right-click on the sky map, which is not very numerical.

TallFurryMan: First, I tried to use the UI to slew to specific RA/DEC. It appears the Mount Control box is…
113​ // This will not catch the altitude security interval
114​ bool under_horizon_or_close_to_sun = false;
115​ QTimer::singleShot(1000, [&]
116​ {
117​ QDialog * const dialog = qobject_cast <QDialog*> (QApplication::activeModalWidget());
118​ if(dialog != nullptr)
119​ {
120​ under_horizon_or_close_to_sun = true;
121​ emit dialog->reject();
122​ }
123​ });
124​ bool const slew_result = ekos->mountModule()->slew(RA, DEC);
125​ if (under_horizon_or_close_to_sun)
126​ QEXPECT_FAIL(NAME.toStdString().c_str(), QString("Slew target '%1' is expected to be over the horizon during night time.").arg(NAME).toStdString().c_str(), Abort);
127​ QVERIFY(slew_result);
128​#endif
129​
TallFurryManAuthorUnsubmitted
Not Done

This block is a contrived way to bypass the notification box produced by the telescope handler...

TallFurryMan: This block is a contrived way to bypass the notification box produced by the telescope handler..
130​ // DEC slews are precise at plus/minus one arcsecond - expected or not?
131​ auto clampRA = [](QString v) { return CachingDms(v, false).arcsec(); };
132​ auto clampDE = [](QString v) { return CachingDms(v, true).arcsec(); };
133​
134​ QLineEdit * raOut = ekos->findChild<QLineEdit*>("raOUT");
135​ QVERIFY(raOut != nullptr);
136​ QTRY_VERIFY_WITH_TIMEOUT(abs(clampRA(RA) - clampRA(raOut->text())) < 2, 15000);
137​ QTest::qWait(100);
138​ if (clampRA(RA) != clampRA(raOut->text()))
TallFurryManAuthorUnsubmitted
Not Done

I had a certain number of rounding issues with the Simulator telescope, and ended up testing closeness instead of equality.
I'm not sure this is expected from the Simulator Telescope, but I know this happens with real mounts, so...

TallFurryMan: I had a certain number of rounding issues with the Simulator telescope, and ended up testing…
139​ QWARN(QString("Target '%1' slewed to with offset RA %2").arg(NAME).arg(RA).toStdString().c_str());
140​
141​ QLineEdit * deOut = Ekos::Manager::Instance()->findChild<QLineEdit*>("decOUT");
142​ QVERIFY(deOut != nullptr);
143​ QTRY_VERIFY_WITH_TIMEOUT(abs(clampDE(DEC) - clampDE(deOut->text())) < 2, 15000);
144​ QTest::qWait(100);
145​ if (clampRA(DEC) != clampRA(deOut->text()))
146​ QWARN(QString("Target '%1' slewed to with coordinate offset DEC %2").arg(NAME).arg(DEC).toStdString().c_str());
147​
148​ QVERIFY(Ekos::Manager::Instance()->mountModule()->abort());
149​}
150​
151​#endif
yurchorUnsubmitted
Not Done

Missing newline at the end.

yurchor: Missing newline at the end.