Changeset View

Standalone View

1		#pragma once
2
	hpereiradacostaUnsubmitted Done Please use garding defines rather than "pragma once" for consistency with the rest of the code. hpereiradacosta: Please use garding defines rather than "pragma once" for consistency with the rest of the code.
3		#include <QObject>
4
5		namespace Breeze {
6		class ToolsAreaManager: public QObject
7		{
8		Q_OBJECT
9
10		public:
	hpereiradacostaUnsubmitted Done Please remove the typedef. Not needed hpereiradacosta: Please remove the typedef. Not needed
11		explicit ToolsAreaManager(QObject *parent = nullptr);
12		void registerWidget(QWidget *widget);
13
14		Q_SIGNALS:
15		void toolbarUpdated();
16		};
17		}
18		No newline at end of file
	hpereiradacostaUnsubmitted Done don't put members public. Members should be private, and proper accessors/modifiers should be added. hpereiradacosta: don't put members public. Members should be private, and proper accessors/modifiers should be…
	hpereiradacostaUnsubmitted Done you don't need the default arguments. and in fact passing nullptr for helper will crash the code everywhere. hpereiradacosta: you don't need the default arguments. and in fact passing nullptr for helper will crash the…
	hpereiradacostaUnsubmitted Done Should use a QSet rather than QList. It is faster on removal and contain check. Should also use const QWidget* as a contained object to avoid unnecessary need for const_caast hpereiradacosta: Should use a QSet rather than QList. It is faster on removal and contain check. Should also…