Changeset View
Standalone View
kstyle/breeze.h
Show First 20 Lines • Show All 95 Lines • ▼ Show 20 Line(s) | 44 | { | |||
---|---|---|---|---|---|
96 | ScrollBar_Extend = 21, | 96 | ScrollBar_Extend = 21, | ||
97 | ScrollBar_SliderWidth = 6, | 97 | ScrollBar_SliderWidth = 6, | ||
98 | ScrollBar_MinSliderHeight = 20, | 98 | ScrollBar_MinSliderHeight = 20, | ||
99 | ScrollBar_NoButtonHeight = (ScrollBar_Extend-ScrollBar_SliderWidth)/2, | 99 | ScrollBar_NoButtonHeight = (ScrollBar_Extend-ScrollBar_SliderWidth)/2, | ||
100 | ScrollBar_SingleButtonHeight = ScrollBar_Extend, | 100 | ScrollBar_SingleButtonHeight = ScrollBar_Extend, | ||
101 | ScrollBar_DoubleButtonHeight = 2*ScrollBar_Extend, | 101 | ScrollBar_DoubleButtonHeight = 2*ScrollBar_Extend, | ||
102 | 102 | | |||
103 | // toolbars | 103 | // toolbars | ||
104 | ToolBar_FrameWidth = 2, | 104 | ToolBar_FrameWidth = 6, | ||
hpereiradacosta: This change seems unrelated to introducing a tool area.
I would move it to a separate commit… | |||||
This is part of the visual changes of the tools area design—extra spacing as to prevent ugly border on border action. cblack: This is part of the visual changes of the tools area design—extra spacing as to prevent ugly… | |||||
Why would this be more "ugly" as when there was no toolarea ? can you post a screeshot of the said ugliness ? hpereiradacosta: Why would this be more "ugly" as when there was no toolarea ? can you post a screeshot of the… | |||||
cblack: With: {F8185479}
Without: {F8185480} | |||||
Hi,
Second, it affects all sides, whereas only the bottom one needs changed. If you insist on changing the margins on all toolbars, all sides, disregarding their location and disregarding whether the effect is enabled or not, then this is a change orthogonal (and of much broader scope) to this patch and must go to a different commit. hpereiradacosta: Hi,
thanks for posting the screenshots. If I understand right this is really an issue with the… | |||||
Sorry for the many postings, I had another unrelated comment on these screeshot: hpereiradacosta: Sorry for the many postings, I had another unrelated comment on these screeshot:
I find it… | |||||
The tools area's separator has to separate two large areas of the window and thus should be stronger than the separators that only have to separate borderless and backgroundless buttons. cblack: The tools area's separator has to separate two large areas of the window and thus should be… | |||||
As I said, to me at least it does not look so good in the two screenshots you posted above. hpereiradacosta: As I said, to me at least it does not look so good in the two screenshots you posted above.
In… | |||||
Is that the reason why the toolbar moves down and to the left? If so it seems not to do your intended effect. I agree with Hugo regardless that this is an unrelated change davidre: Is that the reason why the toolbar moves down and to the left? If so it seems not to do your… | |||||
105 | ToolBar_HandleExtent = 10, | 105 | ToolBar_HandleExtent = 10, | ||
106 | ToolBar_HandleWidth = 6, | 106 | ToolBar_HandleWidth = 6, | ||
107 | ToolBar_SeparatorWidth = 8, | 107 | ToolBar_SeparatorWidth = 8, | ||
108 | ToolBar_ExtensionWidth = 20, | 108 | ToolBar_ExtensionWidth = 20, | ||
109 | ToolBar_ItemSpacing = 0, | 109 | ToolBar_ItemSpacing = 0, | ||
110 | 110 | | |||
111 | // progressbars | 111 | // progressbars | ||
112 | ProgressBar_BusyIndicatorSize = 14, | 112 | ProgressBar_BusyIndicatorSize = 14, | ||
▲ Show 20 Lines • Show All 69 Lines • ▼ Show 20 Line(s) | |||||
182 | 182 | | |||
183 | //* animation mode | 183 | //* animation mode | ||
184 | enum AnimationMode | 184 | enum AnimationMode | ||
185 | { | 185 | { | ||
186 | AnimationNone = 0, | 186 | AnimationNone = 0, | ||
187 | AnimationHover = 0x1, | 187 | AnimationHover = 0x1, | ||
188 | AnimationFocus = 0x2, | 188 | AnimationFocus = 0x2, | ||
189 | AnimationEnable = 0x4, | 189 | AnimationEnable = 0x4, | ||
190 | AnimationPressed = 0x8 | 190 | AnimationPressed = 0x8, | ||
191 | AnimationWindowFocused = 0x10, | ||||
Sorry for the many postings. hpereiradacosta: Sorry for the many postings.
As far as I can tell this guy is used nowhere. Please remove. | |||||
191 | }; | 192 | }; | ||
192 | 193 | | |||
193 | Q_DECLARE_FLAGS(AnimationModes, AnimationMode) | 194 | Q_DECLARE_FLAGS(AnimationModes, AnimationMode) | ||
194 | 195 | | |||
195 | //* corners | 196 | //* corners | ||
196 | enum Corner | 197 | enum Corner | ||
197 | { | 198 | { | ||
198 | CornerTopLeft = 0x1, | 199 | CornerTopLeft = 0x1, | ||
▲ Show 20 Lines • Show All 68 Lines • Show Last 20 Lines |
This change seems unrelated to introducing a tool area.
I would move it to a separate commit and review request. In fact there are already complains about there being too much space wasted in breeze. These extra 4 pixels don't go in the right direction (and again: are not needed for this patch as far as I can tell)