Differential D27682 Diff 76523 kcmkwin/kwinrules/rulesettingsmanager.h

Changeset View

Standalone View

View Options

kcmkwin/kwinrules/rulesettingsmanager.h

  • This file was added.
1​#ifndef RULESSETTINGSLIST_H
2​#define RULESSETTINGSLIST_H
zzagUnsubmitted
Not Done

Please add a copyright header.

zzag: Please add a copyright header.
ervinUnsubmitted
Not Done

Looks like those include guards should be changed to match the filename, and please rename that to rulesettings.h (+ rulesettings.cpp) of course.

ervin: Looks like those include guards should be changed to match the filename, and please rename that…
zzagUnsubmitted
Not Done

FWIW, we (KWin devs) are okay with using #pragma once.

zzag: FWIW, we (KWin devs) are okay with using `#pragma once`.
ervinUnsubmitted
Not Done

So that's an option I guess.

ervin: So that's an option I guess.
3​
4​#include "rulesettings.h"
5​#include <KSharedConfig>
ervinUnsubmitted
Not Done

Will become rulesettingsbase.h

ervin: Will become rulesettingsbase.h
6​
7​namespace KWin
8​{
9​class Rules;
10​// class RuleSettings;
11​
ervinUnsubmitted
Not Done

Please remove this

ervin: Please remove this
12​class RuleSettingsManager : public RuleSettings
13​{
ervinUnsubmitted
Not Done

Rename RuleSettingsManager to RuleSettings

Note that I find this design looks odd (I suspect it tries to conflate two things which should perhaps be separated). So its a RuleSettings which contains more RuleSettings? How is the user code supposed to decide where to store? Also those RuleSettings are not accessible from the outside but it goes through a list of "Rules"? Is it me or this class only uses count()? This is incredibly meddled (of course I understand the area is muddy already ;-)).

Disclaimer: All the renaming I propose is based on the assumption this inheritance doesn't change, if we decide later on to change it all my comments renaming RuleSettings to RuleSettingsBase might not apply anymore.

ervin: Rename RuleSettingsManager to RuleSettings Note that I find this design looks odd (I suspect…
14​public:
15​ RuleSettingsManager(KSharedConfig::Ptr config, QObject *parent = nullptr);
16​ RuleSettingsManager(const QString &configname, KConfig::OpenFlags, QObject *parent = nullptr);
17​ RuleSettingsManager(KConfig::OpenFlags, QObject *parent = nullptr);
18​ RuleSettingsManager(QObject *parent = nullptr);
19​ void saveAllFrom(const QVector<Rules *> &);
20​ void loadAllInto(QVector<Rules *> &);
21​
22​private:
23​ QVector<RuleSettings *> m_list;
24​};
25​
26​}
27​
28​#endif // RULESSETTINGSLIST_H