Changeset View
Standalone View
src/core/kcoreconfigskeleton.h
| Show First 20 Lines • Show All 755 Lines • ▼ Show 20 Line(s) | 751 | #endif | |||
|---|---|---|---|---|---|
| 756 | class KCONFIGCORE_EXPORT ItemEnum: public ItemInt | 756 | class KCONFIGCORE_EXPORT ItemEnum: public ItemInt | ||
| 757 | { | 757 | { | ||
| 758 | public: | 758 | public: | ||
| 759 | struct Choice { | 759 | struct Choice { | ||
| 760 | QString name; | 760 | QString name; | ||
| 761 | QString label; | 761 | QString label; | ||
| 762 | QString toolTip; | 762 | QString toolTip; | ||
| 763 | QString whatsThis; | 763 | QString whatsThis; | ||
| 764 | QString val; | ||||
meven: Something I have noticed while testing this.
Since it changes the memory of a very common data… | |||||
Oh right, stupid me, this obviously breaks binary compatibility, we need to find another way to store this. ervin: Oh right, stupid me, this obviously breaks binary compatibility, we need to find another way to… | |||||
Most likely place to hide it would be inside KConfigSkeletonItem's d-pointer (likely a hash associating vals with names)... it'd be unused by most item types of course which sucks but at least it'd be safe BC wise. ervin: Most likely place to hide it would be inside KConfigSkeletonItem's d-pointer (likely a hash… | |||||
| 765 | | ||||
| 766 | QString value() const; | ||||
ervin: It's a struct you can drop the public: here. | |||||
| 764 | }; | 767 | }; | ||
There should be a new line before the opening curly brace. I also wonder if it wouldn't be better with the implementation being moved to the cpp file, otherwise it risks being inlined which might not be the most convenient for longer term management of the change (if for some reason the implementation needs to be changed). ervin: There should be a new line before the opening curly brace.
I also wonder if it wouldn't be… | |||||
| 765 | 768 | | |||
| 766 | /** @copydoc KConfigSkeletonGenericItem::KConfigSkeletonGenericItem | 769 | /** @copydoc KConfigSkeletonGenericItem::KConfigSkeletonGenericItem | ||
| 767 | @param choices The list of enums that can be stored in this item | 770 | @param choices The list of enums that can be stored in this item | ||
| 768 | */ | 771 | */ | ||
| 769 | ItemEnum(const QString &_group, const QString &_key, qint32 &reference, | 772 | ItemEnum(const QString &_group, const QString &_key, qint32 &reference, | ||
| 770 | const QList<Choice> &choices, qint32 defaultValue = 0); | 773 | const QList<Choice> &choices, qint32 defaultValue = 0); | ||
| 771 | 774 | | |||
| 772 | QList<Choice> choices() const; | 775 | QList<Choice> choices() const; | ||
| 773 | 776 | | |||
| 774 | /** @copydoc KConfigSkeletonItem::readConfig(KConfig*) */ | 777 | /** @copydoc KConfigSkeletonItem::readConfig(KConfig*) */ | ||
| 775 | void readConfig(KConfig *config) override; | 778 | void readConfig(KConfig *config) override; | ||
| 776 | 779 | | |||
| 777 | /** @copydoc KConfigSkeletonItem::writeConfig(KConfig*) */ | 780 | /** @copydoc KConfigSkeletonItem::writeConfig(KConfig*) */ | ||
| 778 | void writeConfig(KConfig *config) override; | 781 | void writeConfig(KConfig *config) override; | ||
| 779 | 782 | | |||
| 780 | // Source compatibility with 4.x | 783 | // Source compatibility with 4.x | ||
| 781 | typedef Choice Choice2; | 784 | typedef Choice Choice2; | ||
| 782 | QList<Choice> choices2() const; | 785 | QList<Choice> choices2() const; | ||
| 783 | 786 | | |||
| 784 | private: | 787 | private: | ||
| 785 | QList<Choice> mChoices; | 788 | QList<Choice> mChoices; | ||
| 786 | }; | 789 | }; | ||
Nope, can't be here, this still breaks binary compatibility. As I mentioned in my last comment it should be buried all the way into the d-pointer inherited from KConfigSkeletonItem... This is inefficient in term of memory load but it's the only option to keep BC. ervin: Nope, can't be here, this still breaks binary compatibility. As I mentioned in my last comment… | |||||
| 787 | 790 | | |||
const QString &name Probably worth adding a KF6 comment somewhere as well, because your first attempt felt more natural, we're going for this weird construct only for BC concerns. ervin: const QString &name
Probably worth adding a KF6 comment somewhere as well, because your first… | |||||
I have one in QString KCoreConfigSkeleton::ItemEnum::valueForChoice(QString name) const meven: I have one in `QString KCoreConfigSkeleton::ItemEnum::valueForChoice(QString name) const` | |||||
Yeah, noticed only later... I wonder if it's more obvious in the header or the cpp... ervin: Yeah, noticed only later... I wonder if it's more obvious in the header or the cpp... | |||||
I expect those to be found through grep, and I had comments in the past to put it somewhere where it could not get in documentation, in cpp guarantees this. meven: I expect those to be found through grep, and I had comments in the past to put it somewhere… | |||||
Well, regular comments don't go in the docs ;-) But cpp, why not. ervin: Well, regular comments don't go in the docs ;-)
(you need the triple slash or the double start… | |||||
| 788 | /** | 791 | /** | ||
| 789 | * Class for handling an unsigned 32-bit integer preferences item. | 792 | * Class for handling an unsigned 32-bit integer preferences item. | ||
| 790 | */ | 793 | */ | ||
| 791 | class KCONFIGCORE_EXPORT ItemUInt: public KConfigSkeletonGenericItem < quint32 > | 794 | class KCONFIGCORE_EXPORT ItemUInt: public KConfigSkeletonGenericItem < quint32 > | ||
| 792 | { | 795 | { | ||
ervin: const ref for the parameters | |||||
| 793 | public: | 796 | public: | ||
| 794 | /** @copydoc KConfigSkeletonGenericItem::KConfigSkeletonGenericItem */ | 797 | /** @copydoc KConfigSkeletonGenericItem::KConfigSkeletonGenericItem */ | ||
| 795 | ItemUInt(const QString &_group, const QString &_key, | 798 | ItemUInt(const QString &_group, const QString &_key, | ||
| 796 | quint32 &reference, quint32 defaultValue = 0); | 799 | quint32 &reference, quint32 defaultValue = 0); | ||
| 797 | 800 | | |||
| 798 | /** @copydoc KConfigSkeletonItem::readConfig(KConfig*) */ | 801 | /** @copydoc KConfigSkeletonItem::readConfig(KConfig*) */ | ||
| 799 | void readConfig(KConfig *config) override; | 802 | void readConfig(KConfig *config) override; | ||
| 800 | 803 | | |||
| ▲ Show 20 Lines • Show All 814 Lines • Show Last 20 Lines | |||||
Something I have noticed while testing this.
Since it changes the memory of a very common data struct in a very common lib, it creates a lot of crashes if apps are not compiled with the installed version.
So all local builds should be rebuild or reinstalled, once this has landed, or you end up with a lot of crashes.