Changeset View
Changeset View
Standalone View
Standalone View
src/Gui/SettingsDialog/GeneralOptionsPage.h
Show All 16 Lines | |||||
17 | * Boston, MA 02110-1301, USA. | 17 | * Boston, MA 02110-1301, USA. | ||
18 | */ | 18 | */ | ||
19 | 19 | | |||
20 | #ifndef GENERALOPTIONSPAGE_H | 20 | #ifndef GENERALOPTIONSPAGE_H | ||
21 | #define GENERALOPTIONSPAGE_H | 21 | #define GENERALOPTIONSPAGE_H | ||
22 | 22 | | |||
23 | #include <QWidget> | 23 | #include <QWidget> | ||
24 | 24 | | |||
25 | class Ui_GeneralOptions; | ||||
26 | | ||||
25 | class GeneralOptionsPage : public QWidget | 27 | class GeneralOptionsPage : public QWidget | ||
26 | { | 28 | { | ||
27 | Q_OBJECT | 29 | Q_OBJECT | ||
28 | 30 | | |||
29 | public: | 31 | public: | ||
30 | 32 | | |||
31 | explicit GeneralOptionsPage(QWidget *parent = nullptr); | 33 | explicit GeneralOptionsPage(QWidget *parent = nullptr); | ||
34 | ~GeneralOptionsPage() override; | ||||
ervin: Nitpick, feel free to ignore: you can spare this if you go for using QScopedPointer in m_ui | |||||
davidre: How would I do that with an incomplete type? | |||||
Oh right, QScopedPointer needs the type to be complete... Well you could at least use "= default" in the cpp for the dtor. So it'd still be declared but you wouldn't have to bother providing an implementation yourself. ervin: Oh right, QScopedPointer needs the type to be complete... Well you could at least use "=… | |||||
davidre: Does that free *m_ui? | |||||
Well, if it's a QScopedPointer yes. ;-) This avoids the problem with incomplete types you mentioned earlier. ervin: Well, if it's a QScopedPointer yes. ;-)
This avoids the problem with incomplete types you… | |||||
35 | | ||||
36 | private: | ||||
37 | | ||||
38 | Ui_GeneralOptions *m_ui; | ||||
32 | }; | 39 | }; | ||
33 | 40 | | |||
34 | #endif // GENERALOPTIONSPAGE_H | 41 | #endif // GENERALOPTIONSPAGE_H |
Nitpick, feel free to ignore: you can spare this if you go for using QScopedPointer in m_ui