Changeset View
Changeset View
Standalone View
Standalone View
kate/session/katesessionchooseritem.h
| Show All 29 Lines | |||||
| 30 | public: | 30 | public: | ||
| 31 | KateSessionChooserItem(QTreeWidget *tw, KateSession::Ptr s) | 31 | KateSessionChooserItem(QTreeWidget *tw, KateSession::Ptr s) | ||
| 32 | : QTreeWidgetItem(tw, QStringList(s->name())) | 32 | : QTreeWidgetItem(tw, QStringList(s->name())) | ||
| 33 | , session(s) | 33 | , session(s) | ||
| 34 | { | 34 | { | ||
| 35 | QString docs; | 35 | QString docs; | ||
| 36 | docs.setNum(s->documents()); | 36 | docs.setNum(s->documents()); | ||
| 37 | setText(1, docs); | 37 | setText(1, docs); | ||
| 38 | setText(2, s->timestamp().toString(QString::fromStdString("yyyy-MM-dd hh:mm:ss"))); | ||||
dhaumann: I believe that seconds are a bit over engineered. In fact, it would be nice to do the sorting… | |||||
| 38 | } | 39 | } | ||
| 39 | 40 | | |||
| 40 | KateSession::Ptr session; | 41 | KateSession::Ptr session; | ||
| 41 | }; | 42 | }; | ||
| 42 | 43 | | |||
| 43 | #endif | 44 | #endif | ||
I believe that seconds are a bit over engineered. In fact, it would be nice to do the sorting based on the timestamp as now, but visually the English format does not fit very well in other languages. So this should be translated via i18n. But then we loose the correct sorting.
So for now this patch is ok, but in the long run we should do better.
For instance, I think it would be much more user friendly to have "Yesterday", "3 days ago", ... instead of the datetime right now.
Would you be interested to look into this as well?