Differential D27166 Diff 75359 runners/converter/converterrunner.h

Changeset View

Standalone View

View Options

runners/converter/converterrunner.h

1/* 1​/*
2 * Copyright (C) 2007,2008 Petri Damstén <damu@iki.fi> 2​ * Copyright (C) 2007,2008 Petri Damstén <damu@iki.fi>
3​ * Copyright (C) 2020 Alexander Lohnau <alexander.lohnau@gmx.de>
3 * 4​ *
4 * This program is free software; you can redistribute it and/or 5​ * This program is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU General Public License as 6​ * modify it under the terms of the GNU General Public License as
6 * published by the Free Software Foundation; either version 2 of 7​ * published by the Free Software Foundation; either version 2 of
7 * the License, or (at your option) any later version. 8​ * the License, or (at your option) any later version.
8 * 9​ *
9 * This program is distributed in the hope that it will be useful, 10​ * This program is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 11​ * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 12​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 13​ * GNU General Public License for more details.
13 * 14​ *
14 * You should have received a copy of the GNU General Public License 15​ * You should have received a copy of the GNU General Public License
15 * along with this program. If not, see <http://www.gnu.org/licenses/>. 16​ * along with this program. If not, see <http://www.gnu.org/licenses/>.
16 */ 17​ */
17 18​
18#ifndef CONVERTERRUNNER_H 19​#ifndef CONVERTERRUNNER_H
19#define CONVERTERRUNNER_H 20​#define CONVERTERRUNNER_H
20 21​
21#include <krunner/abstractrunner.h> 22​#include <KRunner/AbstractRunner>
23​#include <QRegularExpression>
24​#include <QLocale>
25​#include <KUnitConversion/Converter>
26​#include <KUnitConversion/UnitCategory>
27​
22 28​
23/** 29​/**
24 * This class converts values to different units. 30​ * This class converts values to different units.
25 */ 31​ */
26class ConverterRunner : public Plasma::AbstractRunner 32​class ConverterRunner: public Plasma::AbstractRunner
27{ 33​{
28Q_OBJECT 34​Q_OBJECT
29 35​
30public: 36​public:
31 ConverterRunner(QObject* parent, const QVariantList &args); 37​ ConverterRunner(QObject *parent, const QVariantList &args);
32 ~ConverterRunner() override; 38​ ~ConverterRunner() override;
33 39​
34 void match(Plasma::RunnerContext &context) override; 40​ void match(Plasma::RunnerContext &context) override;
35 void run(const Plasma::RunnerContext &context, const Plasma::QueryMatch &match) override; 41​ void run(const Plasma::RunnerContext &context, const Plasma::QueryMatch &match) override;
36 42​
37private: 43​private:
38 QStringList m_separators; 44​ QStringList m_separators;
45​ KUnitConversion::Converter converter;
46​ const QLocale locale;
47​ QRegularExpression matchRegex;
48​
49​ QPair<bool, double> stringToDouble(const QStringRef &value);
sitterUnsubmitted
Done

stringToDouble and getValidatedNumberValue seem to have conflicting ideas of api design. either both should use the pair return or both should use the ok pointer.

sitter: stringToDouble and getValidatedNumberValue seem to have conflicting ideas of api design. either…
50​ QPair<bool, double> getValidatedNumberValue(const QString &value);
51​ QList<KUnitConversion::Unit> createResultUnits(const QString &outputUnitString,
sitterUnsubmitted
Done

Please use multiple lines to declare multiple members, even when they have the same type. Same line declaration is unnecessarily increasing reading complexity.

sitter: Please use multiple lines to declare multiple members, even when they have the same type. Same…
52​ const KUnitConversion::UnitCategory &category);
39}; 53​};
40 54​
41#endif 55​#endif