Differential D27061 Diff 75170 Modules/samba/smbmountmodel.cpp

Changeset View

Standalone View

View Options

Modules/samba/smbmountmodel.cpp

  • This file was added.
1​/*
2​ SPDX-FileCopyrightText: 2020 Harald Sitter <sitter@kde.org>
3​ SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL
4​*/
5​
6​#include "smbmountmodel.h"
7​
8​#include <QIcon>
9​#include <KLocalizedString>
10​#include <Solid/Device>
11​#include <Solid/DeviceInterface>
12​#include <Solid/DeviceNotifier>
13​#include <Solid/NetworkShare>
14​#include <Solid/StorageAccess>
15​
16​SmbMountModel::SmbMountModel(QObject *parent)
17​ : QAbstractListModel(parent)
18​{
19​ connect(Solid::DeviceNotifier::instance(), &Solid::DeviceNotifier::deviceAdded,
20​ this, &SmbMountModel::addDevice);
21​ connect(Solid::DeviceNotifier::instance(), &Solid::DeviceNotifier::deviceRemoved,
22​ this, &SmbMountModel::removeDevice);
23​ reloadData();
24​}
25​
26​SmbMountModel::~SmbMountModel() = default;
27​
28​int SmbMountModel::rowCount(const QModelIndex &parent) const
29​{
30​ Q_UNUSED(parent)
31​ return m_devices.size();
32​}
33​
34​int SmbMountModel::columnCount(const QModelIndex &parent) const
35​{
36​ Q_UNUSED(parent)
37​ return static_cast<int>(ColumnRole::ColumnCount);
38​}
39​
40​QVariant SmbMountModel::headerData(int section, Qt::Orientation orientation, int role) const
41​{
42​ if (orientation != Qt::Horizontal || role != Qt::DisplayRole) {
43​ return {}; // we only have column headers.
44​ }
45​
46​ Q_ASSERT(section < static_cast<int>(ColumnRole::ColumnCount));
47​ switch (static_cast<ColumnRole>(section)) {
48​ case ColumnRole::Share:
49​ return i18n("Resource"); // TODO: maybe reword for 5.19
50​ case ColumnRole::Path:
51​ return i18n("Mounted Under"); // TODO: maybe reword for 5.19
52​ case ColumnRole::Accessible:
53​ return i18nc("@title:column whether a samba share is accessible locally (i.e. mounted)", "Accessible");
54​ case ColumnRole::ColumnCount:
yurchorUnsubmitted
Not Done

Typo: sama -> samba

yurchor: Typo: sama -> samba
55​ break; // noop
56​ }
57​
58​ return {};
59​}
60​
61​QVariant SmbMountModel::data(const QModelIndex &index, int role) const
62​{
63​ if (!index.isValid()) {
64​ return {};
65​ }
66​
67​ Q_ASSERT(index.row() < m_devices.count());
68​ Q_ASSERT(index.column() < static_cast<int>(ColumnRole::ColumnCount));
69​
70​ if (role == Qt::DisplayRole) {
71​ switch (static_cast<ColumnRole>(index.column())) {
72​ case ColumnRole::Share:
73​ return m_devices.at(index.row()).as<Solid::NetworkShare>()->url();
74​ case ColumnRole::Path:
davidedmundsonUnsubmitted
Not Done

This looks dangerous.

You always add row indexes to the end, but you're taking an index of map.values() for the source.

Qmap::values retains order within entires, but the whole list is not ordered by global insertion time.

i.e If you call addDevice it could insert in the middle of what .values returns even though from a model pov you've said it's at the end. This will break a UI.

davidedmundson: This looks dangerous. You always add row indexes to the end, but you're taking an index of map.
75​ return m_devices.at(index.row()).as<Solid::StorageAccess>()->filePath();
76​ case ColumnRole::Accessible:
77​ break; // Decoration only
78​ case ColumnRole::ColumnCount:
79​ break; // noop
80​ }
81​ }
82​
83​ if (role == Qt::DecorationRole) {
84​ switch (static_cast<ColumnRole>(index.column())) {
85​ case ColumnRole::Accessible:
86​ // Using characters here since we use a QTableView and can't just
87​ return m_devices.at(index.row()).as<Solid::StorageAccess>()->isAccessible()
88​ ? QIcon::fromTheme("dialog-ok")
89​ : QIcon::fromTheme("dialog-cancel");
90​ case ColumnRole::Share:
91​ case ColumnRole::Path:
92​ break; // Display only
93​ case ColumnRole::ColumnCount:
94​ break; // noop
95​ }
96​ }
97​
98​ return {};
99​}
100​
101​void SmbMountModel::addDevice(const QString &udi)
102​{
103​ auto it = deviceForUdi(udi);
104​ if (it != m_devices.constEnd()) {
105​ return; // already in the list
106​ }
107​
108​ beginInsertRows(QModelIndex(), m_devices.count(), m_devices.count());
109​ m_devices.append(Solid::Device(udi));
110​ endInsertRows();
111​}
112​
113​void SmbMountModel::removeDevice(const QString &udi)
114​{
115​ auto it = deviceForUdi(udi);
116​ if (it == m_devices.constEnd()) {
117​ return; // untracked udi
118​ }
119​
120​ const int index = static_cast<int>(std::distance(m_devices.constBegin(), it));
121​ beginRemoveRows(QModelIndex(), index, index);
122​ m_devices.removeAt(index);
123​ endRemoveRows();
124​}
125​
126​void SmbMountModel::reloadData()
127​{
128​ beginResetModel();
129​ m_devices.clear();
130​ const auto devices = Solid::Device::listFromType(Solid::DeviceInterface::NetworkShare);
131​ for (auto it = devices.begin(); it != devices.end(); ++it) {
132​ switch (it->as<Solid::NetworkShare>()->type()) {
133​ case Solid::NetworkShare::Cifs:
134​ m_devices.append(*it);
135​ continue;
136​ case Solid::NetworkShare::Nfs:
137​ case Solid::NetworkShare::Unknown:
138​ continue;
139​ }
140​ }
141​ endResetModel();
142​}
143​
144​bool SmbMountModel::hasChildren(const QModelIndex &parent) const
145​{
146​ return !parent.isValid() ? false : (rowCount(parent) > 0);
147​}