Differential D27061 Diff 74762 Modules/samba/smbmountmodel.cpp

Changeset View

Standalone View

View Options

Modules/samba/smbmountmodel.cpp

  • This file was added.
1​/*
2​ SPDX-FileCopyrightText: 2020 Harald Sitter <sitter@kde.org>
3​ SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL
4​*/
5​
6​#include "smbmountmodel.h"
7​
8​#include <KLocalizedString>
9​#include <Solid/Device>
10​#include <Solid/DeviceInterface>
11​#include <Solid/DeviceNotifier>
12​#include <Solid/NetworkShare>
13​#include <Solid/StorageAccess>
14​
15​SmbMountModel::SmbMountModel(QObject *parent)
16​ : QAbstractListModel(parent)
17​{
18​ connect(Solid::DeviceNotifier::instance(), &Solid::DeviceNotifier::deviceAdded,
19​ this, &SmbMountModel::addDevice);
20​ connect(Solid::DeviceNotifier::instance(), &Solid::DeviceNotifier::deviceRemoved,
21​ this, &SmbMountModel::removeDevice);
22​ reloadData();
23​}
24​
25​SmbMountModel::~SmbMountModel() = default;
26​
27​int SmbMountModel::rowCount(const QModelIndex &parent) const
28​{
29​ Q_UNUSED(parent)
30​ return devices().size();
31​}
32​
33​int SmbMountModel::columnCount(const QModelIndex &parent) const
34​{
35​ Q_UNUSED(parent)
36​ return static_cast<int>(ColumnRole::ColumnCount);
37​}
38​
39​QVariant SmbMountModel::headerData(int section, Qt::Orientation orientation, int role) const
40​{
41​ if (orientation != Qt::Horizontal || role != Qt::DisplayRole) {
42​ return {}; // we only have column headers.
43​ }
44​
45​ Q_ASSERT(section < static_cast<int>(ColumnRole::ColumnCount));
46​ switch (static_cast<ColumnRole>(section)) {
47​ case ColumnRole::Share:
48​ return i18n("Resource"); // TODO: maybe reword for 5.19
49​ case ColumnRole::Path:
50​ return i18n("Mounted Under"); // TODO: maybe reword for 5.19
51​ case ColumnRole::Accessible:
52​ return i18nc("@title:column whether a sama share is accessible locally (i.e. mounted)", "Accessible");
53​ case ColumnRole::ColumnCount:
54​ break; // noop
yurchorUnsubmitted
Not Done

Typo: sama -> samba

yurchor: Typo: sama -> samba
55​ }
56​
57​ return {};
58​}
59​
60​QVariant SmbMountModel::data(const QModelIndex &index, int role) const
61​{
62​ if (!index.isValid()) {
63​ return {};
64​ }
65​
66​ Q_ASSERT(index.row() < m_uidDeviceMap.count());
67​ Q_ASSERT(index.column() < static_cast<int>(ColumnRole::ColumnCount));
68​ if (role == Qt::DisplayRole) {
69​ switch (static_cast<ColumnRole>(index.column())) {
70​ case ColumnRole::Share:
71​ return devices().at(index.row()).as<Solid::NetworkShare>()->url();
72​ case ColumnRole::Path:
73​ return devices().at(index.row()).as<Solid::StorageAccess>()->filePath();
74​ case ColumnRole::Accessible:
davidedmundsonUnsubmitted
Not Done

This looks dangerous.

You always add row indexes to the end, but you're taking an index of map.values() for the source.

Qmap::values retains order within entires, but the whole list is not ordered by global insertion time.

i.e If you call addDevice it could insert in the middle of what .values returns even though from a model pov you've said it's at the end. This will break a UI.

davidedmundson: This looks dangerous. You always add row indexes to the end, but you're taking an index of map.
75​ return devices().at(index.row()).as<Solid::StorageAccess>()->isAccessible();
76​ case ColumnRole::ColumnCount:
77​ break; // noop
78​ }
79​ }
80​
81​ return {};
82​}
83​
84​void SmbMountModel::addDevice(const QString &udi)
85​{
86​ const Solid::Device device(udi);
87​ if (m_uidDeviceMap.contains(udi) || !device.is<Solid::NetworkShare>()) {
88​ return;
89​ }
90​ beginInsertRows(QModelIndex(), m_uidDeviceMap.count(), m_uidDeviceMap.count());
91​ m_uidDeviceMap[udi] = device;
92​ endInsertRows();
93​}
94​
95​void SmbMountModel::removeDevice(const QString &udi)
96​{
97​ auto it = std::find_if(m_uidDeviceMap.begin(),
98​ m_uidDeviceMap.end(),
99​ [&udi](const Solid::Device &device) {
100​ return device.udi() == udi;
101​ });
102​
103​ if (it == m_uidDeviceMap.constEnd()) {
104​ return;
105​ }
106​
107​ int index = static_cast<int>(std::distance(m_uidDeviceMap.begin(), it));
108​
109​ beginRemoveRows(QModelIndex(), index, index);
110​ m_uidDeviceMap.erase(it);
111​ endRemoveRows();
112​}
113​
114​void SmbMountModel::reloadData()
115​{
116​ beginResetModel();
117​ m_uidDeviceMap.clear();
118​ const auto devices = Solid::Device::listFromType(Solid::DeviceInterface::NetworkShare);
119​ for (auto it = devices.begin(); it != devices.end(); ++it) {
120​ switch (it->as<Solid::NetworkShare>()->type()) {
121​ case Solid::NetworkShare::Cifs:
122​ m_uidDeviceMap[it->udi()] = *it;
123​ continue;
124​ case Solid::NetworkShare::Nfs:
125​ case Solid::NetworkShare::Unknown:
126​ continue;
127​ }
128​ }
129​ endResetModel();
130​}
131​
132​bool SmbMountModel::hasChildren(const QModelIndex &parent) const
133​{
134​ return !parent.isValid() ? false : (rowCount(parent) > 0);
135​}