Changeset View
Changeset View
Standalone View
Standalone View
kded/gtkconfig.cpp
Show First 20 Lines • Show All 198 Lines • ▼ Show 20 Line(s) | 196 | { | |||
---|---|---|---|---|---|
199 | setCursorTheme(); | 199 | setCursorTheme(); | ||
200 | setIconsOnButtons(); | 200 | setIconsOnButtons(); | ||
201 | setIconsInMenus(); | 201 | setIconsInMenus(); | ||
202 | setToolbarStyle(); | 202 | setToolbarStyle(); | ||
203 | setScrollbarBehavior(); | 203 | setScrollbarBehavior(); | ||
204 | setDarkThemePreference(); | 204 | setDarkThemePreference(); | ||
205 | setWindowDecorationsButtonsOrder(); | 205 | setWindowDecorationsButtonsOrder(); | ||
206 | setEnableAnimations(); | 206 | setEnableAnimations(); | ||
207 | setDefaultGtk2Theme(); | ||||
fvogt: Now those two aren't needed anymore? | |||||
Hm, yeah. Actually I think it is redundant to replace theme configuration on each start. It would make sense, if it was about syncing the settings, but since GTK theme is set directly by App Style KCM, I see no reason. gikari: Hm, yeah. Actually I think it is redundant to replace theme configuration on each start. It… | |||||
208 | setDefaultGtk3Theme(); | ||||
209 | } | ||||
210 | | ||||
211 | void GtkConfig::setDefaultGtk2Theme() const | ||||
212 | { | ||||
213 | const QString currentGtk2Theme = gtk2Theme(); | ||||
214 | if (currentGtk2Theme.isEmpty()) { | ||||
215 | setGtk2Theme(QStringLiteral("Breeze")); | ||||
What if users have a different default / theme set on first launch ? meven: What if users have a different default / theme set on first launch ?
I would suggest to read… | |||||
gikari: Where can I read the default value from? | |||||
216 | } | ||||
217 | } | ||||
218 | | ||||
219 | void GtkConfig::setDefaultGtk3Theme() const | ||||
220 | { | ||||
221 | const QString currentGtk3Theme = gtk3Theme(); | ||||
222 | if (currentGtk3Theme.isEmpty()) { | ||||
223 | setGtk3Theme(QStringLiteral("Breeze")); | ||||
224 | } | ||||
207 | } | 225 | } | ||
208 | 226 | | |||
209 | void GtkConfig::onGlobalSettingsChange(int settingsChangeType, int arg) const | 227 | void GtkConfig::onGlobalSettingsChange(int settingsChangeType, int arg) const | ||
210 | { | 228 | { | ||
211 | SettingsChangeType changeType = static_cast<SettingsChangeType>(settingsChangeType); | 229 | SettingsChangeType changeType = static_cast<SettingsChangeType>(settingsChangeType); | ||
212 | SettingsCategory settingsCategory = static_cast<SettingsCategory>(arg); | 230 | SettingsCategory settingsCategory = static_cast<SettingsCategory>(arg); | ||
213 | 231 | | |||
214 | if (changeType == SettingsChangeType::Cursor) { | 232 | if (changeType == SettingsChangeType::Cursor) { | ||
Show All 29 Lines |
Now those two aren't needed anymore?