Changeset View
Changeset View
Standalone View
Standalone View
kded/configvalueprovider.cpp
| Show First 20 Lines • Show All 134 Lines • ▼ Show 20 Line(s) | 131 | { | |||
|---|---|---|---|---|---|
| 135 | QString buttonsOnRightKdeConfigValue = configGroup.readEntry(QStringLiteral("ButtonsOnRight"), "HIAX"); | 135 | QString buttonsOnRightKdeConfigValue = configGroup.readEntry(QStringLiteral("ButtonsOnRight"), "HIAX"); | ||
| 136 | 136 | | |||
| 137 | QString buttonsOnLeftInGtkNotation = windowDecorationButtonsOrderInGtkNotation(buttonsOnLeftKdeConfigValue); | 137 | QString buttonsOnLeftInGtkNotation = windowDecorationButtonsOrderInGtkNotation(buttonsOnLeftKdeConfigValue); | ||
| 138 | QString buttonsOnRightInGtkNotation = windowDecorationButtonsOrderInGtkNotation(buttonsOnRightKdeConfigValue); | 138 | QString buttonsOnRightInGtkNotation = windowDecorationButtonsOrderInGtkNotation(buttonsOnRightKdeConfigValue); | ||
| 139 | 139 | | |||
| 140 | return buttonsOnLeftInGtkNotation + QStringLiteral(":") + buttonsOnRightInGtkNotation; | 140 | return buttonsOnLeftInGtkNotation + QStringLiteral(":") + buttonsOnRightInGtkNotation; | ||
| 141 | } | 141 | } | ||
| 142 | 142 | | |||
| 143 | QString ConfigValueProvider::enableAnimations() const | ||||
| 144 | { | ||||
| 145 | KConfigGroup generalCfg = kdeglobalsConfig->group(QStringLiteral("KDE")); | ||||
davidedmundson: You don't need this.
KConfigWatcher does it automagically on change.
I did that because I… | |||||
I know, I just kept it consistent with the other code. Let's clean up this everywhere else above separately? broulik: I know, I just kept it consistent with the other code. Let's clean up this everywhere else… | |||||
| 146 | const qreal animationSpeedModifier = qMax(0.0, generalCfg.readEntry("AnimationDurationFactor", 1.0)); | ||||
| 147 | | ||||
| 148 | const bool enableAnimations = !qFuzzyIsNull(animationSpeedModifier); | ||||
| 149 | | ||||
| 150 | if (enableAnimations) { | ||||
| 151 | return QStringLiteral("1"); | ||||
| 152 | } else { | ||||
| 153 | return QStringLiteral("0"); | ||||
| 154 | } | ||||
| 155 | } | ||||
| 156 | | ||||
| 143 | QString ConfigValueProvider::toolbarStyleInDesiredNotation(const QString &kdeConfigValue, ConfigValueProvider::ToolbarStyleNotation notation) const | 157 | QString ConfigValueProvider::toolbarStyleInDesiredNotation(const QString &kdeConfigValue, ConfigValueProvider::ToolbarStyleNotation notation) const | ||
| 144 | { | 158 | { | ||
| 145 | QStringList toolbarStyles {}; | 159 | QStringList toolbarStyles {}; | ||
| 146 | if (notation == ToolbarStyleNotation::SettingsIni) { | 160 | if (notation == ToolbarStyleNotation::SettingsIni) { | ||
| 147 | toolbarStyles.append({ | 161 | toolbarStyles.append({ | ||
| 148 | QStringLiteral("GTK_TOOLBAR_ICONS"), | 162 | QStringLiteral("GTK_TOOLBAR_ICONS"), | ||
| 149 | QStringLiteral("GTK_TOOLBAR_TEXT"), | 163 | QStringLiteral("GTK_TOOLBAR_TEXT"), | ||
| 150 | QStringLiteral("GTK_TOOLBAR_BOTH_HORIZ"), | 164 | QStringLiteral("GTK_TOOLBAR_BOTH_HORIZ"), | ||
| ▲ Show 20 Lines • Show All 48 Lines • Show Last 20 Lines | |||||
You don't need this.
KConfigWatcher does it automagically on change.
I did that because I wanted a way for N connections to only reparse the file once. It also means you can use the config watcher with no signal handling, just install and you get the correct values on the next read. Amazing.
My fault for not having enough docs