Differential D26825 Diff 74108 kded/configvalueprovider.h

Changeset View

Standalone View

View Options

kded/configvalueprovider.h

Show All 39 Lines30public:
40 QString iconThemeName() const; 40​ QString iconThemeName() const;
41 QString cursorThemeName() const; 41​ QString cursorThemeName() const;
42 QString iconsOnButtons() const; 42​ QString iconsOnButtons() const;
43 QString iconsInMenus() const; 43​ QString iconsInMenus() const;
44 QString toolbarStyle(ToolbarStyleNotation notation) const; 44​ QString toolbarStyle(ToolbarStyleNotation notation) const;
45 QString scrollbarBehavior() const; 45​ QString scrollbarBehavior() const;
46 QString preferDarkTheme() const; 46​ QString preferDarkTheme() const;
47 QString windowDecorationsButtonsOrder() const; 47​ QString windowDecorationsButtonsOrder() const;
48​ QString enableAnimations() const;
48 49​
49private: 50​private:
50 QString toolbarStyleInDesiredNotation(const QString &kdeConfigValue, ToolbarStyleNotation notation) const; 51​ QString toolbarStyleInDesiredNotation(const QString &kdeConfigValue, ToolbarStyleNotation notation) const;
51 QString windowDecorationButtonsOrderInGtkNotation(const QString &kdeConfigValue) const; 52​ QString windowDecorationButtonsOrderInGtkNotation(const QString &kdeConfigValue) const;
52 53​
53 KSharedConfigPtr kdeglobalsConfig; 54​ KSharedConfigPtr kdeglobalsConfig;
54 KSharedConfigPtr inputConfig; 55​ KSharedConfigPtr inputConfig;
55 KSharedConfigPtr kwinConfig; 56​ KSharedConfigPtr kwinConfig;
57​ KSharedConfigPtr ownConfig;
gikariUnsubmitted
Not Done

It's not clear what ownConfig config is. GtkConfig does not have its own config (and even if it has, it is a bit strange to watch their own config in this context). If I understand correctly it is the kdeglobals. It would be nice to name it kdeglobalsConfig or globalsConfig

gikari: It's not clear what `ownConfig` config is. `GtkConfig` does not have its own config (and even…
56}; 58​};