Differential D26823 Diff 74067 kdecoration/config/breezeconfigwidget.cpp

Changeset View

Standalone View

View Options

kdecoration/config/breezeconfigwidget.cpp

Show All 40 Lines39 ConfigWidget::ConfigWidget( QWidget* parent, const QVariantList &args ):
41 m_configuration( KSharedConfig::openConfig( QStringLiteral( "breezerc" ) ) ), 41​ m_configuration( KSharedConfig::openConfig( QStringLiteral( "breezerc" ) ) ),
42 m_changed( false ) 42​ m_changed( false )
43 { 43​ {
44 44​
45 // configuration 45​ // configuration
46 m_ui.setupUi( this ); 46​ m_ui.setupUi( this );
47 47​
48 // track ui changes 48​ // track ui changes
49 connect( m_ui.titleAlignment, SIGNAL(currentIndexChanged(int)), SLOT(updateChanged()) ); 49​ connect( m_ui.titleAlignment, SIGNAL(currentIndexChanged(int)), SLOT(updateChanged()) );
zzagUnsubmitted
Not Done

Does clazy handle overloaded signals and slots?

zzag: Does clazy handle overloaded signals and slots?
davidedmundsonAuthorUnsubmitted
Not Done

Sort of.
It handles not doing anything bad. It detects it and prints a warning.

There's about 24 left in this repo.

davidedmundson: Sort of. It handles not doing anything bad. It detects it and prints a warning. There's about…
zzagUnsubmitted
Not Done

Hmm, so one has to port them by hand, right?

zzag: Hmm, so one has to port them by hand, right?
davidedmundsonAuthorUnsubmitted
Not Done

Effectively, yes.

I've been slowly going through all of Plasma, but a lot remain.

There's a combo of:

  • overloaded signals/slots
  • Q_PRIVATE_SLOT (which probably could be automated)
  • signals on a derived class for upcasted objects
davidedmundson: Effectively, yes. I've been slowly going through all of Plasma, but a lot remain. There's a…
zzagUnsubmitted
Not Done

There's about 24 left in this repo.

Do you want to port them in this patch or in another one?

zzag: > There's about 24 left in this repo. Do you want to port them in this patch or in another one?
davidedmundsonAuthorUnsubmitted
Not Done

I would prefer separately as then it's clear to a reviewer which ones need potentially more checking.

davidedmundson: I would prefer separately as then it's clear to a reviewer which ones need potentially more…
50 connect( m_ui.buttonSize, SIGNAL(currentIndexChanged(int)), SLOT(updateChanged()) ); 50​ connect( m_ui.buttonSize, SIGNAL(currentIndexChanged(int)), SLOT(updateChanged()) );
51 connect( m_ui.outlineCloseButton, SIGNAL(clicked()), SLOT(updateChanged()) ); 51​ connect( m_ui.outlineCloseButton, &QAbstractButton::clicked, this, &ConfigWidget::updateChanged );
52 connect( m_ui.drawBorderOnMaximizedWindows, SIGNAL(clicked()), SLOT(updateChanged()) ); 52​ connect( m_ui.drawBorderOnMaximizedWindows, &QAbstractButton::clicked, this, &ConfigWidget::updateChanged );
53 connect( m_ui.drawSizeGrip, SIGNAL(clicked()), SLOT(updateChanged()) ); 53​ connect( m_ui.drawSizeGrip, &QAbstractButton::clicked, this, &ConfigWidget::updateChanged );
54 connect( m_ui.drawBackgroundGradient, SIGNAL(clicked()), SLOT(updateChanged()) ); 54​ connect( m_ui.drawBackgroundGradient, &QAbstractButton::clicked, this, &ConfigWidget::updateChanged );
55 connect( m_ui.drawTitleBarSeparator, SIGNAL(clicked()), SLOT(updateChanged()) ); 55​ connect( m_ui.drawTitleBarSeparator, &QAbstractButton::clicked, this, &ConfigWidget::updateChanged );
56 56​
57 // track animations changes 57​ // track animations changes
58 connect( m_ui.animationsEnabled, SIGNAL(clicked()), SLOT(updateChanged()) ); 58​ connect( m_ui.animationsEnabled, &QAbstractButton::clicked, this, &ConfigWidget::updateChanged );
59 connect( m_ui.animationsDuration, SIGNAL(valueChanged(int)), SLOT(updateChanged()) ); 59​ connect( m_ui.animationsDuration, SIGNAL(valueChanged(int)), SLOT(updateChanged()) );
60 60​
61 // track shadows changes 61​ // track shadows changes
62 connect( m_ui.shadowSize, SIGNAL(currentIndexChanged(int)), SLOT(updateChanged()) ); 62​ connect( m_ui.shadowSize, SIGNAL(currentIndexChanged(int)), SLOT(updateChanged()) );
63 connect( m_ui.shadowStrength, SIGNAL(valueChanged(int)), SLOT(updateChanged()) ); 63​ connect( m_ui.shadowStrength, SIGNAL(valueChanged(int)), SLOT(updateChanged()) );
64 connect( m_ui.shadowColor, SIGNAL(changed(QColor)), SLOT(updateChanged()) ); 64​ connect( m_ui.shadowColor, &KColorButton::changed, this, &ConfigWidget::updateChanged );
65 65​
66 // track exception changes 66​ // track exception changes
67 connect( m_ui.exceptions, SIGNAL(changed(bool)), SLOT(updateChanged()) ); 67​ connect( m_ui.exceptions, &ExceptionListWidget::changed, this, &ConfigWidget::updateChanged );
68 68​
69 } 69​ }
70 70​
71 //_________________________________________________________ 71​ //_________________________________________________________
72 void ConfigWidget::load() 72​ void ConfigWidget::load()
73 { 73​ {
74 74​
75 // create internal settings and load from rc files 75​ // create internal settings and load from rc files
▲ Show 20 Lines • Show All 142 Lines • Show Last 20 Lines