Differential D26659 Diff 73796 src/core/kcoredirlister.h

Changeset View

Standalone View

View Options

src/core/kcoredirlister.h

Show First 20 Lines • Show All 584 Lines • ▼ Show 20 Line(s)556#endif
585 585​
586 /** 586​ /**
587 * Called by the public matchesFilter() to do the 587​ * Called by the public matchesFilter() to do the
588 * actual filtering. Those methods may be reimplemented to customize 588​ * actual filtering. Those methods may be reimplemented to customize
589 * filtering. 589​ * filtering.
590 * @param name the name to filter 590​ * @param name the name to filter
591 * @param filters a list of regular expressions for filtering 591​ * @param filters a list of regular expressions for filtering
592 */ 592​ */
593​ // TODO KF6 remove
593 virtual bool doNameFilter(const QString &name, const QList<QRegExp> &filters) const; 594​ virtual bool doNameFilter(const QString &name, const QList<QRegExp> &filters) const;
broulikUnsubmitted
Not Done

This class is exported, you cannot change this existing method and you also cannot add a new virtual, see https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B

broulik: This class is exported, you cannot change this existing method and you also cannot add a new…
ahmadsamirAuthorUnsubmitted
Not Done

Thanks, fixed. Luckily it's a convenience function of sorts and replacing the one instance it was used in KCoreDirLister was simple).

ahmadsamir: Thanks, fixed. Luckily it's a convenience function of sorts and replacing the one instance it…
dfaureUnsubmitted
Not Done

Please write TODO KF6 remove, I see zero reason to keep this a virtual method, and lxr says nobody is using it. Same for doMimeFilter.

dfaure: Please write TODO KF6 remove, I see zero reason to keep this a virtual method, and lxr says…
594 595​
595 /** 596​ /**
596 * Called by the public matchesMimeFilter() to do the 597​ * Called by the public matchesMimeFilter() to do the
597 * actual filtering. Those methods may be reimplemented to customize 598​ * actual filtering. Those methods may be reimplemented to customize
598 * filtering. 599​ * filtering.
599 * @param mime the mime type to filter 600​ * @param mime the mime type to filter
600 * @param filters the list of mime types to filter 601​ * @param filters the list of mime types to filter
601 */ 602​ */
603​ // TODO KF6 remove
602 virtual bool doMimeFilter(const QString &mime, const QStringList &filters) const; 604​ virtual bool doMimeFilter(const QString &mime, const QStringList &filters) const;
603 605​
604 /** 606​ /**
605 * Reimplement to customize error handling 607​ * Reimplement to customize error handling
606 */ 608​ */
607 virtual void handleError(KIO::Job *); 609​ virtual void handleError(KIO::Job *);
608 /** 610​ /**
609 * Reimplement to customize error handling 611​ * Reimplement to customize error handling
Show All 19 Lines