Differential D26202 Diff 73510 src/kconfig_compiler/KConfigCodeGeneratorBase.cpp

Changeset View

Standalone View

View Options

src/kconfig_compiler/KConfigCodeGeneratorBase.cpp

  • This file was added.
1​/* This file is part of the KDE libraries
2​ Copyright (C) 2020 Tomaz Cananbrava (tcanabrava@kde.org)
3​
dfaureUnsubmitted
Done

Is this really entirely new code?

Please propagate the copyright of the file you copied this from.

I can agree that .h files are brand new, but not .cpp files

dfaure: Is this really entirely new code? Please propagate the copyright of the file you copied this…
4​ This library is free software; you can redistribute it and/or
5​ modify it under the terms of the GNU Library General Public
6​ License as published by the Free Software Foundation; either
7​ version 2 of the License, or (at your option) any later version.
8​
9​ This library is distributed in the hope that it will be useful,
10​ but WITHOUT ANY WARRANTY; without even the implied warranty of
11​ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
12​ Library General Public License for more details.
13​
14​ You should have received a copy of the GNU Library General Public License
15​ along with this library; see the file COPYING.LIB. If not, write to
16​ the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
17​ Boston, MA 02110-1301, USA.
18​*/
19​
20​#include "KConfigCodeGeneratorBase.h"
21​#include "KConfigXTParameters.h"
22​#include "KConfigCommonStructs.h"
23​
24​#include <QTextStream>
25​#include <QLatin1Char>
26​#include <QFileInfo>
27​
28​#include <ostream>
29​#include <QDebug>
30​
31​using std::endl;
32​
33​namespace
34​{
35​QTextStream cout(stdout);
36​QTextStream cerr(stderr);
37​}
38​
39​KConfigCodeGeneratorBase::KConfigCodeGeneratorBase(
40​ const QString& inputFile,
41​ const QString& baseDir,
42​ const QString& fileName,
43​ const KConfigXTParameters &parameters,
44​ ParseResult &parseResult)
45​ : inputFile(inputFile), baseDir(baseDir), fileName(fileName), cfg(parameters), parseResult(parseResult)
46​{
47​ file.setFileName(fileName);
ervinUnsubmitted
Done

Space before & not after

ervin: Space before & not after
48​ if (!file.open(QIODevice::WriteOnly)) {
49​ cerr << "Can not open '" << fileName << "for writing." << endl;
50​ exit(1);
51​ }
52​ stream.setDevice(&file);
53​ stream.setCodec("utf-8");
54​
55​ if (cfg.staticAccessors) {
56​ This = QStringLiteral("self()->");
57​ } else {
58​ Const = QStringLiteral(" const");
59​ }
60​}
61​
62​KConfigCodeGeneratorBase::~KConfigCodeGeneratorBase()
63​{
64​ save();
65​}
66​
67​void KConfigCodeGeneratorBase::save()
68​{
69​ file.close();
70​}
71​
72​void KConfigCodeGeneratorBase::indent()
73​{
74​ if (indentLevel >= 4) {
75​ indentLevel += 2;
76​ } else {
77​ indentLevel += 4;
78​ }
79​}
80​
81​void KConfigCodeGeneratorBase::unindent()
ervinUnsubmitted
Done

This is an odd indentation logic, is it to stay close to the original? (which I'd actually support, just trying to understand where that's coming from).

ervin: This is an odd indentation logic, is it to stay close to the original? (which I'd actually…
tcanabravaAuthorUnsubmitted
Not Done

it's to stay close to the original. originally all the indentation was done manually, but first 4 spaces and later 2 spaces. This code is bogus and I would like to get rid of it spporting only one indentation style. I'm adding a TODO: for that here.

tcanabrava: it's to stay close to the original. originally all the indentation was done manually, but first…
82​{
83​ if (indentLevel > 4) {
84​ indentLevel -= 2;
85​ } else {
86​ indentLevel -= 4;
87​ }
88​}
89​
90​QString KConfigCodeGeneratorBase::whitespace()
91​{
92​ QString spaces;
93​ for (int i = 0; i < indentLevel; i++) {
94​ spaces.append(QLatin1Char(' '));
95​ }
96​ return spaces;
97​}
98​
99​void KConfigCodeGeneratorBase::startScope()
100​{
101​ stream << whitespace() << QLatin1Char('{');
102​ stream << endl;
103​ indent();
104​}
105​
106​void KConfigCodeGeneratorBase::endScope(ScopeFinalizer finalizer)
107​{
108​ unindent();
109​ stream << whitespace() << QLatin1Char('}');
110​ if (finalizer == ScopeFinalizer::Semicolon) {
111​ stream << ';';
112​ }
113​ stream << endl;
114​}
115​
116​void KConfigCodeGeneratorBase::start()
117​{
118​ const QString fileName = QFileInfo(inputFile).fileName();
119​ stream << "// This file is generated by kconfig_compiler_kf5 from " << fileName << ".kcfg" << "." << endl;
120​ stream << "// All changes you do to this file will be lost." << endl;
121​}
122​
123​void KConfigCodeGeneratorBase::addHeaders(const QStringList& headerList)
124​{
125​ for (auto include : qAsConst(headerList)) {
126​ if (include.startsWith(QLatin1Char('"'))) {
127​ stream << "#include " << include << endl;
128​ } else {
129​ stream << "#include <" << include << ">" << endl;
130​ }
ervinUnsubmitted
Done

Space before & not after

ervin: Space before & not after
131​ }
132​}
133​
134​// adds as many 'namespace foo {' lines to p_out as
135​// there are namespaces in p_ns
136​void KConfigCodeGeneratorBase::beginNamespaces()
137​{
138​ if (!cfg.nameSpace.isEmpty()) {
139​ for (const QString &ns : cfg.nameSpace.split(QStringLiteral("::"))) {
140​ stream << "namespace " << ns << " {" << endl;
141​ }
142​ stream << endl;
143​ }
144​}
145​
146​// adds as many '}' lines to p_out as
147​// there are namespaces in p_ns
148​void KConfigCodeGeneratorBase::endNamespaces()
149​{
150​ if (!cfg.nameSpace.isEmpty()) {
151​ stream << endl;
152​ const int namespaceCount = cfg.nameSpace.count(QStringLiteral("::")) + 1;
153​ for (int i = 0; i < namespaceCount; ++i) {
154​ stream << "}" << endl;
155​ }
156​ }
157​}
158​
159​// returns the member accesor implementation
160​// which should go in the h file if inline
161​// or the cpp file if not inline
162​QString KConfigCodeGeneratorBase::memberAccessorBody(const CfgEntry *e, bool globalEnums) const
163​{
164​ QString result;
165​ QTextStream out(&result, QIODevice::WriteOnly);
166​ QString n = e->name;
167​ QString t = e->type;
168​ bool useEnumType = cfg.useEnumTypes && t == QLatin1String("Enum");
169​
170​ out << "return ";
171​ if (useEnumType) {
172​ out << "static_cast<" << enumType(e, globalEnums) << ">(";
173​ }
174​ out << This << varPath(n, cfg);
175​ if (!e->param.isEmpty()) {
176​ out << "[i]";
177​ }
178​ if (useEnumType) {
179​ out << ")";
180​ }
181​ out << ";" << endl;
182​
183​ return result;
184​}
185​
186​void KConfigCodeGeneratorBase::createIfSetLogic(const CfgEntry *e, const QString &varExpression)
187​{
188​ const QString n = e->name;
189​ const QString t = e->type;
190​ const bool hasBody = !e->signalList.empty() || cfg.generateProperties;
191​
192​ stream << whitespace() << "if (";
193​ if (hasBody) {
194​ stream << "v != " << varExpression << " && ";
195​ }
196​ stream << "!" << This << "isImmutable( QStringLiteral( \"";
197​ if (!e->param.isEmpty()) {
198​ QString paramName = e->paramName;
199​
200​ stream << paramName.replace(QStringLiteral("$(") + e->param + QStringLiteral(")"), QLatin1String("%1")) << "\" ).arg( ";
201​ if (e->paramType == QLatin1String("Enum")) {
202​ stream << "QLatin1String( ";
203​
204​ if (cfg.globalEnums) {
205​ stream << enumName(e->param) << "ToString[i]";
206​ } else {
207​ stream << enumName(e->param) << "::enumToString[i]";
208​ }
209​
210​ stream << " )";
211​ } else {
212​ stream << "i";
213​ }
214​ stream << " )";
215​ } else {
216​ stream << n << "\" )";
217​ }
218​ stream << " ))";
219​}
220​
221​void KConfigCodeGeneratorBase::memberMutatorBody(const CfgEntry *e)
222​{
223​ QString n = e->name;
224​ QString t = e->type;
225​
226​ // HACK: Don't open '{' manually, use startScope / endScope to automatically handle whitespace indentation.
227​ if (!e->min.isEmpty()) {
228​ if (e->min != QLatin1String("0") || !isUnsigned(t)) { // skip writing "if uint<0" (#187579)
229​ stream << whitespace() << "if (v < " << e->min << ")" << endl;
230​ stream << whitespace() << "{" << endl;
231​ stream << whitespace(); addDebugMethod(stream, cfg, n);
232​ stream << ": value \" << v << \" is less than the minimum value of " << e->min << "\";" << endl;
233​ stream << whitespace() << " v = " << e->min << ";" << endl;
234​ stream << whitespace() << "}" << endl;
235​ }
236​ }
237​
238​ if (!e->max.isEmpty()) {
239​ stream << endl;
240​ stream << whitespace() << "if (v > " << e->max << ")" << endl;
241​ stream << whitespace() << "{" << endl;
242​ stream << whitespace(); addDebugMethod(stream, cfg, n);
243​ stream << ": value \" << v << \" is greater than the maximum value of " << e->max << "\";" << endl;
244​ stream << whitespace() << " v = " << e->max << ";" << endl;
245​ stream << whitespace() << "}" << endl << endl;
246​ }
247​
248​ const QString varExpression = This + varPath(n, cfg) + (e->param.isEmpty() ? QString() : QStringLiteral("[i]"));
249​
250​ // TODO: Remove this `hasBody` logic, always use an '{' for the if.
251​ const bool hasBody = !e->signalList.empty() || cfg.generateProperties;
252​
253​ // This call creates an `if (someTest ...) that's just to long to throw over the code.
254​ createIfSetLogic(e, varExpression);
255​ stream << (hasBody ? " {" : "") << endl;
256​ stream << whitespace() << " " << varExpression << " = v;" << endl;
257​
258​ const auto listSignal = e->signalList;
259​ for (const Signal &signal : qAsConst(listSignal)) {
260​ if (signal.modify) {
261​ stream << whitespace() << " Q_EMIT " << This << signal.name << "();" << endl;
262​ } else {
263​ stream << whitespace() << " " << This << varPath(QStringLiteral("settingsChanged"), cfg)
264​ << " |= " << signalEnumName(signal.name) << ";" << endl;
265​ }
266​ }
267​ if (hasBody) {
268​ stream << whitespace() << "}" << endl;
269​ }
270​}