Differential D26539 Diff 73154 src/activities/gletters/gletters.js

Changeset View

Standalone View

View Options

src/activities/gletters/gletters.js

Show All 26 Lines
27.pragma library 27​.pragma library
28.import QtQuick 2.6 as Quick 28​.import QtQuick 2.6 as Quick
29.import GCompris 1.0 as GCompris //for ApplicationInfo 29​.import GCompris 1.0 as GCompris //for ApplicationInfo
30.import "qrc:/gcompris/src/core/core.js" as Core 30​.import "qrc:/gcompris/src/core/core.js" as Core
31 31​
32var currentLevel = 0; 32​var currentLevel = 0;
33var currentSubLevel = 0; 33​var currentSubLevel = 0;
34var level = null; 34​var level = null;
35​var levelData = null;
echarruauUnsubmitted
Done

as seen in our discussion you do not need this value

echarruau: as seen in our discussion you do not need this value
35var maxLevel = 0; 36​var maxLevel = 0;
36var maxSubLevel = 0; 37​var maxSubLevel = 0;
37var items; 38​var items;
38var uppercaseOnly; 39​var uppercaseOnly;
39var mode; 40​var mode;
40 41​
41//speed calculations, common: 42​//speed calculations, common:
42var speed = 0; // how fast letters fall 43​var speed = 0; // how fast letters fall
▲ Show 20 Lines • Show All 76 Lines • ▼ Show 20 Line(s)119 if(items.levels)
119 items.instructionText = items.levels[currentLevel].objective 120​ items.instructionText = items.levels[currentLevel].objective
120 items.audioVoices.clearQueue() 121​ items.audioVoices.clearQueue()
121 items.bar.level = currentLevel + 1; 122​ items.bar.level = currentLevel + 1;
122 wgMaxFallingItems = 3 123​ wgMaxFallingItems = 3
123 successRate = 1.0 124​ successRate = 1.0
124 125​
125 // initialize level 126​ // initialize level
126 deleteWords(); 127​ deleteWords();
128​ if( level !== null && items.ourActivity.activityName === "smallnumbers2")
129​ level.words = levelData;
127 level = items.wordlist.getLevelWordList(currentLevel + 1); 130​ level = items.wordlist.getLevelWordList(currentLevel + 1);
128 maxSubLevel = items.wordlist.getMaxSubLevel(currentLevel + 1); 131​ maxSubLevel = items.wordlist.getMaxSubLevel(currentLevel + 1);
132​ levelData = level.words
shubhammishraAuthorUnsubmitted
Done

it creates new variable, which is a hard copy not a reference,as we discussed.

shubhammishra: it creates new variable, which is a hard copy not a reference,as we discussed.
133​ if(items.ourActivity.activityName === "smallnumbers2"){
134​ level.words = level.words.concat( level.words.concat(level.words) );
echarruauUnsubmitted
Done

Here you are modifying the source itself, this means that next time you come back to a level you already did you will have the concatenation in the data presented and not what is in the json file.
To solve this problem you need to work on a hard copy of the variable.
I find this approach interesting as we will be able to present randomized data to the user, as long as the datas to be taught in the level is appearing much more often than already known elements. Let say 50% of the time. We could say that the first data presented is the new one to be taught or find an other way. To be discussed with the others.

echarruau: Here you are modifying the source itself, this means that next time you come back to a level…
shubhammishraAuthorUnsubmitted
Done

this line will concatenate levelData to itself thrice, so we will get each copy of dominoes three times.

shubhammishra: this line will concatenate levelData to itself thrice, so we will get each copy of dominoes…
echarruauUnsubmitted
Done

we said yesterday that it does not work. If you have 1 data at the beginning you don't obtain 15 data. We said you need to create an array containing 15 data randomly taken from the available data.

echarruau: we said yesterday that it does not work. If you have 1 data at the beginning you don't obtain…
shubhammishraAuthorUnsubmitted
Done

do i have to make data set of 15 for each level regardless of initial data size as current approach is only increasing it size three times? can i use a loop here which randomly pick a element from level.words 15 times and push it into levelData variable.

shubhammishra: do i have to make data set of 15 for each level regardless of initial data size as current…
echarruauUnsubmitted
Done

we need to have a dataset made from data given in levelswords. The data should be randomly chosen but still have abotu equally distributed.
Let say we have 1 3 5 in our data, it would be good to have 1 3 5 5 3 1 3 5 1.
We should be able to have a non hard coded value given though the qml to replace 15. We can call it count.
And we need to have a special dataname to descripbe the list of the data that are really targeted for a given level
Let say we introduce 4 and 5 we need to have 50% of the time 4 and 5 and 50% of the the rest of the data.

echarruau: we need to have a dataset made from data given in levelswords. The data should be randomly…
135​ level.words.length =( level.words.length > 15 ) ? 15 : level.words.length;
shubhammishraAuthorUnsubmitted
Done

this will restrict the number of dominoes in each level to 15.

shubhammishra: this will restrict the number of dominoes in each level to 15.
echarruauUnsubmitted
Done

See previous comment.

echarruau: See previous comment.
jjazeixUnsubmitted
Not Done

it would be better to have an attribute named useDataset in the Activity.qml that is set to true for smallnumbers and smallnumbers2.
This way, if we update another activity, we will only have to update this variable instead of changing all "if" conditions in the js.

jjazeix: it would be better to have an attribute named useDataset in the Activity.qml that is set to…
136​ }
129 137​
130 if (maxSubLevel == 0) { 138​ if (maxSubLevel == 0) {
131 // If "sublevels" length is not set in wordlist, use the words length 139​ // If "sublevels" length is not set in wordlist, use the words length
132 maxSubLevel = level.words.length 140​ maxSubLevel = level.words.length
echarruauUnsubmitted
Done

Here can you have a detailed comment to explain what maxSubLevel is used for. Something to say that it gives the number of falling elements presented for each level. ?

echarruau: Here can you have a detailed comment to explain what maxSubLevel is used for. Something to say…
shubhammishraAuthorUnsubmitted
Not Done

Yes, maxSubLevel stores the number of dominoes to fall down in each level, in previous code it is equals to level.words.length but this time i added attribute sublevels in json to pass it a value.
Reason for choosing this name is that activity previously also using this variable for storing number of falling elements as on line no. 128, 139,141,452.
and i choose the name sublevels for json after looking the defination of function
items.wordlist.getMaxSubLevel(currentLevel + 1) .

shubhammishra: Yes, maxSubLevel stores the number of dominoes to fall down in each level, in previous code it…
echarruauUnsubmitted
Not Done

I mean a comment in the code, not for me :)
I understood this part, but it tool me time, a detailed comment will help maintenainers and other coder.

echarruau: I mean a comment in the code, not for me :) I understood this part, but it tool me time, a…
133 } 141​ }
134 items.score.numberOfSubLevels = maxSubLevel; 142​ items.score.numberOfSubLevels = maxSubLevel;
135 setSpeed(); 143​ setSpeed();
136 /*console.log("Gletters: initializing level " + (currentLevel + 1) 144​ /*console.log("Gletters: initializing level " + (currentLevel + 1)
137 + " maxSubLvl=" + maxSubLevel 145​ + " maxSubLvl=" + maxSubLevel
138 + " wordCount=" + level.words.length 146​ + " wordCount=" + level.words.length
139 + " speed=" + speed + " fallspeed=" + fallSpeed);*/ 147​ + " speed=" + speed + " fallspeed=" + fallSpeed);*/
140 148​
141 { 149​ {
142 /* populate VirtualKeyboard for mobile: 150​ /* populate VirtualKeyboard for mobile:
143 * 1. for < 10 letters print them all in the same row 151​ * 1. for < 10 letters print them all in the same row
144 * 2. for > 10 letters create 3 rows with equal amount of keys per row 152​ * 2. for > 10 letters create 3 rows with equal amount of keys per row
145 * if possible, otherwise more keys in the upper rows 153​ * if possible, otherwise more keys in the upper rows
146 * 3. if we have both upper- and lowercase letters activate the shift 154​ * 3. if we have both upper- and lowercase letters activate the shift
147 * key*/ 155​ * key*/
148 // first generate a map of needed letters 156​ // first generate a map of needed letters
149 var letters = new Array(); 157​ var letters = new Array();
150 items.keyboard.shiftKey = false; 158​ items.keyboard.shiftKey = false;
151 for (var i = 0; i < level.words.length; i++) { 159​ for (var i = 0; i < level.words.length; i++) {
shubhammishraAuthorUnsubmitted
Done

in line 137,156,159,167,170,171,178 just replaced the level.words with new variable levelData as we have to do every operation using this concatenated variable.

shubhammishra: in line 137,156,159,167,170,171,178 just replaced the level.words with new variable levelData…
echarruauUnsubmitted
Done

Good, did you make sure it does not breack gletters? It should not but please check.

echarruau: Good, did you make sure it does not breack gletters? It should not but please check.
shubhammishraAuthorUnsubmitted
Done

i test it by playing all falling * activities and even sure with code changes which i have done, is there any more formal way to check?

shubhammishra: i test it by playing all falling * activities and even sure with code changes which i have done…
152 if(mode ==='letter') { 160​ if(mode ==='letter') {
153 // The word is a letter, even if it has several chars (digraph) 161​ // The word is a letter, even if it has several chars (digraph)
154 var letter = level.words[i]; 162​ var letter = level.words[i];
155 var isUpper = (letter == letter.toLocaleUpperCase()); 163​ var isUpper = (letter == letter.toLocaleUpperCase());
156 if (isUpper && letters.indexOf(letter.toLocaleLowerCase()) !== -1) 164​ var isDigit = letter.toLocaleLowerCase() === letter.toLocaleUpperCase()
165​ if (!isDigit && isUpper && letters.indexOf(letter.toLocaleLowerCase()) !== -1)
echarruauUnsubmitted
Done

why is this diff here?

echarruau: why is this diff here?
shubhammishraAuthorUnsubmitted
Done

The previous code is treating all letters like a alphabets, and sometimes enabling shift even for digits. i have just added isDigit variable in if condition to ensure not to enable shift because of digit. counter case here is if levelData=[3,3]. the previous code will enable shift for this array.

shubhammishra: The previous code is treating all letters like a alphabets, and sometimes enabling shift even…
157 items.keyboard.shiftKey = true; 166​ items.keyboard.shiftKey = true;
158 else if (!isUpper && letters.indexOf(letter.toLocaleUpperCase()) !== -1) 167​ else if (!isDigit && !isUpper && letters.indexOf(letter.toLocaleUpperCase()) !== -1)
159 items.keyboard.shiftKey = true; 168​ items.keyboard.shiftKey = true;
160 else if (letters.indexOf(letter) === -1) 169​ else if (letters.indexOf(letter) === -1)
161 letters.push(level.words[i]); 170​ letters.push(level.words[i]);
162 } else { 171​ } else {
163 // We split each word in char to create the keyboard 172​ // We split each word in char to create the keyboard
164 for (var j = 0; j < level.words[i].length; j++) { 173​ for (var j = 0; j < level.words[i].length; j++) {
165 var letter = level.words[i].charAt(j); 174​ var letter = level.words[i].charAt(j);
166 var isUpper = (letter == letter.toLocaleUpperCase()); 175​ var isUpper = (letter == letter.toLocaleUpperCase());
167 if (isUpper && letters.indexOf(letter.toLocaleLowerCase()) !== -1) 176​ if (isUpper && letters.indexOf(letter.toLocaleLowerCase()) !== -1)
168 items.keyboard.shiftKey = true; 177​ items.keyboard.shiftKey = true;
169 else if (!isUpper && letters.indexOf(letter.toLocaleUpperCase()) !== -1) 178​ else if (!isUpper && letters.indexOf(letter.toLocaleUpperCase()) !== -1)
170 items.keyboard.shiftKey = true; 179​ items.keyboard.shiftKey = true;
171 else if (letters.indexOf(letter) === -1) 180​ else if (letters.indexOf(letter) === -1)
172 letters.push(level.words[i].charAt(j)); 181​ letters.push(level.words[i].charAt(j));
173 } 182​ }
174 } 183​ }
175 } 184​ }
176 letters = GCompris.ApplicationInfo.localeSort(letters, items.locale); 185​ letters = GCompris.ApplicationInfo.localeSort(letters, items.locale);
177 // generate layout from letter map 186​ // generate layout from letter map
178 var layout = new Array(); 187​ var layout = new Array();
179 var row = 0; 188​ var row = 0;
180 var offset = 0; 189​ var offset = 0;
181 while (offset < letters.length-1) { 190​ while (offset < letters.length) {
182 var cols = letters.length <= 10 ? letters.length : (Math.ceil((letters.length-offset) / (3 - row))); 191​ var cols = letters.length <= 10 ? letters.length : (Math.ceil((letters.length-offset) / (3 - row)));
183 layout[row] = new Array(); 192​ layout[row] = new Array();
184 for (var j = 0; j < cols; j++) 193​ for (var j = 0; j < cols; j++)
185 layout[row][j] = { label: letters[j+offset] }; 194​ layout[row][j] = { label: letters[j+offset] };
186 offset += j; 195​ offset += j;
187 row++; 196​ row++;
188 } 197​ }
189 items.keyboard.layout = layout; 198​ items.keyboard.layout = layout;
190 } 199​ }
191 items.wordlist.initRandomWord(currentLevel + 1) 200​ items.wordlist.initRandomWord(currentLevel + 1)
shubhammishraAuthorUnsubmitted
Done

in previous code,function initRandomWord(currentLevel + 1) shuffles the items.word, here we have to take care to do every operation with levelData. i checked the defination of this function and generated the random list by shyuffling levelData.

shubhammishra: in previous code,function initRandomWord(currentLevel + 1) shuffles the items.word, here we…
echarruauUnsubmitted
Done

Not sure we need this since you will create our own random list, but here we may have a problem keeping gletters working.

echarruau: Not sure we need this since you will create our own random list, but here we may have a problem…
shubhammishraAuthorUnsubmitted
Done

levelData is already shuffled, and we can't use initRandomWord function for smallumbers2 as it will shuffle level.words, so i can make changes like this? -

 if(items.ourActivity.activityName !== "smallnumbers2"){
       items.wordlist.initRandomWord(currentLevel + 1)
else
       items.wordlist.randomWordList = levelData
shubhammishra: levelData is already shuffled, and we can't use initRandomWord function for smallumbers2 as it…
echarruauUnsubmitted
Not Done

I need to investigate this one furthut is is not clear to me :(

echarruau: I need to investigate this one furthut is is not clear to me :(
echarruauUnsubmitted
Not Done

At the present moment this discussion is not necessary anymore as our current problem will be soved once you will have created your input data array containing the data to give to the user.

echarruau: At the present moment this discussion is not necessary anymore as our current problem will be…
192 initSubLevel() 201​ initSubLevel()
193} 202​}
194 203​
195function initSubLevel() { 204​function initSubLevel() {
196 currentWord = null; 205​ currentWord = null;
197 if (currentSubLevel != 0) { 206​ if (currentSubLevel != 0) {
198 // increase speed 207​ // increase speed
jjazeixUnsubmitted
Not Done

algorithm

jjazeix: algorithm
199 speed = Math.max(speed - incSpeed, wgMinSpeed); 208​ speed = Math.max(speed - incSpeed, wgMinSpeed);
jjazeixUnsubmitted
Not Done

separately

jjazeix: separately
200 items.wordDropTimer.interval = fallSpeed = Math.max(fallSpeed - incFallSpeed, wgMinFallSpeed); 209​ items.wordDropTimer.interval = fallSpeed = Math.max(fallSpeed - incFallSpeed, wgMinFallSpeed);
201 } 210​ }
202 items.score.currentSubLevel = currentSubLevel + 1; 211​ items.score.currentSubLevel = currentSubLevel + 1;
jjazeixUnsubmitted
Not Done

remove useless spaces before/after parenthesis

jjazeix: remove useless spaces before/after parenthesis
203 if (currentSubLevel == 0 || droppedWords.length <= 1) // note, last word is still fading out 212​ if (currentSubLevel == 0 || droppedWords.length <= 1) // note, last word is still fading out
204 dropWord(); 213​ dropWord();
jjazeixUnsubmitted
Not Done

for(var i = 0 ...)

jjazeix: for(var i = 0 ...)
jjazeixUnsubmitted
Not Done

add { }

jjazeix: add { }
205 //console.log("Gletters: initializing subLevel " + (currentSubLevel + 1) + " words=" + JSON.stringify(level.words)); 214​ //console.log("Gletters: initializing subLevel " + (currentSubLevel + 1) + " words=" + JSON.stringify(level.words));
jjazeixUnsubmitted
Not Done

probability

jjazeix: probability
jjazeixUnsubmitted
Not Done

remove space before )

jjazeix: remove space before )
206} 215​}
207 216​
208function processKeyPress(text) { 217​function processKeyPress(text) {
209 var typedText = uppercaseOnly ? text.toLocaleUpperCase() : text; 218​ var typedText = uppercaseOnly ? text.toLocaleUpperCase() : text;
210 219​
jjazeixUnsubmitted
Not Done

add { }

jjazeix: add { }
211 if (currentWord !== null) { 220​ if (currentWord !== null) {
jjazeixUnsubmitted
Not Done

remove space before )

jjazeix: remove space before )
212 // check against a currently typed word 221​ // check against a currently typed word
213 if (!currentWord.checkMatch(typedText)) { 222​ if (!currentWord.checkMatch(typedText)) {
214 currentWord = null; 223​ currentWord = null;
jjazeixUnsubmitted
Not Done

an element

jjazeix: an element
215 audioCrashPlay() 224​ audioCrashPlay()
jjazeixUnsubmitted
Not Done

indentation

jjazeix: indentation
216 } else { 225​ } else {
217 playLetter(text) 226​ playLetter(text)
218 } 227​ }
219 } else { 228​ } else {
220 // no current word, check against all available words 229​ // no current word, check against all available words
221 var found = false 230​ var found = false
222 for (var i = 0; i< droppedWords.length; i++) { 231​ for (var i = 0; i< droppedWords.length; i++) {
223 if (droppedWords[i].checkMatch(typedText)) { 232​ if (droppedWords[i].checkMatch(typedText)) {
224 // typed correctly 233​ // typed correctly
jjazeixUnsubmitted
Not Done

remove space before )

jjazeix: remove space before )
225 currentWord = droppedWords[i]; 234​ currentWord = droppedWords[i];
226 playLetter(text) 235​ playLetter(text)
227 found = true 236​ found = true
228 break; 237​ break;
229 } 238​ }
230 } 239​ }
231 if(!found) { 240​ if(!found) {
232 audioCrashPlay() 241​ audioCrashPlay()
▲ Show 20 Lines • Show All 192 Lines • Show Last 20 Lines