Differential D26324 Diff 72489 kcms/componentchooser/componentchooserfilemanager.h

Changeset View

Standalone View

View Options

kcms/componentchooser/componentchooserfilemanager.h

Show All 37 Lines
38protected Q_SLOTS: 38​protected Q_SLOTS:
39 void slotAddFileManager(); 39​ void slotAddFileManager();
40 void configChanged(); 40​ void configChanged();
41 41​
42Q_SIGNALS: 42​Q_SIGNALS:
43 void changed(bool); 43​ void changed(bool);
44 44​
45private: 45​private:
46​ QRadioButton* findDolphinRadio() const;
ervinUnsubmitted
Not Done

No need to expose it in the .h at all, could take the list as a const& parameter. Besides the space should be before the star not after.

ervin: No need to expose it in the .h at all, could take the list as a const& parameter. Besides the…
ervinUnsubmitted
Not Done

This change should go away now.

ervin: This change should go away now.
ervinUnsubmitted
Not Done

Really, this change should go away. ;-)

ervin: Really, this change should go away. ;-)
47​
46 QList<QRadioButton *> mDynamicRadioButtons; 48​ QList<QRadioButton *> mDynamicRadioButtons;
47}; 49​};
48 50​
49#endif 51​#endif