Differential D26039 Diff 72088 kcms/desktoptheme/themesmodel.cpp

Changeset View

Standalone View

View Options

kcms/desktoptheme/themesmodel.cpp

  • This file was added.
1​/*
2​ * Copyright (C) 2007 Matthew Woehlke <mw_triad@users.sourceforge.net>
3​ * Copyright (C) 2007 Jeremy Whiting <jpwhiting@kde.org>
4​ * Copyright (C) 2016 Olivier Churlaud <olivier@churlaud.com>
5​ * Copyright (C) 2019 Kai Uwe Broulik <kde@privat.broulik.de>
6​ * Copyright (C) 2019 David Redondo <kde@david-redondo.de>
7​ *
8​ * This program is free software; you can redistribute it and/or
9​ * modify it under the terms of the GNU General Public License as
10​ * published by the Free Software Foundation; either version 2 of
11​ * the License or (at your option) version 3 or any later version
12​ * accepted by the membership of KDE e.V. (or its successor approved
13​ * by the membership of KDE e.V.), which shall act as a proxy
14​ * defined in Section 14 of version 3 of the license.
15​ *
16​ * This program is distributed in the hope that it will be useful,
17​ * but WITHOUT ANY WARRANTY; without even the implied warranty of
18​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
19​ * GNU General Public License for more details.
20​ *
21​ * You should have received a copy of the GNU General Public License
22​ * along with this program. If not, see <http://www.gnu.org/licenses/>.
23​ */
24​
25​#include "themesmodel.h"
26​
27​#include <QCollator>
28​#include <QDir>
29​#include <QStandardPaths>
30​
31​#include <KColorScheme>
32​#include <KDesktopFile>
33​
34​#include <KConfigGroup>
35​#include <KSharedConfig>
36​
37​#include <algorithm>
38​#include <memory>
39​
40​ThemesModel::ThemesModel(QObject *parent) : QAbstractListModel(parent)
41​{
42​
43​}
44​
45​ThemesModel::~ThemesModel() = default;
46​
47​int ThemesModel::rowCount(const QModelIndex &parent) const
48​{
49​ if (parent.isValid()) {
50​ return 0;
51​ }
52​
53​ return m_data.count();
54​}
55​
56​QVariant ThemesModel::data(const QModelIndex &index, int role) const
57​{
58​ if (!index.isValid() || index.row() >= m_data.count()) {
59​ return QVariant();
60​ }
61​
62​ const auto &item = m_data.at(index.row());
63​
64​ switch (role) {
65​ case Qt::DisplayRole: return item.display;
66​ case PluginNameRole: return item.pluginName;
67​ case DescriptionRole: return item.description;
68​ case ColorTypeRole: return item.type;
69​ case IsLocalRole: return item.isLocal;
70​ case PendingDeletionRole: return item.pendingDeletion;
71​ }
72​ return QVariant();
73​}
74​
75​bool ThemesModel::setData(const QModelIndex &index, const QVariant &value, int role)
76​{
77​ if (!index.isValid() || index.row() >= m_data.count()) {
78​ return false;
79​ }
80​
81​ if (role == PendingDeletionRole) {
82​ auto &item = m_data[index.row()];
83​
84​ const bool pendingDeletion = value.toBool();
85​
86​ if (item.pendingDeletion != pendingDeletion) {
87​ item.pendingDeletion = pendingDeletion;
88​ emit dataChanged(index, index, {PendingDeletionRole});
89​
90​ if (index.row() == selectedThemeIndex() && pendingDeletion) {
91​ // move to the next non-pending theme
92​ const auto nonPending = match(index, PendingDeletionRole, false);
93​ if (!nonPending.isEmpty()) {
94​ setSelectedTheme(nonPending.first().data(PluginNameRole).toString());
95​ }
96​ }
97​
98​ emit pendingDeletionsChanged();
99​ return true;
100​ }
101​ }
102​
103​ return false;
104​}
105​
106​QHash<int, QByteArray> ThemesModel::roleNames() const
107​{
108​ return {
109​ {Qt::DisplayRole, QByteArrayLiteral("display")},
110​ {PluginNameRole, QByteArrayLiteral("pluginName")},
111​ {DescriptionRole, QByteArrayLiteral("description")},
112​ {ColorTypeRole, QByteArrayLiteral("colorType")},
113​ {IsLocalRole, QByteArrayLiteral("isLocal")},
114​ {PendingDeletionRole, QByteArrayLiteral("pendingDeletion")}
115​ };
116​}
117​
118​QString ThemesModel::selectedTheme() const
119​{
120​ return m_selectedTheme;
121​}
122​
123​void ThemesModel::setSelectedTheme(const QString &pluginName)
124​{
125​ if (m_selectedTheme == pluginName) {
126​ return;
127​ }
128​
129​ m_selectedTheme = pluginName;
130​
131​ emit selectedThemeChanged(pluginName);
132​
133​ emit selectedThemeIndexChanged();
134​}
135​
136​int ThemesModel::pluginIndex(const QString &pluginName) const
137​{
138​ const auto results = match(index(0, 0), PluginNameRole, pluginName);
139​ if (results.count() == 1) {
140​ return results.first().row();
141​ }
142​
143​ return -1;
144​}
145​
146​int ThemesModel::selectedThemeIndex() const
147​{
148​ return pluginIndex(m_selectedTheme);
149​}
150​
151​void ThemesModel::load()
152​{
153​ beginResetModel();
154​
155​ const int oldCount = m_data.count();
156​
157​ m_data.clear();
158​
159​ // Get all desktop themes
160​ QStringList themes;
161​ const QStringList packs = QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, QStringLiteral("plasma/desktoptheme"), QStandardPaths::LocateDirectory);
162​ for(const QString &ppath : packs) {
ervinUnsubmitted
Done

A ref on a temporary sounds like a bad idea to me.

ervin: A ref on a temporary sounds like a bad idea to me.
davidreAuthorUnsubmitted
Not Done

Yeah that doesn't look right. The load method is a straight copy from the old load method.

davidre: Yeah that doesn't look right. The load method is a straight copy from the old load method.
163​ const QDir cd(ppath);
164​ const QStringList &entries = cd.entryList(QDir::Dirs | QDir::Hidden | QDir::NoDotAndDotDot);
165​ for (const QString &pack : entries) {
166​ const QString _metadata = ppath + QLatin1Char('/') + pack + QStringLiteral("/metadata.desktop");
ervinUnsubmitted
Done

Don't use Q_FOREACH but a proper for in new code

ervin: Don't use Q_FOREACH but a proper for in new code
167​ if (QFile::exists(_metadata)) {
168​ themes << _metadata;
169​ }
170​ }
171​ }
172​
173​ for (const QString &theme : qAsConst(themes)) {
174​ int themeSepIndex = theme.lastIndexOf(QLatin1Char('/'), -1);
ervinUnsubmitted
Done

qAsConst(themes)

ervin: qAsConst(themes)
175​ const QString themeRoot = theme.left(themeSepIndex);
176​ int themeNameSepIndex = themeRoot.lastIndexOf(QLatin1Char('/'), -1);
177​ const QString packageName = themeRoot.right(themeRoot.length() - themeNameSepIndex - 1);
178​
179​ KDesktopFile df(theme);
180​
181​ if (df.noDisplay()) {
182​ continue;
183​ }
184​
185​ QString name = df.readName();
186​ if (name.isEmpty()) {
187​ name = packageName;
188​ }
189​ const bool isLocal = QFileInfo(theme).isWritable();
190​ bool hasPluginName = std::any_of(m_data.begin(), m_data.end(), [&] (const ThemesModelData &item) {
191​ return item.pluginName == packageName;
192​ });
193​ if (!hasPluginName) {
194​ // Plasma Theme creates a KColorScheme out of the "color" file and falls back to system colors if there is none
195​ const QString colorsPath = themeRoot + QLatin1String("/colors");
196​ const bool followsSystemColors = !QFileInfo::exists(colorsPath);
197​ ColorType type = FollowsColorTheme;
198​ if (!followsSystemColors) {
199​ const KSharedConfig::Ptr config = KSharedConfig::openConfig(colorsPath);
200​ const QPalette palette = KColorScheme::createApplicationPalette(config);
201​ const int windowBackgroundGray = qGray(palette.window().color().rgb());
202​ if (windowBackgroundGray < 192) {
203​ type = DarkTheme;
204​ } else {
205​ type = LightTheme;
206​ }
207​ }
208​ ThemesModelData item {
209​ name,
210​ packageName,
211​ df.readComment(),
212​ type,
213​ isLocal,
214​ false
215​ };
216​ m_data.append(item);
217​ }
218​ }
219​
220​ QCollator collator;
221​ std::sort(m_data.begin(), m_data.end(), [&collator](const ThemesModelData &a, const ThemesModelData &b) {
222​ return collator.compare(a.display, b.display) < 0;
223​ });
224​
225​ endResetModel();
226​
227​ // an item might have been added before the currently selected one
228​ if (oldCount != m_data.count()) {
229​ emit selectedThemeIndexChanged();
230​ }
231​}
232​
233​QStringList ThemesModel::pendingDeletions() const
234​{
235​ QStringList pendingDeletions;
236​
237​ for (const auto &item : qAsConst(m_data)) {
238​ if (item.pendingDeletion) {
ervinUnsubmitted
Done

qAsConst(m_data)

ervin: qAsConst(m_data)
davidreAuthorUnsubmitted
Not Done

Is it also needed in a const member method?

davidre: Is it also needed in a const member method?
ervinUnsubmitted
Not Done

Not strictly speaking indeed.

Now C++ being what it is you're never safe of someone introducing a member as mutable though. ;-)

ervin: Not strictly speaking indeed. Now C++ being what it is you're never safe of someone…
239​ pendingDeletions.append(item.pluginName);
240​ }
241​ }
242​
243​ return pendingDeletions;
244​}
245​
246​void ThemesModel::removeRow(int row)
247​{
248​ beginRemoveRows(QModelIndex(), row, row);
249​ m_data.erase(m_data.begin() + row);
250​ endRemoveRows();
251​}