Differential D26039 Diff 71722 kcms/desktoptheme/themesmodel.cpp

Changeset View

Standalone View

View Options

kcms/desktoptheme/themesmodel.cpp

  • This file was added.
1​/*
2​ * Copyright (C) 2007 Matthew Woehlke <mw_triad@users.sourceforge.net>
3​ * Copyright (C) 2007 Jeremy Whiting <jpwhiting@kde.org>
4​ * Copyright (C) 2016 Olivier Churlaud <olivier@churlaud.com>
5​ * Copyright (C) 2019 Kai Uwe Broulik <kde@privat.broulik.de>
6​ * Copyright (C) 2019 David Redondo <kde@david-redondo.de>
7​ *
8​ * This program is free software; you can redistribute it and/or
9​ * modify it under the terms of the GNU General Public License as
10​ * published by the Free Software Foundation; either version 2 of
11​ * the License or (at your option) version 3 or any later version
12​ * accepted by the membership of KDE e.V. (or its successor approved
13​ * by the membership of KDE e.V.), which shall act as a proxy
14​ * defined in Section 14 of version 3 of the license.
15​ *
16​ * This program is distributed in the hope that it will be useful,
17​ * but WITHOUT ANY WARRANTY; without even the implied warranty of
18​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
19​ * GNU General Public License for more details.
20​ *
21​ * You should have received a copy of the GNU General Public License
22​ * along with this program. If not, see <http://www.gnu.org/licenses/>.
23​ */
24​
25​#include "themesmodel.h"
26​
27​#include <QCollator>
28​#include <QDir>
29​#include <QStandardPaths>
30​
31​#include <KColorScheme>
32​#include <KDesktopFile>
33​
34​#include <KConfigGroup>
35​#include <KSharedConfig>
36​
37​#include <algorithm>
38​#include <memory>
39​
40​ThemesModel::ThemesModel(QObject *parent) : QAbstractListModel(parent)
41​{
42​
43​}
44​
45​ThemesModel::~ThemesModel() = default;
46​
47​int ThemesModel::rowCount(const QModelIndex &parent) const
48​{
49​ if (parent.isValid()) {
50​ return 0;
51​ }
52​
53​ return m_data.count();
54​}
55​
56​QVariant ThemesModel::data(const QModelIndex &index, int role) const
57​{
58​ if (!index.isValid() || index.row() >= m_data.count()) {
59​ return QVariant();
60​ }
61​
62​ const auto &item = m_data.at(index.row());
63​
64​ switch (role) {
65​ case Qt::DisplayRole: return item.display;
66​ case PluginNameRole: return item.pluginName;
67​ case DescriptionRole: return item.description;
68​ case ColorTypeRole: return item.type;
69​ case IsLocalRole: return item.isLocal;
70​ case PendingDeletionRole: return item.pendingDeletion;
71​ }
72​ return QVariant();
73​}
74​
75​bool ThemesModel::setData(const QModelIndex &index, const QVariant &value, int role)
76​{
77​ if (!index.isValid() || index.row() >= m_data.count()) {
78​ return false;
79​ }
80​
81​ if (role == PendingDeletionRole) {
82​ auto &item = m_data[index.row()];
83​
84​ const bool pendingDeletion = value.toBool();
85​
86​ if (item.pendingDeletion != pendingDeletion) {
87​ item.pendingDeletion = pendingDeletion;
88​ emit dataChanged(index, index, {PendingDeletionRole});
89​
90​ // move to the next non-pending theme
91​ const auto nonPending = match(index, PendingDeletionRole, false);
92​ if (!nonPending.isEmpty()) {
93​ setSelectedTheme(nonPending.first().data(PluginNameRole).toString());
94​ }
95​
96​ emit pendingDeletionsChanged();
97​ return true;
98​ }
99​ }
100​
101​ return false;
102​}
103​
104​QHash<int, QByteArray> ThemesModel::roleNames() const
105​{
106​ return {
107​ {Qt::DisplayRole, QByteArrayLiteral("display")},
108​ {PluginNameRole, QByteArrayLiteral("pluginName")},
109​ {DescriptionRole, QByteArrayLiteral("description")},
110​ {ColorTypeRole, QByteArrayLiteral("colorType")},
111​ {IsLocalRole, QByteArrayLiteral("isLocal")},
112​ {PendingDeletionRole, QByteArrayLiteral("pendingDeletion")}
113​ };
114​}
115​
116​QString ThemesModel::selectedTheme() const
117​{
118​ return m_selectedTheme;
119​}
120​
121​void ThemesModel::setSelectedTheme(const QString &pluginName)
122​{
123​ if (m_selectedTheme == pluginName) {
124​ return;
125​ }
126​
127​ m_selectedTheme = pluginName;
128​
129​ emit selectedThemeChanged(pluginName);
130​
131​ emit selectedThemeIndexChanged();
132​}
133​
134​int ThemesModel::pluginIndex(const QString &pluginName) const
135​{
136​ const auto results = match(index(0, 0), PluginNameRole, pluginName);
137​ if (results.count() == 1) {
138​ return results.first().row();
139​ }
140​
141​ return -1;
142​}
143​
144​int ThemesModel::selectedThemeIndex() const
145​{
146​ return pluginIndex(m_selectedTheme);
147​}
148​
149​void ThemesModel::load()
150​{
151​ beginResetModel();
152​
153​ const int oldCount = m_data.count();
154​
155​ m_data.clear();
156​
157​ // Get all desktop themes
158​ QStringList themes;
159​ const QStringList &packs = QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, QStringLiteral("plasma/desktoptheme"), QStandardPaths::LocateDirectory);
160​ for(const QString &ppath : packs) {
161​ const QDir cd(ppath);
162​ const QStringList &entries = cd.entryList(QDir::Dirs | QDir::Hidden | QDir::NoDotAndDotDot);
ervinUnsubmitted
Done

A ref on a temporary sounds like a bad idea to me.

ervin: A ref on a temporary sounds like a bad idea to me.
davidreAuthorUnsubmitted
Not Done

Yeah that doesn't look right. The load method is a straight copy from the old load method.

davidre: Yeah that doesn't look right. The load method is a straight copy from the old load method.
163​ Q_FOREACH (const QString &pack, entries) {
164​ const QString _metadata = ppath + QLatin1Char('/') + pack + QStringLiteral("/metadata.desktop");
165​ if (QFile::exists(_metadata)) {
166​ themes << _metadata;
ervinUnsubmitted
Done

Don't use Q_FOREACH but a proper for in new code

ervin: Don't use Q_FOREACH but a proper for in new code
167​ }
168​ }
169​ }
170​
171​ for (const QString &theme : themes) {
172​ int themeSepIndex = theme.lastIndexOf(QLatin1Char('/'), -1);
173​ const QString themeRoot = theme.left(themeSepIndex);
174​ int themeNameSepIndex = themeRoot.lastIndexOf(QLatin1Char('/'), -1);
ervinUnsubmitted
Done

qAsConst(themes)

ervin: qAsConst(themes)
175​ const QString packageName = themeRoot.right(themeRoot.length() - themeNameSepIndex - 1);
176​
177​ KDesktopFile df(theme);
178​
179​ if (df.noDisplay()) {
180​ continue;
181​ }
182​
183​ QString name = df.readName();
184​ if (name.isEmpty()) {
185​ name = packageName;
186​ }
187​ const bool isLocal = QFileInfo(theme).isWritable();
188​ bool hasPluginName = std::any_of(m_data.begin(), m_data.end(), [&] (const ThemesModelData &item) {
189​ return item.pluginName == packageName;
190​ });
191​ if (!hasPluginName) {
192​ // Plasma Theme creates a KColorScheme out of the "color" file and falls back to system colors if there is none
193​ const QString colorsPath = themeRoot + QLatin1String("/colors");
194​ const bool followsSystemColors = !QFileInfo::exists(colorsPath);
195​ ColorType type = FollowsColorTheme;
196​ if (!followsSystemColors) {
197​ const KSharedConfig::Ptr config = KSharedConfig::openConfig(colorsPath);
198​ const QPalette palette = KColorScheme::createApplicationPalette(config);
199​ const int windowBackgroundGray = qGray(palette.window().color().rgb());
200​ if (windowBackgroundGray < 192) {
201​ type = DarkTheme;
202​ } else {
203​ type = LightTheme;
204​ }
205​ }
206​ ThemesModelData item {
207​ name,
208​ packageName,
209​ df.readComment(),
210​ type,
211​ isLocal,
212​ false
213​ };
214​ m_data.append(item);
215​ }
216​ }
217​
218​ QCollator collator;
219​ std::sort(m_data.begin(), m_data.end(), [&collator](const ThemesModelData &a, const ThemesModelData &b) {
220​ return collator.compare(a.display, b.display) < 0;
221​ });
222​
223​ endResetModel();
224​
225​ // an item might have been added before the currently selected one
226​ if (oldCount != m_data.count()) {
227​ emit selectedThemeIndexChanged();
228​ }
229​}
230​
231​QStringList ThemesModel::pendingDeletions() const
232​{
233​ QStringList pendingDeletions;
234​
235​ for (const auto &item : m_data) {
236​ if (item.pendingDeletion) {
237​ pendingDeletions.append(item.pluginName);
238​ }
ervinUnsubmitted
Done

qAsConst(m_data)

ervin: qAsConst(m_data)
davidreAuthorUnsubmitted
Not Done

Is it also needed in a const member method?

davidre: Is it also needed in a const member method?
ervinUnsubmitted
Not Done

Not strictly speaking indeed.

Now C++ being what it is you're never safe of someone introducing a member as mutable though. ;-)

ervin: Not strictly speaking indeed. Now C++ being what it is you're never safe of someone…
239​ }
240​
241​ return pendingDeletions;
242​}
243​
244​void ThemesModel::removeRow(int row)
245​{
246​ beginRemoveRows(QModelIndex(), row, row);
247​ m_data.erase(m_data.begin() + row);
248​ endRemoveRows();
249​}