Changeset View
Standalone View
src/filewidgets/kfilewidget.cpp
| Show First 20 Lines • Show All 1729 Lines • ▼ Show 20 Line(s) | 1729 | else { | |||
|---|---|---|---|---|---|
| 1730 | urlList = tokenize(filenames); | 1730 | urlList = tokenize(filenames); | ||
| 1731 | } | 1731 | } | ||
| 1732 | 1732 | | |||
| 1733 | filenames.clear(); // indicate that we parsed that one | 1733 | filenames.clear(); // indicate that we parsed that one | ||
| 1734 | 1734 | | |||
| 1735 | return urlList; | 1735 | return urlList; | ||
| 1736 | } | 1736 | } | ||
| 1737 | 1737 | | |||
| 1738 | // FIXME: current implementation drawback: a filename can't contain quotes | 1738 | // FIXME: current implementation drawback: a filename can't contain '" "' | ||
| 1739 | QList<QUrl> KFileWidgetPrivate::tokenize(const QString &line) const | 1739 | QList<QUrl> KFileWidgetPrivate::tokenize(const QString &line) const | ||
| 1740 | { | 1740 | { | ||
| 1741 | // qDebug(); | 1741 | // qDebug(); | ||
| 1742 | 1742 | | |||
| 1743 | QList<QUrl> urls; | 1743 | QList<QUrl> urls; | ||
| 1744 | QUrl u(ops->url()); | 1744 | QUrl u(ops->url()); | ||
| 1745 | if (!u.path().endsWith(QLatin1Char('/'))) { | 1745 | if (!u.path().endsWith(QLatin1Char('/'))) { | ||
| 1746 | u.setPath(u.path() + QLatin1Char('/')); | 1746 | u.setPath(u.path() + QLatin1Char('/')); | ||
| 1747 | } | 1747 | } | ||
| 1748 | QString name; | 1748 | QString name; | ||
| 1749 | 1749 | | |||
| 1750 | const int count = line.count(QLatin1Char('"')); | 1750 | const QRegularExpression re(QStringLiteral("\" \"")); | ||
| 1751 | if (count == 0) { // no " " -> assume one single file | 1751 | const auto match = re.match(line); | ||
| 1752 | | ||||
| 1753 | if (!match.hasMatch()) { | ||||
dfaure: What if I had `"file1.txt" "file2.txt"` and I manually edit that to remove the second file… | |||||
| 1752 | if (!QDir::isAbsolutePath(line)) { | 1754 | if (!QDir::isAbsolutePath(line)) { | ||
| 1753 | u = u.adjusted(QUrl::RemoveFilename); | 1755 | u = u.adjusted(QUrl::RemoveFilename); | ||
| 1754 | u.setPath(u.path() + line); | 1756 | u.setPath(u.path() + line); | ||
| 1755 | if (u.isValid()) { | 1757 | if (u.isValid()) { | ||
| 1756 | urls.append(u); | 1758 | urls.append(u); | ||
| 1757 | } | 1759 | } | ||
| 1758 | } else { | 1760 | } else { | ||
| 1759 | urls << QUrl::fromLocalFile(line); | 1761 | urls << QUrl::fromLocalFile(line); | ||
| 1760 | } | 1762 | } | ||
| 1761 | 1763 | | |||
| 1762 | return urls; | 1764 | return urls; | ||
| 1763 | } | 1765 | } | ||
| 1764 | 1766 | | |||
| 1765 | int start = 0; | 1767 | int index1 = 0, index2 = -1; | ||
| 1766 | int index1 = -1, index2 = -1; | | |||
| 1767 | while (true) { | 1768 | while (true) { | ||
| 1768 | index1 = line.indexOf(QLatin1Char('"'), start); | 1769 | index1 = line.indexOf(QStringLiteral("\""), index1); | ||
| 1769 | index2 = line.indexOf(QLatin1Char('"'), index1 + 1); | 1770 | // find next word separator | ||
| 1771 | index2 = line.indexOf(QStringLiteral("\" \""), index1 + 1); | ||||
this could move to after the if() block on the next line. dfaure: this could move to after the if() block on the next line.
If index1 < 0, there's no point in… | |||||
Isn't there a " at this position, always? Well, I guess we can keep an initial indexOf (outside the loop) in case there's a leading space (because a user manually removed the first file). So this needs additional unittests for leading space, trailing space, single-quoted-file .... and I wonder if we are OK with no longer supporting two spaces (e.g. because the user manually removed some intermediate file in the list). The separator is in fact " +" in regexp syntax, then? dfaure: Isn't there a `"` at this position, always?
Initially, at position 0, and then later, we know… | |||||
| 1770 | 1772 | | |||
| 1771 | if (index1 < 0 || index2 < 0) { | 1773 | if (index1 < 0) { | ||
| 1772 | break; | 1774 | break; | ||
| 1773 | } | 1775 | } | ||
| 1776 | if (index2 == -1) { | ||||
| 1777 | // when no word separator is found | ||||
| 1778 | // grab everything left until last character | ||||
| 1779 | index2 = line.length() -1; | ||||
Isn't the last character a double-quote (in the normal case)? Don't we want to stop just before it, to avoid grabbing it? Of course this opens the question of what to do if the last character is NOT a double-quote, but dfaure: Isn't the last character a double-quote (in the normal case)? Don't we want to stop just before… | |||||
| 1780 | } | ||||
| 1774 | 1781 | | |||
| 1775 | // get everything between the " " | 1782 | // get everything between the " " | ||
| 1776 | name = line.mid(index1 + 1, index2 - index1 - 1); | 1783 | name = line.mid(index1 + 1, index2 - index1 - 1); | ||
| 1777 | 1784 | | |||
| 1778 | // since we use setPath we need to do this under a temporary url | 1785 | // since we use setPath we need to do this under a temporary url | ||
| 1779 | QUrl _u(u); | 1786 | QUrl _u(u); | ||
| 1780 | QUrl currUrl(name); | 1787 | QUrl currUrl(name); | ||
| 1781 | 1788 | | |||
| 1782 | if (!QDir::isAbsolutePath(currUrl.url())) { | 1789 | if (!QDir::isAbsolutePath(currUrl.url())) { | ||
| 1783 | _u = _u.adjusted(QUrl::RemoveFilename); | 1790 | _u = _u.adjusted(QUrl::RemoveFilename); | ||
| 1784 | _u.setPath(_u.path() + name); | 1791 | _u.setPath(_u.path() + name); | ||
| 1785 | } else { | 1792 | } else { | ||
| 1786 | // we allow to insert various absolute paths like: | 1793 | // we allow to insert various absolute paths like: | ||
| 1787 | // "/home/foo/bar.txt" "/boot/grub/menu.lst" | 1794 | // "/home/foo/bar.txt" "/boot/grub/menu.lst" | ||
| 1788 | _u = currUrl; | 1795 | _u = currUrl; | ||
| 1789 | } | 1796 | } | ||
| 1790 | 1797 | | |||
| 1791 | if (_u.isValid()) { | 1798 | if (_u.isValid()) { | ||
| 1792 | urls.append(_u); | 1799 | urls.append(_u); | ||
| 1793 | } | 1800 | } | ||
| 1794 | 1801 | | |||
| 1795 | start = index2 + 1; | 1802 | index1 = index2 + 1; | ||
| 1796 | } | 1803 | } | ||
| 1797 | 1804 | | |||
| 1798 | return urls; | 1805 | return urls; | ||
| 1799 | } | 1806 | } | ||
| 1800 | 1807 | | |||
| 1801 | QString KFileWidget::selectedFile() const | 1808 | QString KFileWidget::selectedFile() const | ||
| 1802 | { | 1809 | { | ||
| 1803 | // qDebug(); | 1810 | // qDebug(); | ||
| ▲ Show 20 Lines • Show All 1162 Lines • Show Last 20 Lines | |||||
What if I had "file1.txt" "file2.txt" and I manually edit that to remove the second file, ending up with just "file1.txt"? The double-quotes will no longer be removed, because of this modified condition.