Differential D25539 Diff 70390 kcm/package/contents/ui/main.qml

Changeset View

Standalone View

View Options

kcm/package/contents/ui/main.qml

Show All 11 Lines
12GNU General Public License for more details. 12​GNU General Public License for more details.
13 13​
14You should have received a copy of the GNU General Public License 14​You should have received a copy of the GNU General Public License
15along with this program. If not, see <http://www.gnu.org/licenses/>. 15​along with this program. If not, see <http://www.gnu.org/licenses/>.
16*********************************************************************/ 16​*********************************************************************/
17import QtQuick 2.9 17​import QtQuick 2.9
18import QtQuick.Layouts 1.1 18​import QtQuick.Layouts 1.1
19import QtQuick.Controls 2.3 as Controls 19​import QtQuick.Controls 2.3 as Controls
20​import QtQuick.Dialogs 1.3
20import org.kde.kirigami 2.4 as Kirigami 21​import org.kde.kirigami 2.4 as Kirigami
21 22​
22import org.kde.kcm 1.2 as KCM 23​import org.kde.kcm 1.2 as KCM
23 24​
24KCM.SimpleKCM { 25​KCM.SimpleKCM {
25 id: root 26​ id: root
26 27​
27 implicitWidth: units.gridUnit * 32 28​ implicitWidth: units.gridUnit * 32
28 implicitHeight: units.gridUnit * 38 29​ implicitHeight: units.gridUnit * 38
29 30​
30 property int selectedOutput: 0 31​ property int selectedOutput: 0
32​ property int revertCountdown: 10
ngrahamUnsubmitted
Done

Doesn't seem to be used; the timer duration is hardcoded on the C++ side

ngraham: Doesn't seem to be used; the timer duration is hardcoded on the C++ side
liushuyuAuthorUnsubmitted
Not Done

Now, it's used by the Timer

liushuyu: Now, it's used by the Timer
31 33​
32 ColumnLayout { 34​ ColumnLayout {
33 Kirigami.InlineMessage { 35​ Kirigami.InlineMessage {
34 // Note1: There is an implicit height binding loop error on 36​ // Note1: There is an implicit height binding loop error on
35 // first invokation. Seems to be an issue in Kirigami. 37​ // first invokation. Seems to be an issue in Kirigami.
36 // Note2: This should maybe go in header component of the KCM, 38​ // Note2: This should maybe go in header component of the KCM,
37 // but there seems to be another issue in Kirigami then 39​ // but there seems to be another issue in Kirigami then
38 // being always hidden. Compare Night Color KCM with 40​ // being always hidden. Compare Night Color KCM with
▲ Show 20 Lines • Show All 42 Lines • ▼ Show 20 Line(s)
81 } 83​ }
82 Kirigami.InlineMessage { 84​ Kirigami.InlineMessage {
83 id: connectMsg 85​ id: connectMsg
84 Layout.fillWidth: true 86​ Layout.fillWidth: true
85 type: Kirigami.MessageType.Information 87​ type: Kirigami.MessageType.Information
86 visible: false 88​ visible: false
87 showCloseButton: true 89​ showCloseButton: true
88 } 90​ }
91​ Kirigami.InlineMessage {
92​ id: revertMsg
93​ Layout.fillWidth: true
94​ type: Kirigami.MessageType.Information
95​ text: i18n("Settings are reverted to the previous state.")
96​ visible: false
97​ showCloseButton: true
98​ }
99​ Kirigami.InlineMessage {
100​ id: confirmMsg
101​ Layout.fillWidth: true
102​ type: Kirigami.MessageType.Warning
103​ text: i18n("Is your screen displaying correctly?")
104​ visible: false
105​ showCloseButton: true
106​
107​ actions: [
108​ Kirigami.Action {
109​ iconName: "dialog-ok"
ndavisUnsubmitted
Not Done

Since you are keeping the recently applied configuration rather than applying a new one, wouldn't it be better to say something like "Keep"? It would also be better to use dialog-ok-apply as the icon for consistency with similar controls.

ndavis: Since you are keeping the recently applied configuration rather than applying a new one…
liushuyuAuthorUnsubmitted
Not Done

Will do

liushuyu: Will do
110​ text: i18n("Apply")
ngrahamUnsubmitted
Done

I would change these to StandardButton.Apply and StandardButton.Discard

ngraham: I would change these to `StandardButton.Apply` and `StandardButton.Discard`
liushuyuAuthorUnsubmitted
Not Done

Now InlineMessage is used

liushuyu: Now InlineMessage is used
111​ onTriggered: {
112​ confirmMsg.visible = false;
113​ revertTimer.stop();
114​ }
115​ },
ndavisUnsubmitted
Not Done

I would put Undo to the left of Keep/Apply. Normally, Undo/Reset is to the far left of Apply. That can't be the case here, but I think preserving the order is better for muscle memory.

ndavis: I would put Undo to the left of Keep/Apply. Normally, Undo/Reset is to the far left of Apply.
liushuyuAuthorUnsubmitted
Not Done

I will address this

liushuyu: I will address this
116​ Kirigami.Action {
117​ iconName: "dialog-ok"
118​ text: i18n("Undo")
119​ onTriggered: {
120​ confirmMsg.visible = false;
121​ kcm.revertSettings();
122​ }
123​ }
124​ ]
125​ }
89 126​
90 Connections { 127​ Connections {
91 target: kcm 128​ target: kcm
92 onDangerousSave: dangerousSaveMsg.visible = true; 129​ onDangerousSave: dangerousSaveMsg.visible = true;
93 onErrorOnSave: errSaveMsg.visible = true; 130​ onErrorOnSave: errSaveMsg.visible = true;
94 onGlobalScaleWritten: scaleMsg.visible = true; 131​ onGlobalScaleWritten: scaleMsg.visible = true;
95 onOutputConnect: { 132​ onOutputConnect: {
96 if (connected) { 133​ if (connected) {
97 connectMsg.text = i18n("A new output has been added. Settings have been reloaded."); 134​ connectMsg.text = i18n("A new output has been added. Settings have been reloaded.");
98 } else { 135​ } else {
99 connectMsg.text = i18n("An output has been removed. Settings have been reloaded."); 136​ connectMsg.text = i18n("An output has been removed. Settings have been reloaded.");
100 } 137​ }
101 connectMsg.visible = true; 138​ connectMsg.visible = true;
102 } 139​ }
103 onBackendError: errBackendMsg.visible = true; 140​ onBackendError: errBackendMsg.visible = true;
141​ onSettingsReverted: {
142​ revertMsg.visible = true;
143​ confirmMsg.visible = false;
144​ }
145​ onShowRevertWarning: {
146​ confirmMsg.visible = true;
147​ revertCountdown = 10;
148​ revertTimer.restart();
149​ }
104 150​
105 onChanged: { 151​ onChanged: {
106 dangerousSaveMsg.visible = false; 152​ dangerousSaveMsg.visible = false;
107 errSaveMsg.visible = false; 153​ errSaveMsg.visible = false;
108 scaleMsg.visible = false; 154​ scaleMsg.visible = false;
109 } 155​ }
110 } 156​ }
111 157​
112 Screen { 158​ Screen {
113 id: screen 159​ id: screen
114 160​
115 Layout.alignment: Qt.AlignHCenter 161​ Layout.alignment: Qt.AlignHCenter
116 Layout.preferredWidth: Math.max(root.width * 0.8, units.gridUnit * 26) 162​ Layout.preferredWidth: Math.max(root.width * 0.8, units.gridUnit * 26)
117 Layout.topMargin: Kirigami.Units.smallSpacing 163​ Layout.topMargin: Kirigami.Units.smallSpacing
118 Layout.bottomMargin: Kirigami.Units.largeSpacing * 2 164​ Layout.bottomMargin: Kirigami.Units.largeSpacing * 2
119 165​
120 enabled: kcm.outputModel && kcm.backendReady 166​ enabled: kcm.outputModel && kcm.backendReady
121 outputs: kcm.outputModel 167​ outputs: kcm.outputModel
122 } 168​ }
123 169​
124 Panel { 170​ Panel {
125 enabled: kcm.outputModel && kcm.backendReady 171​ enabled: kcm.outputModel && kcm.backendReady
126 Layout.fillWidth: true 172​ Layout.fillWidth: true
127 } 173​ }
174​
175​ Timer {
176​ id: revertTimer
177​ interval: 1000
178​ running: false
179​ repeat: true
180​
181​ onTriggered: {
182​ if (revertCountdown < 1) {
183​ // stop the timer
184​ this.stop();
185​ // reset the settings
186​ kcm.revertSettings();
187​ return;
188​ }
189​ revertCountdown -= 1;
190​ confirmMsg.text = i18np("Is your screen displaying correctly?<br><strong>Settings will be reverted in 1 second</strong>.",
191​ "Is your screen displaying correctly?<br><strong>Settings will be reverted in %1 seconds</strong>.", revertCountdown);
192​ }
193​ }
128 } 194​ }
129} 195​}