Changeset View
Changeset View
Standalone View
Standalone View
src/core/slavebase.h
Show First 20 Lines • Show All 1012 Lines • ▼ Show 20 Line(s) | 1007 | /** | |||
---|---|---|---|---|---|
1013 | */ | 1013 | */ | ||
1014 | void addTemporaryAuthorization(const QString &action); | 1014 | void addTemporaryAuthorization(const QString &action); | ||
1015 | 1015 | | |||
1016 | protected: | 1016 | protected: | ||
1017 | /** | 1017 | /** | ||
1018 | * Name of the protocol supported by this slave | 1018 | * Name of the protocol supported by this slave | ||
1019 | */ | 1019 | */ | ||
1020 | QByteArray mProtocol; | 1020 | QByteArray mProtocol; | ||
1021 | inline const QString mProtocolToStr() const { | ||||
dfaure: This method should be const | |||||
ahmadsamir: A B C, nothing changed inside make it const, D E F. | |||||
Yep ;) Hmm, also it's in the middle of member variables, better not mix them up. dfaure: Yep ;)
Hmm, also it's in the middle of member variables, better not mix them up.
Can you make… | |||||
1022 | return QString::fromLatin1(mProtocol); | ||||
1023 | } | ||||
1021 | //Often used by TcpSlaveBase and unlikely to change | 1024 | //Often used by TcpSlaveBase and unlikely to change | ||
1022 | MetaData mOutgoingMetaData; | 1025 | MetaData mOutgoingMetaData; | ||
1023 | MetaData mIncomingMetaData; | 1026 | MetaData mIncomingMetaData; | ||
1024 | 1027 | | |||
1025 | enum VirtualFunctionId { | 1028 | enum VirtualFunctionId { | ||
1026 | AppConnectionMade = 0, | 1029 | AppConnectionMade = 0, | ||
1027 | GetFileSystemFreeSpace = 1 // KF6 TODO: Turn into a virtual method | 1030 | GetFileSystemFreeSpace = 1 // KF6 TODO: Turn into a virtual method | ||
1028 | }; | 1031 | }; | ||
Show All 21 Lines |
This method should be const