Differential D22684 Diff 69775 klipper/historyimageitem.cpp

Changeset View

Standalone View

View Options

klipper/historyimageitem.cpp

Context not available.
18*/ 18​*/
19#include "historyimageitem.h" 19​#include "historyimageitem.h"
20 20​
21#include <QMimeData> 21​#include "historymodel.h"
22​
22#include <QCryptographicHash> 23​#include <QCryptographicHash>
24​#include <QIcon>
25​#include <QMimeData>
23 26​
24namespace { 27​namespace {
25 QByteArray compute_uuid(const QPixmap& data) { 28​ QByteArray compute_uuid(const QPixmap& data) {
Context not available.
39 42​
40QString HistoryImageItem::text() const { 43​QString HistoryImageItem::text() const {
41 if ( m_text.isNull() ) { 44​ if ( m_text.isNull() ) {
42 m_text = QStringLiteral( "%1x%2x%3 %4" ) 45​ m_text = QStringLiteral( "▨ %1x%2 %3bpp" )
davidedmundsonUnsubmitted
Done

what's this square about?

Also if "bpp" is bits per pixel, we need to put it in i18n() for translation

davidedmundson: what's this square about? Also if "bpp" is bits per pixel, we need to put it in i18n() for…
pdabrowskiAuthorUnsubmitted
Not Done

The square indicates that the clipboard contains an image, not a literal string like "1920x1080 32bpp".

i18n()

Done.

pdabrowski: The square indicates that the clipboard contains an image, not a literal string like "1920x1080…
43 .arg( m_data.width() ) 46​ .arg( m_data.width() )
44 .arg( m_data.height() ) 47​ .arg( m_data.height() )
45 .arg( m_data.depth() ); 48​ .arg( m_data.depth() );
46 } 49​ }
47 return m_text; 50​ return m_text;
48 ​
49} 51​}
50 52​
51/* virtual */ 53​/* virtual */
Context not available.
60 return data; 62​ return data;
61} 63​}
62 64​
65​const QPixmap& HistoryImageItem::image() const {
ngrahamUnsubmitted
Not Done

Does this have to be a pixmap? Can it just be a QIcon instead?

ngraham: Does this have to be a pixmap? Can it just be a QIcon instead?
pdabrowskiAuthorUnsubmitted
Not Done

This is overridden from HistoryItem parent class.

pdabrowski: This is overridden from HistoryItem parent class.
66​ if (m_model->displayImages()) {
67​ return m_data;
68​ }
69​ static QPixmap imageIcon(
70​ QIcon::fromTheme(QStringLiteral("viewimage")).pixmap(QSize(48, 48))
ngrahamUnsubmitted
Done

use the view-preview icon instead

ngraham: use the `view-preview` icon instead
71​ );
72​ return imageIcon;
73​}
Context not available.